all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 67117@debbugs.gnu.org, Denis Zubarev <dvzubarev@yandex.ru>
Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward
Date: Sat, 18 Nov 2023 10:47:47 -0800	[thread overview]
Message-ID: <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> (raw)
In-Reply-To: <83y1ezqhhk.fsf@gnu.org>



> On Nov 15, 2023, at 5:21 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Denis Zubarev <dvzubarev@yandex.ru>
>> Date: Sun, 12 Nov 2023 02:38:33 +0300
>> 
>> Steps to reproduce the issue:
>> 1. emacs -Q
>> 2. M-x find-file /tmp/t.py
>> 3. paste to the buffer
>> 
>> Temp(1, 2) 
>> 
>> 4. M-x python-ts-mode
>> 5. Call search-subtree with backward flag
>>   M-x eval-expression (treesit-search-subtree
>>               (treesit--thing-at (point) "call")
>>               (lambda (n) (equal (treesit-node-type n ) "integer"))
>>               t)
>> It should return the second int node (#<treesit-node integer in 9-10>), but it returns nil.
> 
> Yuan, any comments to the patch and the issue in general?

LGTM. Thanks Denis, and Eli :-)

Yuan




  parent reply	other threads:[~2023-11-18 18:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 23:38 bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Denis Zubarev
2023-11-15 13:21 ` Eli Zaretskii
2023-11-15 17:01   ` Eli Zaretskii
2023-11-18 18:47   ` Yuan Fu [this message]
2023-11-19  5:47     ` Eli Zaretskii
2023-11-19  6:13       ` Yuan Fu
2023-11-19  6:40         ` Eli Zaretskii
2023-11-21  4:23           ` Yuan Fu
2023-11-21 11:43             ` Eli Zaretskii
2023-11-25  3:44               ` Yuan Fu
2023-11-19  9:15         ` Eli Zaretskii
2023-11-19 11:25           ` Denis Zubarev
2023-11-19 11:45             ` Eli Zaretskii
2023-12-19  0:24               ` Denis Zubarev
2023-12-19  2:26                 ` Yuan Fu
2023-12-19 16:52                   ` Eli Zaretskii
2023-12-19 17:08                     ` Denis Zubarev
2023-12-23  7:09                       ` Yuan Fu
2023-12-26  0:39                         ` Yuan Fu
2023-12-19  3:24                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com \
    --to=casouri@gmail.com \
    --cc=67117@debbugs.gnu.org \
    --cc=dvzubarev@yandex.ru \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.