From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Matthew Leach <matthew@mattleach.net>
Cc: 18451@debbugs.gnu.org
Subject: bug#18451: 24.4.50; 'toggle-frame-fullscreen' can cut off minibuffer
Date: Tue, 16 Sep 2014 20:38:21 +0200 [thread overview]
Message-ID: <3ABE107B-3F0E-465A-908A-5943E493DDC0@swipnet.se> (raw)
In-Reply-To: <87oauitjiw.fsf@mattleach.net>
Hello.
14 sep 2014 kl. 15:32 skrev Matthew Leach <matthew@mattleach.net>:
> Jan Djärv <jan.h.d@swipnet.se> writes:
>
>> Hello.
>
> Hi Jan,
>
>
> [...]
>
>> If you compile Emacs yourself, you can debug this by tracing the
>> ConfigureNotify Emacs gets and/or the calls to change_frame_size and
>> xg_frame_resized. Obviously some call is either not made or made with
>> the wrong parameters. It may be a race condition so that Emacs gets
>> ConfigureNotify out of sequence.
>
> I have added trace prints in the functions that you suggested and things
> do look different when the bug occurs.
>
>
> The following trace is printed when the resize happens correctly (the
> trace seems to be the same between bug-free resize operations).
>
> ConfigureNotify event received.
> ConfigureNotify event received.
> ConfigureNotify event received.
> xg_frame_resized(0x6896f8, 1366, 768);
> change_frame_size(0x6896f8, 1350, 768, 0, 1, 0, 1);
> change_frame_size(0x6896f8, 1350, 768, 0, 0, 0, 1);
> ConfigureNotify event received.
> ConfigureNotify event received.
> ConfigureNotify event received.
> ConfigureNotify event received.
> xg_frame_resized(0x6896f8, 679, 729);
> change_frame_size(0x6896f8, 663, 729, 0, 1, 0, 1);
> change_frame_size(0x6896f8, 663, 729, 0, 0, 0, 1);
> ConfigureNotify event received
>
> This is the trace when the bug occurs (again, the trace is consistent
> between buggy resize operations):
>
The question is where does change_frame_size get called from from if they are not from xg_frame_resized?
As a long shot, try removing this line:
do_pending_window_change (0);
in xg_frame_resized.
Jan D.
> ConfigureNotify event received.
> ConfigureNotify event received.
> change_frame_size(0x6896f8, 1350, 768, 0, 1, 0, 1);
> ConfigureNotify event received.
> ConfigureNotify event received.
> change_frame_size(0x6896f8, 1350, 768, 0, 0, 1, 1);
> ConfigureNotify event received.
> ConfigureNotify event received.
> ConfigureNotify event received.
> xg_frame_resized(0x6896f8, 679, 729);
> change_frame_size(0x6896f8, 663, 729, 0, 1, 0, 1);
> change_frame_size(0x6896f8, 663, 729, 0, 0, 0, 1);
> ConfigureNotify event received.
> ConfigureNotify event received.
> xg_frame_resized(0x6896f8, 672, 720);
> change_frame_size(0x6896f8, 656, 720, 0, 1, 0, 1);
> change_frame_size(0x6896f8, 656, 720, 0, 0, 0, 1);
>
>
> xg_frame_resized doesn't seem to be called on the buggy trace when entering
> full-screen. Any ideas where else I could look?
> --
> Matt
next prev parent reply other threads:[~2014-09-16 18:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 16:20 bug#18451: 24.4.50; 'toggle-frame-fullscreen' can cut off minibuffer dev
2014-09-11 17:33 ` Jan Djärv
2014-09-11 17:52 ` Matthew Leach
2014-09-13 9:55 ` Jan Djärv
2014-09-13 22:13 ` Matthew Leach
2014-09-14 9:20 ` Jan Djärv
2014-09-14 13:32 ` Matthew Leach
2014-09-16 18:38 ` Jan Djärv [this message]
2014-09-16 19:16 ` Matthew Leach
2014-09-17 10:02 ` martin rudalics
2014-09-17 10:38 ` Matthew Leach
2014-09-18 9:32 ` martin rudalics
2014-09-18 12:01 ` Matthew Leach
2014-09-18 12:41 ` martin rudalics
2014-09-18 19:45 ` Jan Djärv
2014-09-19 10:22 ` Matthew Leach
2014-09-19 11:24 ` martin rudalics
2014-09-20 7:18 ` Jan Djärv
2015-01-04 18:09 ` martin rudalics
2015-02-13 18:24 ` martin rudalics
2014-09-17 16:05 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ABE107B-3F0E-465A-908A-5943E493DDC0@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=18451@debbugs.gnu.org \
--cc=matthew@mattleach.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.