From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel,gmane.emacs.windows Subject: Re: Patch to fix frame positioning bug on Windows with (make-frame '((left . -1))) Date: Wed, 12 Jan 2005 21:04:56 +0100 Message-ID: <3ABA18C9-64D5-11D9-83C1-000D93505B76@swipnet.se> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1105561549 1906 80.91.229.6 (12 Jan 2005 20:25:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 12 Jan 2005 20:25:49 +0000 (UTC) Cc: help-emacs-windows@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 12 21:25:39 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Cop3i-0001D4-00 for ; Wed, 12 Jan 2005 21:25:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CopFJ-0006nN-2B for ged-emacs-devel@m.gmane.org; Wed, 12 Jan 2005 15:37:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CopCY-00056g-GA for emacs-devel@gnu.org; Wed, 12 Jan 2005 15:34:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CopCX-00055c-1y for emacs-devel@gnu.org; Wed, 12 Jan 2005 15:34:45 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CopAN-0003sw-H4; Wed, 12 Jan 2005 15:32:31 -0500 Original-Received: from [195.54.107.70] (helo=mxfep01.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cookd-0001Qk-QF; Wed, 12 Jan 2005 15:05:56 -0500 Original-Received: from coolsville.localdomain ([83.226.180.210] [83.226.180.210]) by mxfep01.bredband.com with ESMTP id <20050112200553.DJCI15609.mxfep01.bredband.com@coolsville.localdomain>; Wed, 12 Jan 2005 21:05:53 +0100 In-Reply-To: Original-To: Francis Litterio X-Mailer: Apple Mail (2.619) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:32169 gmane.emacs.windows:2509 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32169 > Using Emacs built from CVS source code on Windows XP, the frame created > using the following Emacs-Lisp code is positioned such that the > rightmost 7 pixels of the frame are off the right edge of the screen: > > (make-frame '((width . 80) (height . 20) (top . 0) (left . -1))) > > Those 7 pixels encompass the border of the Windows frame and some of > the > right fringe. This may have been caused by revision 1.220 of w32term.c > in which function x_calc_absolute_position() was changed: > > revision 1.220 > date: 2004/12/11 21:12:45; author: jhd; state: Exp; lines: +0 -30 > * w32term.c (x_calc_absolute_position): Remove calculation of > difference between inner and outer window. Don't subtract difference > for left and top calculations. > > The below patch solves the problem but it may not be optimal because it > simply subtracts 7 from the computed value of f->left_pos. Can you verify if your change has any impact on this bug: http://lists.gnu.org/archive/html/emacs-pretest-bug/2004-11/ msg00519.html This was the reason a change was made. It may be impossible to get Emacs to work correctly on W32. Just adding 7 is no good, as you self pointed out, a more general solution must be found. Jan D.