From: Yuan Fu <casouri@gmail.com>
To: Mohammed Sadiq <sadiq@sadiqpk.org>
Cc: 60270@debbugs.gnu.org
Subject: bug#60270: 29.0.60; c-ts-mode: Comments are not indented right on auto indentation
Date: Fri, 13 Jan 2023 00:58:36 -0800 [thread overview]
Message-ID: <3A8DFD9A-5816-47AC-B3F6-3170FABA7F6E@gmail.com> (raw)
In-Reply-To: <EEBADA17-C17A-4FF5-B181-E4E4A49A4D41@gmail.com>
> On Jan 11, 2023, at 1:30 AM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Jan 10, 2023, at 2:13 AM, Mohammed Sadiq <sadiq@sadiqpk.org> wrote:
>>
>> On 2023-01-10 10:58, Yuan Fu wrote:
>>> Ah, right. Now it’s fixed. Thanks!
>>> Yuan
>>
>> This broke the following comment styles:
>>
>> /* some comment
>> */
>>
>> indentation of above code gives:
>>
>> /* some comment
>> */
>>
>>
>> Also:
>>
>> /*
>> * some comment
>> */
>>
>> where I expect:
>>
>> /*
>> * some comment
>> */
>
> This is easy to fix, I’ll push a fix soon.
I pushed the fix.
>
>>
>> If there are ways to add automated tests, it would be nice so that
>> these won't be broken when fixing something else.
>
> I agree. I have been busy fixing all sorts of bugs and haven’t go around to it :-(
I added the c-ts-mode tests you had in the patch.
Yuan
next prev parent reply other threads:[~2023-01-13 8:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 9:30 bug#60270: 29.0.60; c-ts-mode: Comments are not indented right on auto indentation Mohammed Sadiq
2022-12-24 8:33 ` Yuan Fu
2022-12-24 9:49 ` Mohammed Sadiq
2022-12-24 22:32 ` Yuan Fu
2022-12-25 4:34 ` Mohammed Sadiq
2022-12-25 8:36 ` Yuan Fu
2022-12-25 9:25 ` Eli Zaretskii
2023-01-03 14:30 ` Mohammed Sadiq
2022-12-25 9:46 ` Mohammed Sadiq
2023-01-07 23:28 ` Yuan Fu
2023-01-08 10:02 ` Mohammed Sadiq
2023-01-10 5:28 ` Yuan Fu
2023-01-10 10:13 ` Mohammed Sadiq
2023-01-10 12:17 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-11 9:27 ` Yuan Fu
2023-01-11 9:30 ` Yuan Fu
2023-01-13 8:58 ` Yuan Fu [this message]
2023-01-14 7:53 ` Yuan Fu
2023-01-15 5:28 ` Mohammed Sadiq
2023-01-16 8:24 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A8DFD9A-5816-47AC-B3F6-3170FABA7F6E@gmail.com \
--to=casouri@gmail.com \
--cc=60270@debbugs.gnu.org \
--cc=sadiq@sadiqpk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.