From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60443: 29.0.60; c-ts-mode: Consider re-using c-file-style and c-basic-offset Date: Sun, 1 Jan 2023 16:24:07 -0800 Message-ID: <3A4D5651-D41E-4733-8625-BDB4EE12B2E9@gmail.com> References: <0e9e8e06451e13d7bee3fd0c04939902@sadiqpk.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mohammed Sadiq , 60443@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 01:25:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC8di-0005KK-PM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 01:25:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC8dU-0005Ru-Gj; Sun, 01 Jan 2023 19:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC8dT-0005Rg-JZ for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC8dS-0007m0-O3 for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC8dS-0006f6-BA for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:25:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <0e9e8e06451e13d7bee3fd0c04939902@sadiqpk.org> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 00:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60443 X-GNU-PR-Package: emacs Original-Received: via spool by 60443-submit@debbugs.gnu.org id=B60443.167261905725544 (code B ref 60443); Mon, 02 Jan 2023 00:25:02 +0000 Original-Received: (at 60443) by debbugs.gnu.org; 2 Jan 2023 00:24:17 +0000 Original-Received: from localhost ([127.0.0.1]:42025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8ci-0006dw-VL for submit@debbugs.gnu.org; Sun, 01 Jan 2023 19:24:17 -0500 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:45944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8ch-0006dj-0f for 60443@debbugs.gnu.org; Sun, 01 Jan 2023 19:24:15 -0500 Original-Received: by mail-pj1-f50.google.com with SMTP id v13-20020a17090a6b0d00b00219c3be9830so26883558pjj.4 for <60443@debbugs.gnu.org>; Sun, 01 Jan 2023 16:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=Ca5yIn4q9neyslZgA28SbcshmnDrtefj4t6SAJqzsgs=; b=IGXDNsPNLMGPmifj0bzCIvZd7ZyJSYaLKj3PPAzBLwyZpNlJ2y9+7YU7XIKmfu0Jfp wYEVqTUDG/Nhu/psHZ/d/NdT6ZA7jaF+aPKHWdE46HIB3DKSuVS0ltTEx0sxNNahGxh0 hN3fmRKP616kbfI0nvfwjU3Sp+qJWn0nIf6Oi+2xB1XLsci+6kITEQ21XT1eiM+aXo+8 FXh0vh7CRUE+BI8GlssO0UQpf7w8MKHgOZUUW3RYvH8jtDQw96QPBK9qcZ+mpQWYRcLB PgwGe0+9ulrTe7kjF1XXAlvFp771rjsWTNik6a4O6uCgg7B7yp8VRPgykHZUJrJA+HCm 6g2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ca5yIn4q9neyslZgA28SbcshmnDrtefj4t6SAJqzsgs=; b=BwZZt7xhEJ+o+XCcjw2DMPEU7UOe+eiqAyB1Lt42w7BHj2jvFv3w3lLpiyenWOuUrh uQzk53hHkV8KCzTjTj4yWiUaXOGVMqfLnWBOQSPHHG2Ev58hJks2LmgYhSUij6r0mQ2X HfRi+DRTqJPjklWHMKqsbjiUI+5oMraTxfCVooXFfqmE5jF768ds1pm4lwXMfRPRQo3m bq1O41av1Ttj+TgFcMXoKfbTCzE9LnzDNa5RDRQxOyOJ44lKodBA8yajA8o5Uqv8Nsmw 4+uTTye9zNor5MoQeMt4S6Eg87K5j85Lge4jUe9L1NFNsqN8rZdydRAC2P8uL4zMa8Th 0MBw== X-Gm-Message-State: AFqh2ko/CUfScMtOSz6HQt5/gxNtOEqXUnxaWFDf+MsTJNcZr8C86+Y8 e1V1y5OBtfH8uJ93sD97z7o= X-Google-Smtp-Source: AMrXdXuIX3br64IK4enjcctKcS4vn5jOnQaGmTos6jYdKkPxFj4wdfqO/ZuOB5ZpY5KOUeQspMTChg== X-Received: by 2002:a05:6a20:8f0c:b0:af:cc4e:f2f with SMTP id b12-20020a056a208f0c00b000afcc4e0f2fmr61678164pzk.34.1672619049393; Sun, 01 Jan 2023 16:24:09 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id k187-20020a6284c4000000b005769b23260fsm17713208pfd.18.2023.01.01.16.24.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jan 2023 16:24:09 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252297 Archived-At: Dmitry Gutov writes: > On 31/12/2022 06:02, Yuan Fu wrote: >> IIUC part of the reason why we created separate major modes is that >> we don=E2=80=99t want to share configuration variables between the >> tree-sitter and elisp implementation. If they share some of the >> configuration variable but not all, it would be very confusing; it >> they share all variables, well that=E2=80=99s not possible because = c-ts-mode >> doesn=E2=80=99t support all of c-mode=E2=80=99s features. > > js-ts-mode uses js-indent-level. css-ts-mode uses css-indent-offset. > python-ts-mode and bash-ts-mode don't have their own indentation > settings, so I suppose they reuse the "regular" indentation code. > > There are a lot of other ts modes which don't have anything to reuse > ("regular" mode is not in Emacs). > > FWIW, that's my plan for ruby-ts-mode: to share those options where > it's feasible, to avoid random duplication, and to make comparing and > switching easier. The test suite can be shared more easily too. Hmm, yes, those modes live in the same file, and can be considered the same package. c-ts-mode.el is separate from cc-mode.el so it makes less sense to share variables. Maybe we can say "same package, share vars, different package, different vars", to avoid confusion? Yuan