Re: inline code block problem; first attempt

Re: inline code block problem; first attempt

[Eric S Fraga]

Can you please post a complete example so that others can try it?  Also,
what version of org etc.?

-- 
: Eric S Fraga (0xFFFCF67D), Emacs 25.0.94.1, Org release_8.3.4-869-gf2c421

Re: inline code block problem; first attempt

[Charles Millar]

I am getting careless.


On 06/08/2016 02:36 PM, Eric S Fraga wrote:
> Can you please post a complete example so that others can try it?  Also,
> what version of org etc.?
>
sample.org file

* TOTALCOM                               :ignoreheading:

#+NAME: TOTALCOM
#+ATTR_LATEX: :mode table :environment longtable :align p{415pt}N{8}{2}
| {{{cmhfill}}} Total commissions due | 99990.00 |


#+begin_src emacs-lisp :var totalcommissions=TOTALCOM[-1,-1]
totalcommissions
#+end_src

#+RESULTS:
: 99990.0

Inline version src_emacs-lisp[:var 
totalcommissions=TOTALCOM[-1,-1]]{totalcommissions}

GNU Emacs 24.4.1 (x86_64-pc-linux-gnu, GTK+ Version 3.14.5) of 
2015-03-07 on trouble, modified by Debian

Org-mode version 8.3.4 (release_8.3.4-894-gf94df5 @ 
/usr/local/share/emacs/site-lisp/org-mode/lisp/)

Charlie

Re: inline code block problem; first attempt

[Charles C. Berry]

On Wed, 8 Jun 2016, Eric S Fraga wrote:

> Can you please post a complete example so that others can try it?  Also,
> what version of org etc.?

A bug in `org-element-inline-src-block-parser', I think.

Here is an ECM:

src_emacs-lisp[:var totalcommissions=TOTALCOM]{totalcommissions}
src_emacs-lisp[:var totalcommissions=TOTALCOM[-1,-1]]{totalcommissions}
#+BEGIN_SRC emacs-lisp
     (save-excursion
       (org-babel-goto-src-block-head)
       (forward-line -1)
       (list (org-element-type (org-element-inline-src-block-parser))
 	    (progn (forward-line -1)
 		       (org-element-type
                          (org-element-inline-src-block-parser)))))

#+END_SRC

#+RESULTS:
| nil | inline-src-block |


Chuck

[PATCH} Re: inline code block problem; first attempt

[Charles C. Berry]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]



Patch atteched.

Replaced ']' with '{' in the regex `header' group.

Comments?

Chuck

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1102 bytes --]

From 2a060d4ca51dabbc6931a1483ae6c0ac29e0586c Mon Sep 17 00:00:00 2001
From: Charles Berry <ccberry@ucsd.edu>
Date: Wed, 8 Jun 2016 19:36:30 -0700
Subject: [PATCH] org-element-inline-src-block-parser fix regexp

* org-element.el (org-element-inline-src-block-parser): Header may
  include `[' and `]', but not `{'. This allows tables to be indexed
  in :var arguments.

Reported by: Charles Millar
http://article.gmane.org/gmane.emacs.orgmode/107624
---
 lisp/org-element.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-element.el b/lisp/org-element.el
index 8745ef3..d47f6f0 100644
--- a/lisp/org-element.el
+++ b/lisp/org-element.el
@@ -2916,7 +2916,7 @@ Assume point is at the beginning of the inline src block."
     (catch :no-object
       (when (let ((case-fold-search nil))
 	      (looking-at "\\<src_\\([^ \t\n[{]+\\)\
-\\(?:\\[[ \t]*\\([^]]*?\\)[ \t]*\\]\\)?{"))
+\\(?:\\[[ \t]*\\([^{]*?\\)[ \t]*\\]\\)?{"))
 	(let ((begin (point))
 	      (language (match-string-no-properties 1))
 	      (parameters
-- 
2.6.4 (Apple Git-63)

Re: [PATCH} Re: inline code block problem; first attempt

[Nicolas Goaziou]

Hello,

"Charles C. Berry" <ccberry@ucsd.edu> writes:

> Patch atteched.
>
> Replaced ']' with '{' in the regex `header' group.
>
> Comments?

Thank you for the patch. This is better than what we have now. However,
I don't think this is the way to go.

Forbidding "{" is already a minor annoyance, but porting the same logic
to `org-element-inline-babel-call-parser', which suffers from the same
bug, means forbidding "(" ; this is a major one.

I'd rather do the same as the body part and allow "[" (and "{"
obviously), as long as they are paired. This is less restrictive, IMO,
even acceptable in the case of "(".

I also started a fix along those lines yesterday but didn't get time to
finish it yet.

WDYT?

Regards,

-- 
Nicolas Goaziou

Re: [PATCH} Re: inline code block problem; first attempt

[Charles C. Berry]

On Thu, 9 Jun 2016, Nicolas Goaziou wrote:

> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
>> Patch atteched.
>>
>> Replaced ']' with '{' in the regex `header' group.
>>
>> Comments?
>
> Thank you for the patch. This is better than what we have now. However,
> I don't think this is the way to go.
>
> Forbidding "{" is already a minor annoyance, but porting the same logic
> to `org-element-inline-babel-call-parser', which suffers from the same
> bug, means forbidding "(" ; this is a major one.
>
> I'd rather do the same as the body part and allow "[" (and "{"
> obviously), as long as they are paired. This is less restrictive, IMO,
> even acceptable in the case of "(".
>

Agreed.

> I also started a fix along those lines yesterday but didn't get time to
> finish it yet.
>
> WDYT?

Sounds good.

Chuck

Re: [PATCH} Re: inline code block problem; first attempt

[Nicolas Goaziou]

Hello,

"Charles C. Berry" <ccberry@ucsd.edu> writes:

> Sounds good.

Done. Thank you for the feedback.

Regards,

-- 
Nicolas Goaziou

Re: [PATCH} Re: inline code block problem; first attempt

[Charles Millar]

Good morning,


On 06/10/2016 05:49 PM, Nicolas Goaziou wrote:
> Hello,
>
> "Charles C. Berry" <ccberry@ucsd.edu> writes:
>
>> Sounds good.
> Done. Thank you for the feedback.
>
Thank you Nicolas and Chuck.
Works for me, now.

Charlie Millar