From: Stephen Gildea <stepheng+emacs@gildea.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Andrea Corallo <akrl@sdf.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 7ce721b: Migrate MH-E functional tests from SourceForge
Date: Thu, 23 Sep 2021 22:49:06 -0700 [thread overview]
Message-ID: <3958921.1632462546@tigger3.sg.gildea.net> (raw)
In-Reply-To: Message from larsi@gnus.org of 23 Sep 2021 22:37:01 +0200 <877df7yqoi.fsf@gnus.org>
> This leads to the following test failure -- but only when
> native-compilation is enabled. And the backtrace looks pretty odd: It's
> failing when trying to make a trampoline for file-directory-p?
This test mocks out both call-process and file-directory-p. Apparently
changing file-directory-p causes call-process to be called to run a
separate Emacs process to natively compile the new file-directory-p.
This test does not expect that, and the mocked-out functions aren't
prepared to handle this case.
I can change mh-utils-tests.el to tell the native compiler to ignore it
(perhaps by binding native-comp-never-optimize-functions) but I'm
surprised that I have to. Why should fset of a locally-bound variable
cause a separate Emacs process to be run to compile it? That doesn't
seem to be a useful optimization, on the face of it.
Interestingly, I get a different failure when I run the tests with native
compilation enabled. But I think the fix will be the same for both.
< Stephen
next prev parent reply other threads:[~2021-09-24 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210922050338.16673.93930@vcs0.savannah.gnu.org>
[not found] ` <20210922050339.969F7207E0@vcs0.savannah.gnu.org>
2021-09-23 20:37 ` master 7ce721b: Migrate MH-E functional tests from SourceForge Lars Ingebrigtsen
2021-09-24 5:49 ` Stephen Gildea [this message]
2021-09-24 11:40 ` Eli Zaretskii
2021-09-24 16:00 ` Stephen Gildea
2021-09-25 0:50 ` Lars Ingebrigtsen
2021-09-25 6:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3958921.1632462546@tigger3.sg.gildea.net \
--to=stepheng+emacs@gildea.com \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.