From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#24972: 26.0.50; Multibyte characters are misaligned in ibuffer Date: Mon, 21 Nov 2016 14:00:14 +0800 Message-ID: <39442582-6036-47de-1a7a-4d46e43496c1@gmail.com> References: <87bmxa2d2v.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1479708076 2476 195.159.176.226 (21 Nov 2016 06:01:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Nov 2016 06:01:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 Cc: 24972@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 21 07:01:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8hfD-0000O7-JM for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 07:01:11 +0100 Original-Received: from localhost ([::1]:47685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8hfH-0007s6-2i for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Nov 2016 01:01:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8hf9-0007qx-4Y for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 01:01:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8hf4-0005yH-9l for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 01:01:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c8hf4-0005yB-6Y for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 01:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c8hf3-0006b6-U7 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2016 01:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2016 06:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24972-submit@debbugs.gnu.org id=B24972.147970803125316 (code B ref 24972); Mon, 21 Nov 2016 06:01:01 +0000 Original-Received: (at 24972) by debbugs.gnu.org; 21 Nov 2016 06:00:31 +0000 Original-Received: from localhost ([127.0.0.1]:36623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8heZ-0006aF-5V for submit@debbugs.gnu.org; Mon, 21 Nov 2016 01:00:31 -0500 Original-Received: from mail-pg0-f68.google.com ([74.125.83.68]:36275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8heX-0006a3-Rl for 24972@debbugs.gnu.org; Mon, 21 Nov 2016 01:00:30 -0500 Original-Received: by mail-pg0-f68.google.com with SMTP id x23so27549210pgx.3 for <24972@debbugs.gnu.org>; Sun, 20 Nov 2016 22:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=KSX4nbJtr6gQ6XyTGDR/7dctJ/VSgLwviNXWhJ8YvMg=; b=aCdo0uwz76VJ884h/V2M+MbmopDb5OlqwNSedsUtjrWOUq5BPy9USoqVZ817kK7TO3 Bnv1qih1L2d4qnM4pCRtVqWynFeEOti6azo0xEqNjGPd4EeGxkwEAchX7sjDIX04mx4i k0hT75Su7PAE7MRRfcRAbZjMnJh0S2DHAPA2hYD9MWwsUS2cIsc0ZoXfiSjHksYhVpou 2UCvFmfas3TPIAe3qa7zS49sGyV/jEbkkM1Zy+RtgakE8NnAmBWHYEKFbhFjxWTnzJRC WI3TX0tQszHYbrRp+ahQiSZOoWkEJalQbJ/OWm0SNk1dc1EUkG7YbVIrSusya4qMsEKF sYXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KSX4nbJtr6gQ6XyTGDR/7dctJ/VSgLwviNXWhJ8YvMg=; b=kFC00Q2v2PsWoimQYPqPB/NbvDZWbFGqGekKMaRfasKscfZgFGH8e136AioZhvxT7s /DGzGz2Z9qzmFE7m2VMLFK6j4eYDV98fr+m2be9RiZRpTVR/mDGpo7+ioJUsK7A3ShfS iCLRk5ClaoEQ1eWS7sM7TxUbDRywTW/JtswgzrMfIX0co9vzlywpkYs+7PW0R62jHUNK ILjLGor2ea0X0+IStgsUO7oEG0pVbVAf7wWlm8M/HJ4mzQA0f1E1iOrBqXjtxQtnkSWc APBVuze1Sc61j6aL/5IiCnKVzAdpWw/Xo5q5Ei/Gjsq5ClnIatP+i+BkdHFgCiYWZyKm yyjg== X-Gm-Message-State: AKaTC00b+qAjl2gvAP7zbIjpyQFls7lDTZls3rqYYrHffGLClH0I3J7jZxU4YArekgaeZA== X-Received: by 10.98.74.18 with SMTP id x18mr15884867pfa.58.1479708023784; Sun, 20 Nov 2016 22:00:23 -0800 (PST) Original-Received: from [0.0.0.0] ([188.166.240.79]) by smtp.gmail.com with ESMTPSA id i124sm15987492pgd.15.2016.11.20.22.00.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Nov 2016 22:00:23 -0800 (PST) In-Reply-To: <87bmxa2d2v.fsf@udel.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125936 Archived-At: 在 2016年11月21日 02:58, Mark Oteiza 写道: > > Liu Hui writes: >> As shown in the screenshot attached, multibyte characters (the second >> line) are misaligned in ibuffer. The problem seems at least relevant >> to the function `ibuffer-compile-format', which uses `length' rather >> than `string-width' for characters. > > Indeed, changing to string-width improves it. ibuffer should probably > also be using display properties to align the columns, but that's > another issue. > > Committed in 7e2a8b1. Thanks for reporting > Thank you, but I find it does not work when the multibyte string is long. For example, if the string-width of buffer name, e.g. "一个很长很长的文件名", exceeds the default width of ibuffer column, M-x ibuffer will fail and issue an error. According to the backtrace, it is because `ibuffer-compile-format' calls `ibuffer-compile-make-substring-form'/`ibuffer-compile-make-eliding-form', which use `substring' to truncate the multibyte string. A similar issue was reported in https://github.com/emacs-helm/helm/issues/170. Probably replacing `substring' solves the problem.