From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Sun, 27 Nov 2022 17:28:41 -0800 Message-ID: <393cb671-cfab-8e7e-6229-b59a1e376e1b@gmail.com> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> <83r0xpqwr6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------rCu4dtq0AeEu0M8vJUh4mjwg" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17546"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 28 02:29:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozSxP-0004Ni-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Nov 2022 02:29:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozSxD-00064S-Bp; Sun, 27 Nov 2022 20:29:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozSxC-00064K-8L for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 20:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozSxC-0004s5-04 for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 20:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozSxB-0005Kk-SL for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 20:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 01:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166959893120495 (code B ref 58877); Mon, 28 Nov 2022 01:29:01 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 28 Nov 2022 01:28:51 +0000 Original-Received: from localhost ([127.0.0.1]:45295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozSx1-0005KV-Co for submit@debbugs.gnu.org; Sun, 27 Nov 2022 20:28:51 -0500 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:41774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozSwz-0005KP-7P for 58877@debbugs.gnu.org; Sun, 27 Nov 2022 20:28:49 -0500 Original-Received: by mail-pg1-f175.google.com with SMTP id q71so8617614pgq.8 for <58877@debbugs.gnu.org>; Sun, 27 Nov 2022 17:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=MQuEdajQXaR8WC6WOKo5Yp5LXiR43+e664xuWcNjsZs=; b=hdG+vXjzNAyQYwocGXIeGj9WJJYKbMJuF1rB4c6wqJsgaAdAPcQFL6aFDZ3GkJYsT8 V3Yymv902sP6nUC6dR3TLAEezT1vnHxdt4CeulP9P6bFbUqS1TLePkL9FIOw5BijgMZ/ xkbyceUNr98Gcsaerknrzyi93z2GQucUmzSqin3hqTNMoN5KGJuhXeek/kyvL/0k8eOG ja2R1LwXr3nndU9KJhVNNZci5dnpaZ+7JxRMdCBkEGxg5JBd3PL/tyjHjtRgdS/7qa3+ Mg/UEOXBAxuH0B0qvGee2Il/jp1KY/65cfk+tkGdAziJ9W8XFjWzJbcD24/uEFYK7lqD 8zVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MQuEdajQXaR8WC6WOKo5Yp5LXiR43+e664xuWcNjsZs=; b=ht/Zhku4o7qmLrHgLfmutp39o6Sb19LoLVztz3mJI6Z2khynTxuVq+uKOdv9EhcBRK UtknmMJM9QCTmiohrCzi7W2HDwHBAZ8ASLn4Cu00hDUkKTHcTWaWrDzo0IT37vNW2vSq lb+9dnodG0RcMqNJFG+XDAZMJRM7vJT9Yx5hqNutSJY/ik0qrOjvIY5MuL9FnuyV+VcK 5IAXB0Dz3L1vTmO8J8vpvA/k9PqgTEfs8neHjSfrfRztEpxhIwt2Lwi1VjMw7GrMd5WL fc9KyXa4crvkPySj+RGge8gAuFsMebnEoF5POBc2zUeTzW6H/jyX050R/RjvWGGcrK0/ XgtA== X-Gm-Message-State: ANoB5pmAQzex6n0cFMW24g6YUGgS/4d4J6iGbivWbi5QznRLYNlZXLWC hXzjG4dURGsnBzYHMoj0MJs= X-Google-Smtp-Source: AA0mqf4L+/iwzOS0W5Jn2DYh6rPZ9ueG8toluSbPXEE3W+nQ+Lhg1gCfTLfQj7R6fluxBLysSnLDcw== X-Received: by 2002:a63:fa41:0:b0:476:e84c:ab65 with SMTP id g1-20020a63fa41000000b00476e84cab65mr26727698pgk.513.1669598923229; Sun, 27 Nov 2022 17:28:43 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 17-20020a170902e9d100b0018544ad1e8esm7407115plk.238.2022.11.27.17.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 17:28:42 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249260 Archived-At: This is a multi-part message in MIME format. --------------rCu4dtq0AeEu0M8vJUh4mjwg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/26/2022 1:44 PM, Jim Porter wrote: > On 11/26/2022 12:35 PM, Eli Zaretskii wrote: >>> Date: Sat, 26 Nov 2022 12:17:59 -0800 >>> Cc: 58877@debbugs.gnu.org >>> From: Jim Porter >>> >>> Unless you have an idea for how to fix that (I've got no clue, >>> unfortunately), how about just skipping these tests on MS Windows, with >>> a comment explaining what the limitation is? >> >> Fine with me, thanks. > > Thanks. I've merged the fixes for the tests as > 14d54212ea46dbd8c950c9852318597e0e47908d. If you see any other issues, > just let me know. Here's one tiny followup fix. Currently on master, if you restart the Emacs server, it emits a "Server stopped" message. That's not right, and it should do what it used to: emit a "Restarting server" message. Here's a fix. --------------rCu4dtq0AeEu0M8vJUh4mjwg Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-Server-stopped-message-when-restarting-.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-Server-stopped-message-when-restarting-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxNzI0ZjIzZjNkOGIzYmVmMThiY2Q5N2UyZjg5MmU5NDNmMDNjMGRhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMTc6MjI6NDkgLTA4MDAKU3ViamVjdDogW1BB VENIXSA7IERvbid0IGVtaXQgYSAiU2VydmVyIHN0b3BwZWQiIG1lc3NhZ2Ugd2hlbiByZXN0 YXJ0aW5nIHRoZQogRW1hY3Mgc2VydmVyCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3Rv cCk6IFJldHVybiBub24tbmlsIHdoZW4gd2UgYWN0dWFsbHkgc3RvcAp0aGUgc2VydmVyLiAg RG9uJ3QgbWVzc2FnZSBhYm91dCBzdG9wcGluZyB0aGUgc2VydmVyIGhlcmUgKGJ1dCBkbyBs b2cKaXQpLgooc2VydmVyLXN0YXJ0KTogRW1pdCB0aGUgYXBwcm9wcmlhdGUgbWVzc2FnZSBh Ym91dCBzdG9wcGluZyBvcgpyZXN0YXJ0aW5nIHRoZSBzZXJ2ZXIuCi0tLQogbGlzcC9zZXJ2 ZXIuZWwgfCAyMiArKysrKysrKysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTIg aW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2 ZXIuZWwgYi9saXNwL3NlcnZlci5lbAppbmRleCAyMTAyZjg1NjliLi4xYjAyN2Y4OGNlIDEw MDY0NAotLS0gYS9saXNwL3NlcnZlci5lbAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNjE5 LDIwICs2MTksMjIgQEAgc2VydmVyLS1maWxlLW5hbWUKIAogKGRlZnVuIHNlcnZlci1zdG9w ICgmb3B0aW9uYWwgbm9mcmFtZSkKICAgIklmIHRoaXMgRW1hY3MgcHJvY2VzcyBoYXMgYSBz ZXJ2ZXIgY29tbXVuaWNhdGlvbiBzdWJwcm9jZXNzLCBzdG9wIGl0LgotSWYgdGhlIHNlcnZl ciBpcyBydW5uaW5nIGluIHNvbWUgb3RoZXIgRW1hY3MgcHJvY2VzcyAoc2VlCitJZiB0aGlz IGFjdHVhbGx5IHN0b3BwZWQgdGhlIHNlcnZlciwgcmV0dXJuIG5vbi1uaWwuICBJZiB0aGUK K3NlcnZlciBpcyBydW5uaW5nIGluIHNvbWUgb3RoZXIgRW1hY3MgcHJvY2VzcyAoc2VlCiBg c2VydmVyLXJ1bm5pbmctcCcpLCBzaWduYWwgYSBgc2VydmVyLXJ1bm5pbmctZXh0ZXJuYWwn IGVycm9yLgogCiBJZiBOT0ZSQU1FIGlzIG5vbi1uaWwsIGRvbid0IGRlbGV0ZSBhbnkgZXhp c3RpbmcgZnJhbWVzCiBhc3NvY2lhdGVkIHdpdGggYSBjbGllbnQgcHJvY2Vzcy4gIFRoaXMg aXMgdXNlZnVsLCBmb3IgZXhhbXBsZSwKIHdoZW4ga2lsbGluZyBFbWFjcywgaW4gd2hpY2gg Y2FzZSB0aGUgZnJhbWVzIHdpbGwgZ2V0IGRlbGV0ZWQKIGFueXdheS4iCi0gIChsZXQgKChz ZXJ2ZXItZmlsZSAoc2VydmVyLS1maWxlLW5hbWUpKSkKKyAgKGxldCAoKHNlcnZlci1maWxl IChzZXJ2ZXItLWZpbGUtbmFtZSkpCisgICAgICAgIHN0b3BwZWQtcCkKICAgICAod2hlbiBz ZXJ2ZXItcHJvY2VzcwogICAgICAgOzsgS2lsbCBpdCBkZWFkIQogICAgICAgKGlnbm9yZS1l cnJvcnMgKGRlbGV0ZS1wcm9jZXNzIHNlcnZlci1wcm9jZXNzKSkKLSAgICAgICh1bmxlc3Mg bm9mcmFtZQotICAgICAgICAoc2VydmVyLWxvZyAobWVzc2FnZSAiU2VydmVyIHN0b3BwZWQi KSkpCi0gICAgICAoc2V0cSBzZXJ2ZXItcHJvY2VzcyBuaWwKKyAgICAgIChzZXJ2ZXItbG9n ICJTdG9wcGVkIHNlcnZlciIpCisgICAgICAoc2V0cSBzdG9wcGVkLXAgdAorICAgICAgICAg ICAgc2VydmVyLXByb2Nlc3MgbmlsCiAgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwKICAg ICAgICAgICAgIGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xvYmFs LW1pbm9yLW1vZGVzKSkpCiAgICAgKHVud2luZC1wcm90ZWN0CkBAIC02NTgsNyArNjYwLDgg QEAgc2VydmVyLXN0b3AKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZXJ2 ZXItbmFtZSkpKSkKICAgICAgIDs7IElmIHRoaXMgRW1hY3MgYWxyZWFkeSBoYWQgYSBzZXJ2 ZXIsIGNsZWFyIG91dCBhc3NvY2lhdGVkIHN0YXR1cy4KICAgICAgICh3aGlsZSBzZXJ2ZXIt Y2xpZW50cwotICAgICAgICAoc2VydmVyLWRlbGV0ZS1jbGllbnQgKGNhciBzZXJ2ZXItY2xp ZW50cykgbm9mcmFtZSkpKSkpCisgICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCAoY2Fy IHNlcnZlci1jbGllbnRzKSBub2ZyYW1lKSkpCisgICAgc3RvcHBlZC1wKSkKIAogOzs7IyMj YXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItc3RhcnQgKCZvcHRpb25hbCBsZWF2ZS1kZWFkIGlu aGliaXQtcHJvbXB0KQpAQCAtNzAyLDcgKzcwNSw4IEBAIHNlcnZlci1zdGFydAogICAgICAg ICAoaWYgKGFuZCBpbnRlcm5hbC0tZGFlbW9uLXNvY2tuYW1lCiAgICAgICAgICAgICAgICAg IChub3Qgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQpKQogICAgICAgICAg ICAgKHNldHEgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQgdCkKLSAgICAg ICAgICAoc2VydmVyLXN0b3ApKQorICAgICAgICAgICh3aGVuIChzZXJ2ZXItc3RvcCkKKyAg ICAgICAgICAgIChtZXNzYWdlIChpZiBsZWF2ZS1kZWFkICJTdG9wcGVkIHNlcnZlciIgIlJl c3RhcnRpbmcgc2VydmVyIikpKSkKICAgICAgIChzZXJ2ZXItcnVubmluZy1leHRlcm5hbAog ICAgICAgIChkaXNwbGF5LXdhcm5pbmcKICAgICAgICAgJ3NlcnZlcgpAQCAtNzE3LDggKzcy MSw2IEBAIHNlcnZlci1zdGFydAogICAgICAgKGxldCAoKHNlcnZlci1maWxlIChzZXJ2ZXIt LWZpbGUtbmFtZSkpKQogCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNhZmUgZGlyZWN0b3J5 IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCiAJKHNlcnZlci1lbnN1cmUtc2FmZS1k aXIgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2VydmVyLWZpbGUpKQotCSh3aGVuIHNlcnZlci1w cm9jZXNzCi0JICAoc2VydmVyLWxvZyAobWVzc2FnZSAiUmVzdGFydGluZyBzZXJ2ZXIiKSkp CiAgICAgICAgICh3aXRoLWZpbGUtbW9kZXMgP1w3MDAKIAkgIChhZGQtaG9vayAnc3VzcGVu ZC10dHktZnVuY3Rpb25zICMnc2VydmVyLWhhbmRsZS1zdXNwZW5kLXR0eSkKIAkgIChhZGQt aG9vayAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucyAjJ3NlcnZlci1oYW5kbGUtZGVsZXRlLWZy YW1lKQpAQCAtNzU2LDcgKzc1OCw3IEBAIHNlcnZlci1zdGFydAogCQkJICAgICAgIDpzZXJ2 aWNlIHNlcnZlci1maWxlCiAJCQkgICAgICAgOnBsaXN0ICcoOmF1dGhlbnRpY2F0ZWQgdCkp KSkpCiAJICAodW5sZXNzIHNlcnZlci1wcm9jZXNzIChlcnJvciAiQ291bGQgbm90IHN0YXJ0 IHNlcnZlciBwcm9jZXNzIikpCi0gICAgICAgICAgKHNlcnZlci1sb2cgIlN0YXJ0aW5nIHNl cnZlciIpCisgICAgICAgICAgKHNlcnZlci1sb2cgIlN0YXJ0ZWQgc2VydmVyIikKIAkgIChw cm9jZXNzLXB1dCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUgc2VydmVyLWZpbGUpCiAg ICAgICAgICAgKHNldHEgc2VydmVyLW1vZGUgdCkKICAgICAgICAgICAocHVzaCAnc2VydmVy LW1vZGUgZ2xvYmFsLW1pbm9yLW1vZGVzKQotLSAKMi4yNS4xCgo= --------------rCu4dtq0AeEu0M8vJUh4mjwg--