all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mark H. David" <mhd@yv.org>
To: "Emacs Development" <emacs-devel@gnu.org>
Subject: Re: eglot manual suggestions
Date: Mon, 24 Oct 2022 11:37:08 -0700	[thread overview]
Message-ID: <39247e32-a0c5-43db-a4ba-7bc15e19b52d@app.fastmail.com> (raw)
In-Reply-To: <87y1t5p0lj.fsf@gmail.com>

Native English speaker and grammar nerd here. Wow, these are some interesting English fine points. FWIW, Robert is 100% right on with all these changes IMHO.
-mhd

----- Original message -----
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: eglot manual suggestions
Date: Monday, October 24, 2022 10:56 AM

>>>>> On Mon, 24 Oct 2022 20:03:23 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Date: Mon, 24 Oct 2022 18:00:35 +0200
    >> 
    >> Normally, Iʼd just commit this, but I feel the Grammar Dragon has been
    >> poked enough for one week. I care not a whit if these are
    >> characterised as 'style changes' or 'grammar corrections', but I feel
    >> they are improvements.

    Eli> In general, LGTM, thanks.  However, ...

    >> -Eglot uses the Emacs's project management infrastructure to figure out
    >> +Eglot uses the Emacs project management infrastructure to figure out

    Eli> Is "Emacs's" really wrong?

"Emacsʼs" is not, but "the Emacsʼs" is. We can drop the "the" and
retain "Emacsʼs" if you prefer

    >> -This section provides a reference of the most commonly used Eglot
    >> +This section provides a reference for the most commonly used Eglot

    Eli> Is "reference of" incorrect?

Itʼs unusual. Here "reference" is used as "a list that you can refer
to", which to me implies "for". But Iʼm not wedded to it

    >> -To have Eglot stay away of some Emacs feature, add that feature's
    >> +To have Eglot stay away from some Emacs feature, add that feature's

    Eli> "Stay away of" is incorrect?

Yes

    >> -If possible, we recommend to use these configuration files that are
    >> +If possible, we recommend to use those configuration files that are
    >> independent of Eglot and Emacs; they have the advantage that they will
    >> work with other LSP clients as well.
    >> 
    >> If you do need to provide Emacs-specific configuration for a language
    >> -server, we recommend to define the appropriate value in the
    >> +server, we recommend defining the appropriate value in the

    Eli> Here, you contradict yourself: if "recommend to use" is OK, then why
    Eli> "recommend to define" isn't?

That just means I missed the first one :-)

    Eli> And AFAIU, both forms are correct English.

Possibly, but verb + gerund is more common and reads better.

    Eli> Also, why "those" in preference to "these"?

Because weʼre referring to files that are not Emacs configuration
files, hence "those" emphasises their otherness: "Donʼt use these, use
*those*"

Robert
-- 




  reply	other threads:[~2022-10-24 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 16:00 eglot manual suggestions Robert Pluim
2022-10-24 17:03 ` Eli Zaretskii
2022-10-24 17:56   ` Robert Pluim
2022-10-24 18:37     ` Mark H. David [this message]
2022-10-25  0:33   ` Po Lu
2022-10-25  8:29     ` João Távora
2022-10-25  9:39       ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39247e32-a0c5-43db-a4ba-7bc15e19b52d@app.fastmail.com \
    --to=mhd@yv.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.