From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Fri, 4 Nov 2022 03:13:07 +0200 Message-ID: <3922d5b4-4afb-e8b9-7b31-11a818c0b751@yandex.ru> References: <87sfj8umwb.fsf@posteo.net> <87edur3lil.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <87v8o0uxn5.fsf@gmail.com> <787a4362-7ff5-7dbb-9118-16e4bee5f328@yandex.ru> <87edunvhf2.fsf@gmail.com> <6d4d9e72-1bae-4d64-b7c1-c2b9c11e396f@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: philipk@posteo.net, Eli Zaretskii , manuel.uberti@inventati.org, 58839@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 04 02:29:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqlWF-0006BD-Cm for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Nov 2022 02:29:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqlVp-0000n8-WA; Thu, 03 Nov 2022 21:28:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqlHW-0006WW-KH for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqlHW-0003Mq-Br for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqlHV-0005S7-Qv for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 21:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Nov 2022 01:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.166752439820896 (code B ref 58839); Fri, 04 Nov 2022 01:14:01 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 4 Nov 2022 01:13:18 +0000 Original-Received: from localhost ([127.0.0.1]:51055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqlGo-0005Qy-2n for submit@debbugs.gnu.org; Thu, 03 Nov 2022 21:13:18 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:34609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqlGl-0005Qh-UB for 58839@debbugs.gnu.org; Thu, 03 Nov 2022 21:13:17 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id k8so5130198wrh.1 for <58839@debbugs.gnu.org>; Thu, 03 Nov 2022 18:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ZEppwYF455OSCQA5rYM0nS02Nn+JiRs1M5r0mRuBOvo=; b=RTuIxQIaTDENLz6dLbXBt+3AGOusKrkkHNmtDNEJg//xcSbVnO8PsU/MxyvHnujI4D 9DuMW/tFLHRd7WW5gm8AB3G5G67QdBTULwbw/3XaYCE3wT1HYEDzm3fjZfejpjThAxrP GNZlqwpHr7CfKIZ2GII8Jv5HwWCx4DiomJ/eFHjF2CYBt1o29DJHVXRmwNumAcMtRR2r 55o7U83o7oJVjLMLn+hEdIQi5E5a2rvD8YM0l+glf6dD32oBR06GIwoTKeolE3hdy+Sh 7HJJpab/muaGy52JPiqQrrB9tpVviH70Idt5B+v7GFPhXlgd1LstHfg/krIlKnrvy4Nn hMbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZEppwYF455OSCQA5rYM0nS02Nn+JiRs1M5r0mRuBOvo=; b=Sk+4kjY4ZiSov6Cz0X0PHdYDbe4VypgmStJaEqZ0zU2R18OZXP4Wknm7NCRDCd00KM GJ2xZZHTsw6GdGGjYJS/qwZLzmStMYVqLi5vnuIgx9myZrnekdxToi0mOhqcFQjcIi43 i28hxaVPrR0bulScFcb3ro9uUWFrOngL4M9cBGBjcQ+nAUHEJ+kKcekf8Nk8/+npDic4 7IajxCh+UFAst+kr81cVHqOaukzr4JmoqB45jIEiWshZWgt5OE7b33ZKmn/IC3TJtecK 9ILU/QcXzMmdGLcqC/2wefeQw+jfwFH6gOy1lZ2T8goqF0qpGgZe35gdjxahMfZjVHFz iOpg== X-Gm-Message-State: ACrzQf1qmo50Fy0n+39vxfBAgbm25cn4SIFnx0/azkFRP6MSUPKhUrdD rVdJqTIBGhKVJV8Eh9wtmog= X-Google-Smtp-Source: AMsMyM59xIWy7PCi7tm+hUkrQEoy0fFdz4vxC4gdJu6NTswGqHnf5Nl09oFGiO6H9gwVHQcG3hABOA== X-Received: by 2002:a5d:554e:0:b0:236:ccf1:f958 with SMTP id g14-20020a5d554e000000b00236ccf1f958mr16374894wrw.378.1667524389794; Thu, 03 Nov 2022 18:13:09 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bu14-20020a056000078e00b0022cdb687bf9sm2967834wrb.0.2022.11.03.18.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 18:13:09 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247031 Archived-At: On 01.11.2022 13:36, João Távora wrote: > On Mon, Oct 31, 2022 at 10:51 PM Dmitry Gutov > wrote: > > > I suggest you try it first. > > It works in my test > > > Disaster, really? > > The reason I came about the Gnus problem was when using it > to reply to some emails here and trying out the C-x p k and finding out > all my Gnus buffers were gone. I have now pushed the proposed fix, as well as an additional change to except Gnus modes (not sure it will be enough -- there might be background buffers using some modes that don't derive -- but it seems to help in my brief testing). That's not to mark a final decision, but to fix the immediate issues, and to remember them in the code. The question now is how to better handle packages and features that are similar to Gnus in that regard. One alternative option would be to add a var through which such modes could opt-out (rather than opt-in). It seems more likely that we won't have to update project-kill-buffer-conditions often then. A whitelisting approach seems cleaner/safer, though.