From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66288: 29.1; Performance regression using pipe for subprocess Date: Thu, 5 Oct 2023 13:48:55 +0300 Message-ID: <391fb6f4-163e-45fb-e2f9-311382e0ad93@gutov.dev> References: <83ttra91nu.fsf@gnu.org> <63df0312-f2e0-49cd-8536-f886d841e88e@chris-hanson.org> <83edid8vmx.fsf@gnu.org> <83bkdh8u2k.fsf@gnu.org> <6d2e1bab-89e0-57cf-598c-96f0e4179428@gutov.dev> <786d8b73-dc9f-42ec-b5ed-4cae99ed5567@chris-hanson.org> <83h6n86x8r.fsf@gnu.org> <278d63e7-c624-4759-2c25-283e2ee60c9a@gutov.dev> <831qeb7fna.fsf@gnu.org> <091483da-26d5-f395-9d66-692d706ac3c6@gutov.dev> <83sf6q6fqz.fsf@gnu.org> <4406fc68-d033-1f88-c244-3c5d138b33ad@cs.ucla.edu> <8be747c8-42e5-f978-d331-b8c36c6d0349@gutov.dev> <83r0m94nzl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: gerd.moellmann@gmail.com, 66288@debbugs.gnu.org, gregory@heytings.org, eggert@cs.ucla.edu, cph@chris-hanson.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 05 12:50:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qoLwM-000AAW-Qq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Oct 2023 12:50:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoLvT-0002y1-Kk; Thu, 05 Oct 2023 06:49:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoLvM-0002ua-Fp for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 06:49:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoLvM-0002yy-80 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 06:49:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoLve-0002VD-4X for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2023 06:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2023 10:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66288 X-GNU-PR-Package: emacs Original-Received: via spool by 66288-submit@debbugs.gnu.org id=B66288.16965029649569 (code B ref 66288); Thu, 05 Oct 2023 10:50:02 +0000 Original-Received: (at 66288) by debbugs.gnu.org; 5 Oct 2023 10:49:24 +0000 Original-Received: from localhost ([127.0.0.1]:46113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoLv2-0002UH-Gc for submit@debbugs.gnu.org; Thu, 05 Oct 2023 06:49:24 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoLv0-0002U3-UA for 66288@debbugs.gnu.org; Thu, 05 Oct 2023 06:49:23 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2A1E45C04D7; Thu, 5 Oct 2023 06:48:59 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 05 Oct 2023 06:48:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1696502939; x=1696589339; bh=zMeQLDYxiDbhlMrE+D0kLKiGqgrJyya9SqL ++tmw3Y0=; b=4Ki3Li5L962ElCwGa9Gy7nr7XE5ALVclPX9KlIuPBbnySDV3iWE tjyGDuZIUNi0hidxL+DSfY/55cHu+o18srqAWrMsKoK3mVENXysuab2bwLqEocIZ HwDmZangL8QClxWvpG2cAseCEqFJ8Ed3BnLTOGd2MzANb9udzPyBBaS14n0dI83i Lb8GHab+Gzg/npLsKVE0xG9gvVq6jqWPlqPmNwrbmidNhTKQqHQjo/REiCa2I5UU 2lXUmU9OIUwhC0KOFCP9+DPwh1cITq0QbN57KdoLpcrtlwPYyXsdM2f9CYkCiQ5k lqhKpM/jcN1ls54fFa17n2dpia+Mx7SXmsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696502939; x=1696589339; bh=zMeQLDYxiDbhlMrE+D0kLKiGqgrJyya9SqL ++tmw3Y0=; b=ahwFLonvsSRn+mcIbK3ul9U3CcAc/OtFEwTOkSgvs2I5xFJLOpl kYJIVWyqDx9mFJrbSLOK50Ln1irPw92oVFrKW8LIE5NiKtN81o/uGF0nmIVl411s +fFi2dVhF7g2/5Cr9KXFRq2CR2IjqWkZV8XTWcBQzxLYk8YbX4h9ex+DcpORDmDI NUqa0w0/7C7JRjSegr87MSG8hjYDe2VY9jK52urWqeRfyX5T804Gf+enCpU30nnv ccNbbLWF9eMXIzRtErh3GSZ5SQwdK3VvkwqJKJUX1nHKlVZAlGpoUmjMR5rZF8QC eV1gPr/HEnV5c7BpVkDwbGOgYnvPxThAAgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrgeeggdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffgfeej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Oct 2023 06:48:57 -0400 (EDT) Content-Language: en-US In-Reply-To: <83r0m94nzl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271864 Archived-At: On 05/10/2023 08:50, Eli Zaretskii wrote: >> Date: Thu, 5 Oct 2023 01:54:43 +0300 >> Cc:gregory@heytings.org,gerd.moellmann@gmail.com,66288@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 05/10/2023 01:49, Paul Eggert wrote: >>>> +      fcntl (inchannel, F_SETPIPE_SZ, readmax); >>> This call can fail if you aren't root and you exceed the system limit in >>> /proc/sys/fs/pipe-max-size. So I suggest that if this fnctl fails with >>> EPERM, trying it again after clipping to that limit. >> Perhaps we'd rather fail loudly, so the user is aware that their >> customized value cannot be applied. > Why not silently? The clip_to_bounds call can already silently change > the original request anyway. clip_to_bounds clips to 4294967296 or higher, if I'm not mistaken. And my current system-wide limit is 1048576. I usually like to know when my applied configuration is not used (or use-able). Anyway, it's not a hard requirement (not for emacs-29 anyway).