From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Sun, 6 Dec 2020 08:54:23 -0800 (PST) Message-ID: <38bb45b7-5979-433c-a5a1-e4153770d34a@default> References: <83h7pcqjxy.fsf@gnu.org> <87pn3zjivc.fsf@gnus.org> <831rgfotpg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34553"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44858@debbugs.gnu.org, larsi@gnus.org To: Stefan Kangas , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 17:59:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klxNf-0008tf-KC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 17:59:27 +0100 Original-Received: from localhost ([::1]:53916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klxNe-0006Zm-If for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 11:59:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klxLK-0005Ss-ML for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 11:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klxLK-0002aG-F8 for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klxLK-00074a-Di for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160727379527148 (code B ref 44858); Sun, 06 Dec 2020 16:57:02 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 6 Dec 2020 16:56:35 +0000 Original-Received: from localhost ([127.0.0.1]:51076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klxKs-00073o-Me for submit@debbugs.gnu.org; Sun, 06 Dec 2020 11:56:34 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:33820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klxKq-00073X-QM for 44858@debbugs.gnu.org; Sun, 06 Dec 2020 11:56:33 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B6Gu1uH081281; Sun, 6 Dec 2020 16:56:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=BsX7u2QAAHhYhvtCMi30GiGyy+VQD1UVg+JgUacdL3A=; b=AOB8Qo2hm00yV9azcpgJHoBNXnUoykVLxOIbkA5aFUtt4oVHlgykt4be4o+YwK4VSQ/V 8gnqWmSqvbDRUKS21gKTPIdHXHTM+KR1dibIIzt5f6TPh56NMw2CMf4Q67AMZtqHzC5Q zI+P+XDalg86gRzsfs26cCzC0/ZI5KBTCK91czlm3BTk0hsKbRnudW/N+rtEBAeZxj+K oG8qPal79Ag2q27T+FMkLkvShRvmpkRd9vA7POuL4AWA15tplctJ10DFcyBuBbI29yLY BIgZBUHogy93T9/6+OSbfbP8wrmcAIomH3j3tu7nQOYDS+++QWooLAmtCfrIomWKxwNA Mg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 357yqbjnrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 06 Dec 2020 16:56:26 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B6GpZ6h118818; Sun, 6 Dec 2020 16:54:25 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 358m4uves2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 06 Dec 2020 16:54:25 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0B6GsONx013217; Sun, 6 Dec 2020 16:54:24 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9827 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012060107 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9827 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012060108 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195136 Archived-At: (FWIW, I'm not convinced this is very helpful.) But if you do add this, please consider letting the message provide the actual longest-line length. Someone concerned with fixing long doc-string lines might be more concerned with fixing one with, say, 179 chars than one with, say, 82. Presumably the actual longest-line length is available for the message. Why not show it? Or maybe not. If your code finds only the first line that's > 80 chars then it won't help as much. Doc strings are typically fairly short. Looking for the max line length isn't very expensive.