From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: michael_heerdegen@web.de, 11718@debbugs.gnu.org
Subject: bug#11718: 24.1.50; `all-completions' returns results with wrong case
Date: Sun, 24 Jun 2012 13:20:31 -0700 [thread overview]
Message-ID: <38E9C991E50C40F3AA6B1306119CC96B@us.oracle.com> (raw)
In-Reply-To: <jwvvcig7jpt.fsf-monnier+emacs@gnu.org>
> The problem here is that you misunderstand what is the COLLECTION
> argument in the case at hand. It is *not* a table that completes
> filenames as they exist in the file-system. If you want
> that, then use completion-file-name-table.
The case at hand is the one Michael presented. All that is done in that code is
to pass `minibuffer-completion-table' and `minibuffer-completion-predicate' to
`all-completions'. The former happens to be `read-file-name-internal' in this
case, but the code does not impose that (it comes from `read-file-name', which
the code uses).
> `read-file-name-internal' is a completion table that does
> other things to handle substitute-in-file-name rewrite (i.e.
> typically env-var expansion, $$-quoting, // and ~/ truncation);
A priori I do not have a problem with any of that. Au contraire, I think.
> part of that makes it that you should not put too much faith
> in the case of the returned string.
That's the part that I'm not sure follows. Logically.
But I repeat that I cannot speak to the implementation, and I do not claim that
it is easy to get it right. I am only saying that file-name completion - even
with env-var expansion etc. - _should_ not change the case of file names for the
return value. It is a bug if it it does, though not a major bug.
(Again, "should" does not imply that it is easy to fix.)
I'm not sure we disagree. And I hope you can fix this eventually, even if it is
not a high priority. And I understand from your posts that this might not be
easy, file names being mixed up with env-var substitution et tout le reste.
next prev parent reply other threads:[~2012-06-24 20:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 18:58 bug#11718: 24.1.50; `all-completions' returns results with wrong case Michael Heerdegen
2012-06-23 4:38 ` Stefan Monnier
2012-06-23 14:18 ` Drew Adams
2012-06-23 15:48 ` Stefan Monnier
2012-06-23 21:01 ` Drew Adams
2012-06-24 4:38 ` Stefan Monnier
2012-06-24 14:33 ` Drew Adams
2012-06-24 16:38 ` Stefan Monnier
2012-06-24 20:20 ` Drew Adams [this message]
2012-06-25 1:38 ` Stefan Monnier
2012-06-26 2:17 ` Michael Heerdegen
2012-06-26 13:06 ` Stefan Monnier
2012-06-23 19:51 ` Michael Heerdegen
2016-07-08 23:17 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38E9C991E50C40F3AA6B1306119CC96B@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=11718@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.