From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: "Boško Ivanišević" <bosko.ivanisevic@gmail.com>, 62416@debbugs.gnu.org
Subject: bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode
Date: Mon, 27 Mar 2023 20:28:32 +0300 [thread overview]
Message-ID: <385443e1-4d17-317b-decf-36a3cf50111e@yandex.ru> (raw)
In-Reply-To: <86v8imfrbt.fsf@mail.linkov.net>
On 27/03/2023 19:29, Juri Linkov wrote:
>>> But anyway I think in its current state
>>> treesit-sexp-type-regexp is underdesigned as noted in
>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62238#59
>>> so no tweaking could fix its design flaws. For example,
>>> foo = {
>>> a: b
>>> }
>>> when point is on the left curly bracket, 'C-M-f C-M-b' doesn't
>>> move back to the original position, etc.
>>
>> Hm, yeah, it's a little unexpected that not only it doesn't move back
>> exactly, it skips the full assignment expression in both directions.
>>
>> What is the downside of dropping "binary" and "assignment" from
>> treesit-sexp-type-regexp, added there not too long ago? Without
>> "assignment" there, your example becomes a round-trip.
>
> This will break other cases, e.g.
>
> b = %Q{This is a "string"}
> c = %w!foo
> bar
> baz!
> d = %(hello (nested) world)
>
> when point is after "b", 'C-M-f' will move to "c" instead of the end of line.
That is because the string literals aren't recognized as sexps yet. Try
this:
diff --git a/lisp/progmodes/ruby-ts-mode.el b/lisp/progmodes/ruby-ts-mode.el
index d1034d467ab..c46247c747a 100644
--- a/lisp/progmodes/ruby-ts-mode.el
+++ b/lisp/progmodes/ruby-ts-mode.el
@@ -1129,8 +1129,11 @@ ruby-ts-mode
"block"
"do_block"
"begin"
- "binary"
- "assignment")))
+ "integer"
+ "simple_symbol"
+ "string"
+ "string_array"
+ )))
;; AFAIK, Ruby can not nest methods
(setq-local treesit-defun-prefer-top-level nil)
next prev parent reply other threads:[~2023-03-27 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 10:24 bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode Boško Ivanišević
2023-03-24 18:41 ` Dmitry Gutov
2023-03-25 19:04 ` Juri Linkov
2023-03-26 2:14 ` Dmitry Gutov
2023-03-27 16:29 ` Juri Linkov
2023-03-27 17:28 ` Dmitry Gutov [this message]
2023-03-28 6:31 ` Juri Linkov
2023-03-28 22:24 ` Dmitry Gutov
2023-04-03 16:03 ` Juri Linkov
2023-04-03 20:41 ` Dmitry Gutov
2023-03-30 7:47 ` Yuan Fu
2023-03-30 9:32 ` Dmitry Gutov
2023-04-02 22:34 ` Yuan Fu
2023-04-02 22:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385443e1-4d17-317b-decf-36a3cf50111e@yandex.ru \
--to=dgutov@yandex.ru \
--cc=62416@debbugs.gnu.org \
--cc=bosko.ivanisevic@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.