From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Date: Tue, 12 Jul 2016 20:06:54 +0000 (UTC) Message-ID: <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> References: <87k2gr49lp.fsf@cochranmail.com> <87eg6yvfgm.fsf@cochranmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468354108 5769 80.91.229.3 (12 Jul 2016 20:08:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 20:08:28 +0000 (UTC) Cc: Philipp Stephani , 23957@debbugs.gnu.org To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 22:08:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bN3yZ-0006Rp-91 for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 22:08:15 +0200 Original-Received: from localhost ([::1]:43155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3yU-00069e-Vk for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 16:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3yP-00063m-AB for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 16:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN3yL-0006gJ-Vl for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 16:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3yL-0006gE-SW for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 16:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bN3yL-00074l-JN for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 16:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835402927131 (code B ref 23957); Tue, 12 Jul 2016 20:08:01 +0000 Original-Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 20:07:09 +0000 Original-Received: from localhost ([127.0.0.1]:48751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3xV-00073X-4V for submit@debbugs.gnu.org; Tue, 12 Jul 2016 16:07:09 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:35809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3xT-00073K-TC for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 16:07:08 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CK6xhA028100 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 20:06:59 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u6CK6xoL000516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 20:06:59 GMT Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u6CK6wbI029597; Tue, 12 Jul 2016 20:06:58 GMT In-Reply-To: <87eg6yvfgm.fsf@cochranmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120953 Archived-At: > I didn't put too much thought into reading the FIXME; Nor did I. ;-) > I figured that someone smarter than myself knew what they were > doing when requesting the change. Yes, no doubt s?he had a good reason. Or at least a reason. But apparently it was not recorded, so we can only wonder or guess. My guess is that the person just figured that, like `member', people can use `symbol-function' as a general Boolean - which is true. But `fboundp' has been around forever, and there is no telling what code might expect its value to be either `t' or `nil'. And if someone really wants to use `symbol-function' to either get the function or test whether there is one, s?he can already do that. > I'd personally argue that anyone making an explicit check for t, or > anything that particularly needs t rather than any true value is just > asking for lossage, but I can see why people would disagree with that > assertion. It doesn't matter what we might think of such a check. The point is that such checks might exist, and there is really no good reason (that I can see) for breaking such code. Again: anyone can already use `symbol-function' to get the desired effect, and its name speaks much better to the combined behavior desired in that case. > FWIW, In every placed I changed occurrences of fboundp to > symbol-function, both in Lisp and C, used only the truthiness > of the return rather than explicitly checking for t. That's irrelevant (IMO). The code that GNU distributes with Emacs is but a small part of the Emacs-Lisp code that is out there. > I also ran the test suite with and without my patch applied, > and noticed no difference in the number of failing tests. Again - you were testing in the tiny GNU Emacs distributed-code sandbox. The Emacs world is a much bigger box. > Anyways, I'm willing to toss this patch and do something else > if that is the general consensus. I can't speak for the consensus, but that would be my hope. And thanks for pitching in! Sorry to seem so critical of a first foray into helping.