From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29360: 26.0; Add full-buffer choice for `isearch-lazy-highlight' Date: Tue, 23 Oct 2018 15:51:14 -0700 (PDT) Message-ID: <3818ac4c-6564-4439-9fb5-c84791f43f7a@default> References: <7ec3c778-ee77-48c9-ba10-f21202cac955@default> <87shd8lli4.fsf@mail.linkov.net> <36f5e57c-2eb3-45eb-ae43-3f8fdf7586dd@default> <60f1b355-7455-4bb9-ae3d-294e1494a9d9@default> <87va5yhpaq.fsf@mail.linkov.net> <875zxwjlke.fsf@mail.linkov.net> <87woqbglvb.fsf@mail.linkov.net> <76121a16-e057-4aa7-9a5a-1f09cc221d7c@default> <87efcguxnm.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540335022 17073 195.159.176.226 (23 Oct 2018 22:50:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2018 22:50:22 +0000 (UTC) Cc: 29360@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 24 00:50:18 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF5VC-0004KH-6L for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Oct 2018 00:50:18 +0200 Original-Received: from localhost ([::1]:44582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF5XI-0001ut-R3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2018 18:52:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF5X3-0001tk-Nn for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2018 18:52:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gF5Wu-0005TF-MN for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2018 18:52:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34553) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gF5Ws-0005Lx-0c for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2018 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gF5Wr-0005PT-Vb for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2018 18:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2018 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29360-submit@debbugs.gnu.org id=B29360.154033508420752 (code B ref 29360); Tue, 23 Oct 2018 22:52:01 +0000 Original-Received: (at 29360) by debbugs.gnu.org; 23 Oct 2018 22:51:24 +0000 Original-Received: from localhost ([127.0.0.1]:38811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF5WF-0005Od-LZ for submit@debbugs.gnu.org; Tue, 23 Oct 2018 18:51:23 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:55018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gF5WE-0005OR-2U for 29360@debbugs.gnu.org; Tue, 23 Oct 2018 18:51:22 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9NMiMdX170082; Tue, 23 Oct 2018 22:51:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=yQHV2ltf/oVAuPA0a0daHVHblCsxScko7oLWhgP5cKQ=; b=cLPJkOQwESL6jE2u+O0rjNfzaqM3T5/gmd5kXv4XzZIJguHhrM9u7NZX09rFFI2LgkAd HsHSLzcsP3WBlRje4Uy6NJxHKQH06r3Q9UaY6jbeQWJD6soXJSzPnXT7LGqmVajAloP9 mu7/yC+FOcLYe5Lbc8/UfY1+zZhJe0Uk8eyQbC0Ic3lQYsyuwHAS+8BlVrP4NYccRUqy PKC0mtX1li8CK/W0xsTqwvdRX81nkU8denHZGNwRc4FaP9gjFTychy2UwT441L7fYWaG 9l/vfOrzfe2QFnK1v+IaEMkKV5BCtZ0UO+t7JfBWfmM/G927d1trx7w5guJ9d2fPlO50 qA== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2n7vaq08vh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Oct 2018 22:51:15 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9NMpFB6030731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Oct 2018 22:51:15 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9NMpEuK032150; Tue, 23 Oct 2018 22:51:14 GMT In-Reply-To: <87efcguxnm.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4756.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9055 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=697 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810230186 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151534 Archived-At: > Bad news: when I tried to type an isearch string on a large file > (about 1MB) after typing the first character 'e' lazy-highlighting > became unresponsive busy highlighting all 50000 matches in that file. >=20 > Do you think we should start lazy-highlighting for the full buffer > only when the length of the search string is more than 1 character? Absolutely. Like with any similar interaction in Emacs the delay before starting should be a user option. Users are different, and user machines etc. are different. Another possibility is for the option value to be a choice of either: * A non-negative number of seconds (or maybe natnump) * A cons (SIZE . DELAY), where SIZE is the buffer-size=20 threshold: no delay if the buffer is no larger than this, and DELAY seconds delay if greater than this. Another possibility, to accomplish the same thing (delay and threshold) is to have two different options: lazy-highlight-delay - just the delay lazy-highlight-threshold - just the size threshold The latter approach is what I use in Icicles, for several such settings, e.g. `icicle-incremental-completion-delay' and `icicle-incremental-completion-threshold' But maybe the former approach is simpler.