From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Sun, 17 Apr 2016 03:44:48 +0300 Message-ID: <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1460853926 32566 80.91.229.3 (17 Apr 2016 00:45:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Apr 2016 00:45:26 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 17 02:45:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arapt-0008D7-3o for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Apr 2016 02:45:13 +0200 Original-Received: from localhost ([::1]:36346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arapp-0006jy-Ag for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2016 20:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arapl-0006gR-F2 for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 20:45:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arapi-0001ug-6q for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 20:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arapi-0001uc-3g for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 20:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1araph-00032D-Q2 for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 20:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Apr 2016 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.146085389811643 (code B ref 20637); Sun, 17 Apr 2016 00:45:01 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 17 Apr 2016 00:44:58 +0000 Original-Received: from localhost ([127.0.0.1]:37688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arape-00031j-DV for submit@debbugs.gnu.org; Sat, 16 Apr 2016 20:44:58 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:36072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arapc-00031V-Gb for 20637@debbugs.gnu.org; Sat, 16 Apr 2016 20:44:56 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id l6so15180634wml.3 for <20637@debbugs.gnu.org>; Sat, 16 Apr 2016 17:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jY9OKzR2rnnH05rvwF2bi1eeflQEsB1gFPfoxUeNhPc=; b=J1C2J34cI+15H7sWJca8TyiHGOiwIvtoz98T4xscU/NAqX5mtjimAle2ZBp2cfcOqJ BtePmvkL3W0Fae0AgqIxHTRRuVGfxKWPI0fTNoHYCOy/4r5WjB4hbFmiuInxEFzw59Ld qCpj2EdRK6zJMu32Wa2pTUkqkIlSro64UyPqQihh98IRXSQncbX1vC2gDQ95IMFfO1MD OQJM+N2nS/ASqn7IcNR2fCRXdMepZZJMyeQOKgwoUqr2Kd3P/+KSdtuVK0vnVlE/zjY4 J9hCWy1CIWV3Vgm5Q1k4QdcmcQXb64YItnN2VXOgeioQm+DLEQKv1gmkvHE0Uapn2goJ A+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jY9OKzR2rnnH05rvwF2bi1eeflQEsB1gFPfoxUeNhPc=; b=g9Vc/qjjr3qydg3t1j7ndPsWMd7FDA4HHqy2JV33b9jGvSjKkkfwaTUSg/ku/uUSpH rP2/869AdbF7o77l4tM7zoJTKPIfQBShQT2fwrvRfXUEzGS+sb6KKz5TRFNwCSAD4EC1 0F7ZJGcuGtz174Q+GsUaR+3kI3yhnown+p0D7jr3/ju7czs0rz1kmUgjt+9a4waTlVDs 899Q/gRGXt2V6Mh8oGngM0oHOJ78Kp86FE0YXRvhKqW5hthrPELZ66NzXOPYSkyMW19s ssWygYH3WxWwePels6KSS144rE8tk6bAG+LHDd1BoTn3LPYDV924QuDjoBVoHurZbKDj nCVQ== X-Gm-Message-State: AOPr4FWo/lNXw+k8Bcs/jChR5TLEpWmsHB1NtJYEzcxaRkJdnGaWGkRldZdrWjmqp9+Wrg== X-Received: by 10.28.1.85 with SMTP id 82mr11686080wmb.58.1460853890933; Sat, 16 Apr 2016 17:44:50 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ux5sm56398706wjc.17.2016.04.16.17.44.49 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Apr 2016 17:44:50 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87bn5bc8zx.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116548 Archived-At: On 04/15/2016 04:11 PM, Michael Albinus wrote: > I would prefer to apply further patches to the master branch only. Only > patches absolutely necessary for fixing problems shall go to the > emacs-25 branch, in order not to threaten the release. I can do that. > After applying your patch, vc-tests.el fails for me in vc-test-src02-state How do you install src? Do you build it from source? > and vc-test-rcs03-working-revision. This one (failure in vc-checkout-model5) seems to be a real bug uncovered by using vc-file-clearprops. I suppose we should add a FIXME there and skip that check for RCS. >> - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) >> - (if (functionp symbol) >> - (funcall symbol file) >> - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. >> - (signal 'vc-not-supported (list 'unregister backend))))) >> + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal >> + ;; `vc-not-supported'. >> + (vc-call-backend backend 'unregister file) >> + (vc-file-clearprops file)) > > As said, in the master branch I would prefer to add a vc-unregister > function. Then we won't need this anymore. We'll need this code either way. Where the function resides and how it is called is less important to me.