From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Date: Wed, 21 Aug 2024 12:12:00 -0700 Message-ID: <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------IL7mBidZaXGDFK4qbYOa4imV" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 21 21:13:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgqm7-0007Lh-Ik for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Aug 2024 21:13:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgqll-0003TC-7F; Wed, 21 Aug 2024 15:13:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgqlj-0003T3-Mj for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:13:19 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgqli-00033x-TQ for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:13:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:References:From:MIME-Version:Date:To:Subject; bh=EURY2DxudcKpa96EcyWuIs0L/UuYdWAJcnxP8/a2shI=; b=W6H5trJLOEww/jfncGw5YazgYOT/RlW7Plif/EP8nEYI3rH00ZsWheLqMVSwrEHWijUZn0xSIu02vVKj04d+wFsZM3wMPhGl/a7OOclykSyhPrjxLS7QKDqEmLv+wigZ5LLGs1Zwe+2wvOjDB5pwfokRodx4sAz+sbvqRvaCvF6tYHquutwlvlCfjZc1udsJCGfAdiv6JUXSbWOXHccLxUrcRDENjj4PKp6yjFJHp43eS1vbozJhPYX6phgYzNdZor59PnFr6yZoUFFXFXliYvoTt6Uz/m0sx5mkANBC/alfZJL+EewIwsUz3b+ayn7quaJDvanm0M8/TwB73OnQGQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgqmQ-0005Gw-Ka for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2024 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2024 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72721 X-GNU-PR-Package: emacs Original-Received: via spool by 72721-submit@debbugs.gnu.org id=B72721.172426763520241 (code B ref 72721); Wed, 21 Aug 2024 19:14:02 +0000 Original-Received: (at 72721) by debbugs.gnu.org; 21 Aug 2024 19:13:55 +0000 Original-Received: from localhost ([127.0.0.1]:36384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgqmJ-0005GO-CU for submit@debbugs.gnu.org; Wed, 21 Aug 2024 15:13:55 -0400 Original-Received: from mail-pg1-f172.google.com ([209.85.215.172]:60844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgqmG-0005G6-Np for 72721@debbugs.gnu.org; Wed, 21 Aug 2024 15:13:53 -0400 Original-Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7c691c8f8dcso35656a12.1 for <72721@debbugs.gnu.org>; Wed, 21 Aug 2024 12:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724267522; x=1724872322; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=EURY2DxudcKpa96EcyWuIs0L/UuYdWAJcnxP8/a2shI=; b=hWxpm+GGwZy5f8oCgdwjIf3tQzlIsxAMv4NRed3kjwNP73qJk87EinV2NKDKXFPkda qeZ0s+27FZXHfwsztmuuZOtP3WZiVtdjUv6t+FMd3QsNyWFBIrKDyQIpdz4VGQKgu70f AaarvHIh7d1GaSEHCdKta5s+rEW0mLIdQSYC5N1fOOmU+abwcCbaDCtAqlq+Z8Pf27iY l7zxaRBl/eeb7hY5zhvCELSHa8MNuisIOgf4cmUePS/o4XVHOBLUBgQg2/WABaIBGDnb zUxCvBPtQamWVOM3Vvy7j7GNBxs0zd8ggRo1/gHO9HGM3DraHuifUMmIcCT9rAKDUJAR 9J0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724267522; x=1724872322; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EURY2DxudcKpa96EcyWuIs0L/UuYdWAJcnxP8/a2shI=; b=jnE/SWPY04BJrcWxrE7BTZk5d/3lyuGq9McwpnrBg9orOxATjluVL7cxqpAvaOQqAH XkzXqAsu1zoidj6L6HT9KC2ST1wdoSz0Sd4FScPBUKcULMRGsTfrD0Ph92GEE75tExel /iC7KszN1IryK5pbmmbOebVqU6tVuhi5Kss7aLGT2Nv+HBVRjM+eek/8hc3RjNhMhDBm aPHvIoH4rFEG+waf9XTkUmIilYjmBlnWCR4IVgRWCWRHyadquP6Ayp6iFasIpps+1QPf sBgs/N/VjDwJ+0za01IMUsav/Fc1WvansP5a72mQ7lLq7WeScI+y3lWxo32D+0xQpZfz gg5A== X-Gm-Message-State: AOJu0Yy+cZUj28FDkmu1SXxoyV7VgKtYhuNykVYD2hIafiUbsG6GniaZ dBWT+i7GgMgeqfHtDBlBLUEftGIdIVtA87uPBLL0BPjlAxs7bmEK X-Google-Smtp-Source: AGHT+IHPfxWLCDB1N/ZMzO0nZru+dWQbi14Xg7jvnvEekzIG9u7fl1rPvLo65x+QT85/e471758yvg== X-Received: by 2002:a17:90a:640b:b0:2c9:8105:483 with SMTP id 98e67ed59e1d1-2d5e9a3fb15mr3588628a91.14.1724267521694; Wed, 21 Aug 2024 12:12:01 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2d5eb9034d6sm2267056a91.14.2024.08.21.12.12.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 12:12:01 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290500 Archived-At: This is a multi-part message in MIME format. --------------IL7mBidZaXGDFK4qbYOa4imV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/2024 10:18 PM, Jim Porter wrote: > On 8/20/2024 8:15 PM, Jim Porter wrote: >> Hopefully the attached reproducers help make sense of this. I've also >> updated my patch to handle 'min-width' in what I think is a simpler >> way. This implementation relies on the fact that you can't nest >> 'min-width' specs (the iterator struct can only hold one spec at a >> time). I'm guessing on some of these parts, so I may be totally >> off-base, but the test cases do what I expect anyway... > > Whoops, I'd uploaded the wrong patch. Here's the correct one. ... and here's a new test case (overlay-min-width). This shows that now you can apply 'min-width' as an overlay property, which would be great for 'visual-wrap-prefix-mode'. I could then convert that code to use overlays (at least for 'min-width', maybe for 'wrap-prefix' too), which would make it easier to clean up when deactivating the mode. Of course, if there's a way to write regression tests for this, I'm happy to do so, but I've never looked into how (or if) one can write regression tests for display engine features. --------------IL7mBidZaXGDFK4qbYOa4imV Content-Type: text/plain; charset=UTF-8; name="test-cases.el" Content-Disposition: attachment; filename="test-cases.el" Content-Transfer-Encoding: base64 KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IDY3OCAgICAg OTAKICAoc3dpdGNoLXRvLWJ1ZmZlciAic2ltcGxlIikKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVy dHkKICAgNyAxMCAnZGlzcGxheSAnKChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7 IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NyAgODkgIDAKICAoc3dpdGNo LXRvLWJ1ZmZlciAiY29uc2VjdXRpdmUiKQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAi MTIzNDVcbjY3ODkwIikKICAocmVkaXNwbGF5KQogIChwdXQtdGV4dC1wcm9wZXJ0eQogICA3 IDkgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKQogIChwdXQtdGV4dC1wcm9wZXJ0eQog ICA5IDExICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNCkpKSkpCgoKKHByb2duCiAgOzsgU2hv dWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IGhpICA4OTAKICAoc3dpdGNoLXRvLWJ1 ZmZlciAibmVzdGVkIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5 MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyA5ICdkaXNwbGF5 CiAgIChwcm9wZXJ0aXplICJoaSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKSkpCgoK KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NSAgICAgICAgIHwKICA7 OyA2NzggICAgIDkwICAgIHxYCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkiKQogIChl cmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikKICAoc2V0LXdpbmRvdy1t YXJnaW5zIChzZWxlY3RlZC13aW5kb3cpIDAgMSkKICAocmVkaXNwbGF5KQogIChzZXRxIG8g KG1ha2Utb3ZlcmxheSA4IDkpKQogIChvdmVybGF5LXB1dCBvICdiZWZvcmUtc3RyaW5nCiAg ICAgICAgICAgICAgIChwcm9wZXJ0aXplICJvIiAnZGlzcGxheSAnKChtYXJnaW4gcmlnaHQt bWFyZ2luKSAiWCIpKSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyAxMCAnZGlzcGxheSAn KChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAg OzsgMTIzNDUKICA7OyA2NzggICAgIDkwCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkt bWluLXdpZHRoIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5MCIp CiAgKHNldC13aW5kb3ctbWFyZ2lucyAoc2VsZWN0ZWQtd2luZG93KSAwIDEpCiAgKHJlZGlz cGxheSkKICAoc2V0cSBvIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8g J2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKSkK --------------IL7mBidZaXGDFK4qbYOa4imV--