From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: visual-line-mode Date: Wed, 9 Jul 2008 10:28:03 -0400 Message-ID: <375C0006-2B47-4B1F-9EB2-ED47941C2DB3@gmail.com> References: <87zlp4raab.fsf@catnip.gol.com> <87d4lzehq2.fsf@stupidchicken.com> <87skuqbwr8.fsf@stupidchicken.com> <85E9BC5B-7337-4CD4-A783-6B2FAEBAEBCA@gmail.com> <87tzf6c5il.fsf@stupidchicken.com> <87abgxx0ju.fsf@stupidchicken.com> <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> <87prpsjhre.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: multipart/signed; boundary=Apple-Mail-4--1064200804; micalg=sha1; protocol="application/pkcs7-signature" X-Trace: ger.gmane.org 1215623292 7434 80.91.229.12 (9 Jul 2008 17:08:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2008 17:08:12 +0000 (UTC) Cc: Emacs-Devel devel , "Lennart Borgman \(gmail\)" , Stefan Monnier , Miles Bader To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 09 19:08:58 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KGd9i-0007Il-D5 for ged-emacs-devel@m.gmane.org; Wed, 09 Jul 2008 19:08:38 +0200 Original-Received: from localhost ([127.0.0.1]:56931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGd8q-0006nl-T7 for ged-emacs-devel@m.gmane.org; Wed, 09 Jul 2008 13:07:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KGd6m-0004xq-6b for emacs-devel@gnu.org; Wed, 09 Jul 2008 13:05:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KGd6l-0004wM-3R for emacs-devel@gnu.org; Wed, 09 Jul 2008 13:05:35 -0400 Original-Received: from [199.232.76.173] (port=38806 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGd6k-0004va-OI for emacs-devel@gnu.org; Wed, 09 Jul 2008 13:05:34 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:47497) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KGbN8-0004jr-Ri for emacs-devel@gnu.org; Wed, 09 Jul 2008 11:14:23 -0400 Original-Received: from wx-out-0506.google.com ([66.249.82.232]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KGafW-0000s9-7N for emacs-devel@gnu.org; Wed, 09 Jul 2008 10:29:18 -0400 Original-Received: by wx-out-0506.google.com with SMTP id h28so1444304wxd.24 for ; Wed, 09 Jul 2008 07:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=N507ss0gGwOGwCUzMNs8NnChZ6SEsAe1ICBVWgEE+sE=; b=fdaQaKGLPh5uP4wtBPgggBT+uGJNZJrnyHXCUtKWZiMoK/40gQYA8+/Gwr/4lqxPPG T6n5935Tp+VEVR2hTWZ6fLVbzDCHuj9KKD7r9DiAiPz51e97UNntJ7WU2LmBU4Z1Y2xX 0AUgE8VaPj29DY/Bi8JdMn2UDm2qZAiaXZJ5U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=YTya+EMqrsrWz2y+g6xwuM86dBw2RexhV7vAjPorWtHCsVuWEECazdTIA53D/A1oHc DDUceC8bmD+f/uPUIL5Oem1KlLhDAJwnyoMhVZiXB5TTyNnekujZayCtfZKSwwt757Yl R9UxR8e2P67MQkoqNQ5XpDWQGDWWB+kGT5atg= Original-Received: by 10.100.123.4 with SMTP id v4mr6357838anc.107.1215613755680; Wed, 09 Jul 2008 07:29:15 -0700 (PDT) Original-Received: from ?128.237.227.125? ( [128.237.227.125]) by mx.google.com with ESMTPS id d25sm6735035and.15.2008.07.09.07.28.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 09 Jul 2008 07:29:10 -0700 (PDT) In-Reply-To: <87prpsjhre.fsf@stupidchicken.com> X-Mailer: Apple Mail (2.926) X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100490 Archived-At: --Apple-Mail-4--1064200804 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On 5 Jul 2008, at 19:41, Chong Yidong wrote: > > Good, I've checked it in (together with a couple other minor fixes). Can you post a patch for these minor fixes? I'm running this on 22 (because the trunk does not run on my system). At least in the previous version, there's also a problem with posn-x- y, which returns a position too far when given coordinates that are to the right of a word-wrapped line (i.e. in the blank space). This can also be seen if you just click into that space (mouse-set-point). I can post a detailed recipe after I've made sure I've got the up-to- date patch. My new code isn't iterative. It's faster and shouldn't lead to excessive garbage collections as before. > One thing that's not clear to me is whether your minor mode correctly > handles invisible/intangible text and point motion hooks. One of the > reasons line-move-1 and line-move-finish is so complicated is, > unfortunately, the need to DTRT for these. I don't see anything > analogous in your code; am I missing something? OK, I'll bind `inhibit-point-motion-hooks' except for the last movement command. Regarding invisible text, the original code went a long way to handle this efficiently. With the new method (I'll post some code soon), this is handled elegantly and without any hassle thanks to posn-x-y. Regarding intangible text, this works fine with my working version. I'm not sure about "fields", perhaps because I don't know much about their implementation. Can you point me to a test case? Customize buffers perhaps? Thanks for pointing out these issues. --Apple-Mail-4--1064200804 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICEEfSZyInpN9bVdFPsdICbiIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIwOTIzMDM0OFoXDTA4MTIwODIzMDM0 OFowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDIS4kZGULD+CxprkxDnEccAnZ2GQQxfn55aiAPoy5kJ+uLhelaZP4p lgx3Vq8xYK1bjsLepGYp8qzVlHsyQPb6OfvRzrUXHxlJrHME0+Lblx37PBLxGDxc5W8qfZFJpej8 Dk3LUMga8laR9CRghbALoTV3UThUSMqk1cVwTY99KQIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAKU8XIS6 R/R3Hg6ae5p0i4iUJURq+sDVMX9RGB3Ge5V8oKKglIQGaY03leem65pqICL6mdgX/Px21JoaKVAA 8XITLFVEFHL6BfZ/eePnzNi93rnaNe7hLUwLdGztdYmqN8zF0DOCybL1M1JDB3cTr0XwHJwxziSf oEeENGNETykjMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBH0mciJ6TfW1XR T7HSAm4iMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA4MDcwOTE0MjgwNFowIwYJKoZIhvcNAQkEMRYEFJpJvgCe0c659Uh1Et8J0U5cuXyx MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQR9JnIiek31tV0U+x0gJuIjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQR9JnIiek31tV0U+x0gJuIjANBgkqhkiG9w0B AQEFAASBgC996i7Jy4X8XDwy+Dq9h3cgBLDenQKPDHJI+OZ1gRxPtQ7x4i/FofB/fXGZ8YBUlZD2 XRbq4/+UkmUhzGmgVJQJzxV4KzpG+vAhhZYoJtzs+4utKmdkRD0YVRq1YmcK/GVDwekRW/pYKLs3 uDLLiU4O4du50GxShnjkYK2MS4J8AAAAAAAA --Apple-Mail-4--1064200804--