all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Xemacs: org-preview-latex-fragment, png not readable.
@ 2012-01-28 20:20 Uwe Brauer
  2012-01-28 20:59 ` Solved (was: Xemacs: org-preview-latex-fragment, png not readable.) Uwe Brauer
  0 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2012-01-28 20:20 UTC (permalink / raw
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]

Hello

I made some progress in getting the function to work in
Xemacs.


The main problem seemed to be the function 
org-dvipng-color which is called in
org-create-formula-image.

The original formulation was 

(defun org-dvipng-color (attr)
  "Return an rgb color specification for dvipng."
  (apply 'format "rgb %s %s %s"
	 (mapcar 'org-normalize-color
		 (color-values (face-attribute 'default attr
		 nil)))))



Which does not work for Xemacs. Thanks to Julian Bradfield,
the solution seems to be:

(defun org-dvipng-color (attr)
  "Return an rgb color specification for dvipng."
  (apply 'format "rgb %s %s %s"
	 (mapcar 'org-normalize-color
 (color-rgb-components
     (face-property 'default (intern (substring (symbol-name attr) 1)))))))


However the png which were generated where to small to be
readable. I attach one at the end of the message.

So I tried out in GNU Emacs 21.3 to comment out
org-dvipng-color in org-create-formula-image.
org-preview-latex-fragment then still works, so  is not
necessary for generating the pngs.

So I tried to do the same in Xemacs but the formulas in the
png files keep being  too small.

What could be the reason for this behavior?

Uwe Brauer 

The following attachment should be an integral. 

Xemacs:

[-- Attachment #2: test3_7801a85c58c7aabc4553724e826b458ba08dda90.png --]
[-- Type: image/png, Size: 96 bytes --]

[-- Attachment #3: Type: text/plain, Size: 12 bytes --]


Gnu Emacs 

[-- Attachment #4: test_7ceb32811fbcd1322f595ca60dcc47456c20b5fe.png --]
[-- Type: image/png, Size: 268 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Solved (was: Xemacs: org-preview-latex-fragment, png not readable.)
  2012-01-28 20:20 Xemacs: org-preview-latex-fragment, png not readable Uwe Brauer
@ 2012-01-28 20:59 ` Uwe Brauer
  2012-01-28 22:33   ` Solved Bastien
  0 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2012-01-28 20:59 UTC (permalink / raw
  To: emacs-orgmode; +Cc: XEmacs Beta Discussion

>> On Sat, 28 Jan 2012 21:20:48 +0100, Uwe Brauer <oub@mat.ucm.es> wrote:



   > Which does not work for Xemacs. Thanks to Julian Bradfield,
   > the solution seems to be:

   > (defun org-dvipng-color (attr)
   >   "Return an rgb color specification for dvipng."
   >   (apply 'format "rgb %s %s %s"
   > 	 (mapcar 'org-normalize-color
   >  (color-rgb-components
   >      (face-property 'default (intern (substring (symbol-name attr) 1)))))))


   > However the png which were generated where to small to be
   > readable. I attach one at the end of the message.

The issue are the options 
in 


call-process "dvipng" nil nil nil

After trying out different configurations, I found out that
the option 
"-D" dpi

Does not work well with Xemacs.


So 
	  (call-process "dvipng" nil nil nil
			"-fg" fg "-bg" bg
;;			"-D" dpi
;;			"-x" scale "-y" scale
			"-T" "tight"
			"-o" pngfile
			dvifile)
is ok, however the back and foreground setting as generated
by org-dvipng-color, even with Julian Bradfield's patch do
not produce very nice results. In my Xemacs setting it is better to
comment them out.

So there are two small changes necessary to make 
org-preview-latex-fragment work in Xemacs. One is the above
change, the other 


(font-height (face-font 'default))
      instead of 
(font-height (get-face-font 'default))

I can send a patch against 7.8.03

Uwe Brauer 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Solved
  2012-01-28 20:59 ` Solved (was: Xemacs: org-preview-latex-fragment, png not readable.) Uwe Brauer
@ 2012-01-28 22:33   ` Bastien
  2012-01-29  0:13     ` Solved Nick Dokos
  2012-01-31 18:09     ` patch " Uwe Brauer
  0 siblings, 2 replies; 22+ messages in thread
From: Bastien @ 2012-01-28 22:33 UTC (permalink / raw
  To: Uwe Brauer; +Cc: emacs-orgmode, XEmacs Beta Discussion

Hi Uwe,

Uwe Brauer <oub@mat.ucm.es> writes:

> So there are two small changes necessary to make 
> org-preview-latex-fragment work in Xemacs. One is the above
> change, the other 
>
>
> (font-height (face-font 'default))
>       instead of 
> (font-height (get-face-font 'default))
>
> I can send a patch against 7.8.03

Please do so -- but please make sure the patch adapts current code
to XEmacs without suppressing any feature for GNU Emacs.

Thanks in advance!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: Solved
  2012-01-28 22:33   ` Solved Bastien
@ 2012-01-29  0:13     ` Nick Dokos
  2012-01-29 14:57       ` change call-process also for GNU emacs? (was: Solved) Uwe Brauer
  2012-01-31 18:09     ` patch " Uwe Brauer
  1 sibling, 1 reply; 22+ messages in thread
From: Nick Dokos @ 2012-01-29  0:13 UTC (permalink / raw
  To: Bastien; +Cc: Uwe Brauer, nicholas.dokos, emacs-orgmode, XEmacs Beta Discussion

Bastien <bzg@altern.org> wrote:

> Hi Uwe,
> 
> Uwe Brauer <oub@mat.ucm.es> writes:
> 
> > So there are two small changes necessary to make 
> > org-preview-latex-fragment work in Xemacs. One is the above
> > change, the other 
> >
> >
> > (font-height (face-font 'default))
> >       instead of 
> > (font-height (get-face-font 'default))
> >
> > I can send a patch against 7.8.03
> 
> Please do so -- but please make sure the patch adapts current code
> to XEmacs without suppressing any feature for GNU Emacs.
> 
> Thanks in advance!
> 

... and bonus points if you also fix the problems described in

    http://thread.gmane.org/gmane.emacs.orgmode/50584

:-)

Nick

^ permalink raw reply	[flat|nested] 22+ messages in thread

* change call-process also for GNU emacs? (was: Solved)
  2012-01-29  0:13     ` Solved Nick Dokos
@ 2012-01-29 14:57       ` Uwe Brauer
  2012-01-29 17:42         ` Nick Dokos
  0 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2012-01-29 14:57 UTC (permalink / raw
  To: emacs-orgmode; +Cc: xemacs-beta

>> On Sat, 28 Jan 2012 19:13:57 -0500, Nick Dokos
>> <nicholas.dokos@hp.com> wrote: 

   >> 

   > ... and bonus points if you also fix the problems described in

Now I am confused, from the link, you provided, I conclude
you are talking about GNU Emacs, however I only wanted my changes to
work with Xemacs and therefore wrap a

(if (featurep 'xemacs)

Around my changes. If you want to have the changes I have in
mind for call-process also for GNU Emacs, I think the
maintainers should have a say.

Uwe Brauer 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: change call-process also for GNU emacs? (was: Solved)
  2012-01-29 14:57       ` change call-process also for GNU emacs? (was: Solved) Uwe Brauer
@ 2012-01-29 17:42         ` Nick Dokos
  0 siblings, 0 replies; 22+ messages in thread
From: Nick Dokos @ 2012-01-29 17:42 UTC (permalink / raw
  To: Uwe Brauer; +Cc: nicholas.dokos, emacs-orgmode, xemacs-beta

Uwe Brauer <oub@mat.ucm.es> wrote:

> >> On Sat, 28 Jan 2012 19:13:57 -0500, Nick Dokos
> >> <nicholas.dokos@hp.com> wrote: 
> 
>    >> 
> 
>    > ... and bonus points if you also fix the problems described in
> 
> Now I am confused, from the link, you provided, I conclude
> you are talking about GNU Emacs, however I only wanted my changes to
> work with Xemacs and therefore wrap a
> 
> (if (featurep 'xemacs)
> 
> Around my changes. If you want to have the changes I have in
> mind for call-process also for GNU Emacs, I think the
> maintainers should have a say.
> 

Actually, it might very well be that they are Xemacs problems as well,
but you are right: I meant that since you'd be visiting the area, I
might convince you to do some additional work and fix those bugs as
well.

Nick

^ permalink raw reply	[flat|nested] 22+ messages in thread

* patch (was:  Solved)
  2012-01-28 22:33   ` Solved Bastien
  2012-01-29  0:13     ` Solved Nick Dokos
@ 2012-01-31 18:09     ` Uwe Brauer
  2012-03-16 17:57       ` patch Bastien
  1 sibling, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2012-01-31 18:09 UTC (permalink / raw
  To: Bastien; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

>> On Sat, 28 Jan 2012 23:33:24 +0100, Bastien <bzg@altern.org> wrote:
Hi Bastien,

Here comes the patch (I tested it with Xemacs 21.5 and GNU
emacs 23.1); I used the 
diff -u option and hope this is ok.

Uwe 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.patch --]
[-- Type: text/x-diff, Size: 3037 bytes --]

--- org-old.el	2012-01-31 18:37:53.000000000 +0100
+++ org.el	2012-01-31 19:01:19.667099891 +0100
@@ -1,4 +1,4 @@
-;;; org-old.el --- Outline-based notes management and organizer
+;;; org.el --- Outline-based notes management and organizer
 ;; Carstens outline-mode for keeping track of everything.
 ;; Copyright (C) 2004-2011 Free Software Foundation, Inc.
 ;;
@@ -16966,7 +16966,7 @@
 	 (dvifile (concat texfilebase ".dvi"))
 	 (pngfile (concat texfilebase ".png"))
 	 (fnh (if (featurep 'xemacs)
-                  (font-height (get-face-font 'default))
+                  (font-height (face-font 'default))
                 (face-attribute 'default :height nil)))
 	 (scale (or (plist-get options (if buffer :scale :html-scale)) 1.0))
 	 (dpi (number-to-string (* scale (floor (* 0.9 (if buffer fnh 140.))))))
@@ -16995,24 +16995,32 @@
     (if (not (file-exists-p dvifile))
 	(progn (message "Failed to create dvi file from %s" texfile) nil)
       (condition-case nil
-	  (call-process "dvipng" nil nil nil
-			"-fg" fg "-bg" bg
-			"-D" dpi
-			;;"-x" scale "-y" scale
-			"-T" "tight"
-			"-o" pngfile
-			dvifile)
-	(error nil))
-      (if (not (file-exists-p pngfile))
-	  (if org-format-latex-signal-error
-	      (error "Failed to create png file from %s" texfile)
-	    (message "Failed to create png file from %s" texfile)
-	    nil)
-	;; Use the requested file name and clean up
-	(copy-file pngfile tofile 'replace)
-	(loop for e in '(".dvi" ".tex" ".aux" ".log" ".png") do
-	      (delete-file (concat texfilebase e)))
-	pngfile))))
+		  (if (featurep 'xemacs)
+			  (call-process "dvipng" nil nil nil
+							"-fg" fg "-bg" bg
+;;			"-D" dpi
+;;			"-x" scale "-y" scale
+							"-T" "tight"
+							"-o" pngfile
+							dvifile)
+			(call-process "dvipng" nil nil nil
+						  "-fg" fg "-bg" bg
+						  "-D" dpi
+						  ;;"-x" scale "-y" scale
+						  "-T" "tight"
+						  "-o" pngfile
+						  dvifile))
+			(error nil))
+		(if (not (file-exists-p pngfile))
+			(if org-format-latex-signal-error
+				(error "Failed to create png file from %s" texfile)
+			  (message "Failed to create png file from %s" texfile)
+			  nil)
+		  ;; Use the requested file name and clean up
+		  (copy-file pngfile tofile 'replace)
+		  (loop for e in '(".dvi" ".tex" ".aux" ".log" ".png") do
+			(delete-file (concat texfilebase e)))
+		  pngfile))))
 
 (defun org-splice-latex-header (tpl def-pkg pkg snippets-p &optional extra)
   "Fill a LaTeX header template TPL.
@@ -17077,7 +17085,12 @@
   "Return an rgb color specification for dvipng."
   (apply 'format "rgb %s %s %s"
 	 (mapcar 'org-normalize-color
-		 (color-values (face-attribute 'default attr nil)))))
+				 (if (featurep 'xemacs)
+					 (color-rgb-components
+					  (face-property 'default (cond 
+											   ((eq attr :foreground) 'foreground)
+											   ((eq attr :background) 'background))))
+		 (color-values (face-attribute 'default attr nil))))))
 
 (defun org-normalize-color (value)
   "Return string to be used as color value for an RGB component."

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: patch
  2012-01-31 18:09     ` patch " Uwe Brauer
@ 2012-03-16 17:57       ` Bastien
  0 siblings, 0 replies; 22+ messages in thread
From: Bastien @ 2012-03-16 17:57 UTC (permalink / raw
  To: Uwe Brauer; +Cc: emacs-orgmode

Hi Uwe,

Uwe Brauer <oub@mat.ucm.es> writes:

> Here comes the patch (I tested it with Xemacs 21.5 and GNU
> emacs 23.1); I used the 
> diff -u option and hope this is ok.

Applied, thanks for the patch.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 11:26   ` Kaushal Modi
@ 2016-05-05 16:10     ` Uwe Brauer
  2016-05-05 16:18       ` SOLVED Kaushal Modi
  2016-05-05 20:12     ` SOLVED Uwe Brauer
  2016-05-05 20:50     ` SOLVED Uwe Brauer
  2 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2016-05-05 16:10 UTC (permalink / raw
  To: emacs-devel

>>> "Kaushal" == Kaushal Modi <kaushal.modi@gmail.com> writes:



    >     , but not sure about the structure of
    >     that patch



    >     (which git diff option to use


    > - You first need to rebase your local git area to emacs-25 as you are
    > planning to provide just a documentation patch, (otherwise you would
    > rebase to the master branch). 

 I am a bit confused now, I cloned originally via

 git clone git://git.savannah.gnu.org/emacs.git

And then ever pulled from it from time to time. That is what?, master or
emacs-25?

    > - Then git commit the changes in your local area. 
    > - http://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE has
    > instructions on the style of writing commit logs. 
    > - Use git format_patch HEAD~1 to create patch for that last commit. 

Ok thanks

    >     , to whom to send that patch


    > - You use the same M-x report-emacs-bug to describe the problem you
    > are solving along with the inline pasted patch you just created. 


    >     etc).


    > While you are at it, you can even initiate the process to finish the
    > copyright paperwork if you'd like to contribute more in future (why
    > not! :)); even though you don't need that right now for 3 lines of
    > documentation patch. 

Right, I wanted to wait till I am again in Germany, since I could to it
electronically while I can't while I am in Spain, progress, sigh


    > I see that you heavily contribute to matlab-mode.el. Thanks for
    > maintaining that!

Ah well, I provided some functionality but I think the person who really
contributed heavily to matlab-mode.el is Eric Ludlam, who unfortunately
is too busy to maintain matlab-mode.el, so I just  stepped in.


    > And as Stefan Monnier mentioned in an earlier email
    > thread, that could possibly be integrated into octave-mode.el piece
    > by piece and be part of Emacs. 

Ah well there are two problems with that:

    -  a technical one. The real difference between these two packages
       IMHO is their shell. The relevant matlab code was written over a
       very long period of time (starting in 91), is very matlab
       specific and looks very complicated to me. I am not really sure
       that anyone besides Eric understands it.

    -  a copyright issue. I did not discuss this in detail on this list,
       but RMS asked me why the code could not be in ELPA instead of
       being in MELPA and the reason is that MathWorks has some
       copyright over some parts of the code and it is very very
       unlikely that they will transfer that copyright to the FSF. The
       code is under GPL2+ though. 


    > Hope this helps. 
    > --

Yes it did thanks.

Uwe 




^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 16:10     ` SOLVED Uwe Brauer
@ 2016-05-05 16:18       ` Kaushal Modi
  2016-05-05 16:41         ` SOLVED Andreas Schwab
  0 siblings, 1 reply; 22+ messages in thread
From: Kaushal Modi @ 2016-05-05 16:18 UTC (permalink / raw
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

>
>  I am a bit confused now, I cloned originally via
>
>  git clone git://git.savannah.gnu.org/emacs.git
>
> And then ever pulled from it from time to time. That is what?, master or
> emacs-25?
>

By default the origin/master will be cloned.

I use the below to FORCE update to emacs-25

                                 git fetch --all
                                 git checkout origin/emacs-25
                                 git reset --hard origin/emacs-25

Right, I wanted to wait till I am again in Germany, since I could to it
> electronically while I can't while I am in Spain, progress, sigh
>

Cool!

Ah well, I provided some functionality but I think the person who really
> contributed heavily to matlab-mode.el is Eric Ludlam, who unfortunately
> is too busy to maintain matlab-mode.el, so I just  stepped in.
>

Thanks though for keeping the maintenance alive.

Ah well there are two problems with that:
>
>     -  a technical one. The real difference between these two packages
>        IMHO is their shell. The relevant matlab code was written over a
>        very long period of time (starting in 91), is very matlab
>        specific and looks very complicated to me. I am not really sure
>        that anyone besides Eric understands it.
>
>     -  a copyright issue. I did not discuss this in detail on this list,
>        but RMS asked me why the code could not be in ELPA instead of
>        being in MELPA and the reason is that MathWorks has some
>        copyright over some parts of the code and it is very very
>        unlikely that they will transfer that copyright to the FSF. The
>        code is under GPL2+ though.


Understood. matlab-mode.el was just an example. I used to express that once
you have the copyright paperwork, it's much easier to contribute to Emacs
:) But it's great that you are already looking into it.

-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2921 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 16:18       ` SOLVED Kaushal Modi
@ 2016-05-05 16:41         ` Andreas Schwab
  0 siblings, 0 replies; 22+ messages in thread
From: Andreas Schwab @ 2016-05-05 16:41 UTC (permalink / raw
  To: Kaushal Modi; +Cc: emacs-devel

Kaushal Modi <kaushal.modi@gmail.com> writes:

> I use the below to FORCE update to emacs-25
>
>                                  git fetch --all
>                                  git checkout origin/emacs-25

You should use "git checkout emacs-25".

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 11:26   ` Kaushal Modi
  2016-05-05 16:10     ` SOLVED Uwe Brauer
@ 2016-05-05 20:12     ` Uwe Brauer
  2016-05-06  6:27       ` SOLVED Eli Zaretskii
  2016-05-05 20:50     ` SOLVED Uwe Brauer
  2 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2016-05-05 20:12 UTC (permalink / raw
  To: emacs-devel




   > That's great! 


   >     , but not sure about the structure of
   >     that patch



   >     (which git diff option to use


   > - You first need to rebase your local git area to emacs-25 as you are
   > planning to provide just a documentation patch, (otherwise you would
   > rebase to the master branch). 
   > - Then git commit the changes in your local area. 
   > - http://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE has
   > instructions on the style of writing commit logs. 
   > - Use git format_patch HEAD~1 to create patch for that last commit. 


   >     , to whom to send that patch


   > - You use the same M-x report-emacs-bug to describe the problem you
   > are solving along with the inline pasted patch you just created. 


   >     etc).


   > While you are at it, you can even initiate the process to finish the
   > copyright paperwork if you'd like to contribute more in future (why
   > not! :)); even though you don't need that right now for 3 lines of
   > documentation patch. 

   > I see that you heavily contribute to matlab-mode.el. Thanks for
   > maintaining that! And as Stefan Monnier mentioned in an earlier email
   > thread, that could possibly be integrated into octave-mode.el piece
   > by piece and be part of Emacs. 

   > Hope this helps. 
   > --

BTW, so the manual is a bit outdated and maybe it should be upgraded,
what do you think?.....

BTW which MUA are you using, because I have problems (using gnus) to
separate your response from my text (your are not the first one though)
the quotations with > seems flawed.




^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 11:26   ` Kaushal Modi
  2016-05-05 16:10     ` SOLVED Uwe Brauer
  2016-05-05 20:12     ` SOLVED Uwe Brauer
@ 2016-05-05 20:50     ` Uwe Brauer
  2016-05-05 21:33       ` SOLVED Kaushal Modi
  2 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2016-05-05 20:50 UTC (permalink / raw
  To: emacs-devel

>>> "Kaushal" == Kaushal Modi <kaushal.modi@gmail.com> writes:

   >     I suggest to change/add the docstring accordingly, because the
   >     new

   >     behavior is a radical change.
   
   >     I could provide a 'patch' for that[1]


   > That's great! 


   >     , but not sure about the structure of

   > - You first need to rebase your local git area to emacs-25 as you are
   > planning to provide just a documentation patch, (otherwise you would
   > rebase to the master branch). 
   > - Then git commit the changes in your local area. 
   > - http://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE has
   > instructions on the style of writing commit logs. 
   > - Use git format_patch HEAD~1 to create patch for that last commit. 

I just followed your instructions of your other mail to rebase to
emacs-25, but Daniels changes are not there.

His changes seem only to be in emacs-master. (I am sorry I am not very
familiar with git, for my personal stuff I use hg and I use even the
git-hg plugin to maintain matlab, but I don't dare to do that for
emacs...)




^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 20:50     ` SOLVED Uwe Brauer
@ 2016-05-05 21:33       ` Kaushal Modi
  2016-05-06  7:53         ` SOLVED Uwe Brauer
  0 siblings, 1 reply; 22+ messages in thread
From: Kaushal Modi @ 2016-05-05 21:33 UTC (permalink / raw
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

Hi Uwe,

I am using Google Inbox to write emails. I apologize for the email format
as I don't know what I can do to fix this. This is what it looks like to me
when I am writing the email: http://i.imgur.com/oYhaTHg.png


> I just followed your instructions of your other mail to rebase to
> emacs-25, but Daniels changes are not there.
>


> His changes seem only to be in emacs-master. (I am sorry I am not very
> familiar with git, for my personal stuff I use hg and I use even the
> git-hg plugin to maintain matlab, but I don't dare to do that for
> emacs...)
>

Sorry for creating this confusion. You are correct; those changes to vc-hg
(
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=de76a167dc09dc695a5acebabb7ab354a6bf556e
)
are only in the master branch. So there is no point sending a patch rebased
to emasc-25. I had incorrectly assumed that your documentation patch could
apply to emacs-25 too.

So just rebase to the master branch using the below.

git fetch --all
git checkout master
git reset --hard origin/master

Then format your patch and send it to bug-gnu-emacs@gnu.org.
-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1881 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 20:12     ` SOLVED Uwe Brauer
@ 2016-05-06  6:27       ` Eli Zaretskii
  0 siblings, 0 replies; 22+ messages in thread
From: Eli Zaretskii @ 2016-05-06  6:27 UTC (permalink / raw
  To: Uwe Brauer; +Cc: emacs-devel

> From: Uwe Brauer <oub@mat.ucm.es>
> Date: Thu, 05 May 2016 20:12:36 +0000
> 
> BTW, so the manual is a bit outdated and maybe it should be upgraded,
> what do you think?.....

That section of the manual is written for casual contributors.  The
next section, "Contributing to Emacs Development", mentions the file
CONTRIBUTE, which provides the details for more frequent contributors.



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-05 21:33       ` SOLVED Kaushal Modi
@ 2016-05-06  7:53         ` Uwe Brauer
  2016-05-06  9:28           ` SOLVED Yuri Khan
  0 siblings, 1 reply; 22+ messages in thread
From: Uwe Brauer @ 2016-05-06  7:53 UTC (permalink / raw
  To: emacs-devel

>>> "Kaushal" == Kaushal Modi <kaushal.modi@gmail.com> writes:

Hi Kaushal


   > Hi Uwe,
   > I am using Google Inbox to write emails. I apologize for the email
   > format as I don't know what I can do to fix this. This is what it
   > looks like to me when I am writing the email: http://i.imgur.com/
   > oYhaTHg.png


I see. I just tried out my google account. The reason for this behavior
is that you use, google rich-text-format (which is not really html it
seems). Be it as it may, if you activate the option plain text for
sending, then the quotes are displayed correctly in gnus.

I will ask in the gnus list  how to deal with that, but may I suggest
for the time being to use plain text format? But maybe I am the only one
who find this confusing....

BTW how to you deal with gmail's top posting style, which I find one of
the most annoying things, since it cannot be changes (as you can say in
Thunderbird).


thanks

Uwe 




^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06  7:53         ` SOLVED Uwe Brauer
@ 2016-05-06  9:28           ` Yuri Khan
  2016-05-06 10:29             ` SOLVED Uwe Brauer
  2016-05-06 12:10             ` SOLVED Clément Pit--Claudel
  0 siblings, 2 replies; 22+ messages in thread
From: Yuri Khan @ 2016-05-06  9:28 UTC (permalink / raw
  To: Emacs developers

On Fri, May 6, 2016 at 1:53 PM, Uwe Brauer <oub@mat.ucm.es> wrote:

> I see. I just tried out my google account. The reason for this behavior
> is that you use, google rich-text-format (which is not really html it
> seems).

I looked at Kaushal’s message and I do see the <blockquote> element
around quoted text. What else would you ask of a MUA?

> BTW how to you deal with gmail's top posting style, which I find one of
> the most annoying things, since it cannot be changes (as you can say in
> Thunderbird).

I am writing this from gmail. When you hit reply, there is a small
button with an ellipsis at the bottom. When you click it, it expands
into a quoted parent message, whereupon you can trim quotes and add
your own text.

Gmail also lets you switch to plain text, using the dropdown menu
button at the bottom right.

Google Inbox, on the other hand, did not support sending
plain-text-only mail the last time I checked. (FYI Inbox and Gmail are
different products.)



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06  9:28           ` SOLVED Yuri Khan
@ 2016-05-06 10:29             ` Uwe Brauer
  2016-05-06 12:10             ` SOLVED Clément Pit--Claudel
  1 sibling, 0 replies; 22+ messages in thread
From: Uwe Brauer @ 2016-05-06 10:29 UTC (permalink / raw
  To: emacs-devel

>>> "Yuri" == Yuri Khan <yuri.v.khan@gmail.com> writes:

   > On Fri, May 6, 2016 at 1:53 PM, Uwe Brauer <oub@mat.ucm.es> wrote:
   >> I see. I just tried out my google account. The reason for this behavior
   >> is that you use, google rich-text-format (which is not really html it
   >> seems).

   > I looked at Kaushal’s message and I do see the <blockquote> element
   > around quoted text.

Correct, that is why Thunderbird/Seamonkey does display the quotes
correctly, gnus seems not. So it might be a gnus problem, or an error in
my configuration. I had a quick look around (without any statistical
analysis I must add): TB, gnus, and gmail I see most often, plus people
who seem to use Emacs, but it is not clear to me which MUA, like Eli
(most likely rmail). Since I seem to be the only one to complain, maybe my
gnus is badly configured. I asked already in the gnus group.


   > What else would you ask of a MUA?

   >> BTW how to you deal with gmail's top posting style, which I find one of
   >> the most annoying things, since it cannot be changes (as you can say in
   >> Thunderbird).

   > I am writing this from gmail. When you hit reply, there is a small
   > button with an ellipsis at the bottom. When you click it, it expands
   > into a quoted parent message, whereupon you can trim quotes and add
   > your own text.

Ok, this I know, I thought there was some hidden configuration which
would allow you to skip this step.



   > Gmail also lets you switch to plain text, using the dropdown menu
   > button at the bottom right.

   > Google Inbox, on the other hand, did not support sending
   > plain-text-only mail the last time I checked. (FYI Inbox and Gmail are
   > different products.)

Ah, ok thanks for clarifying did not know, (or forgot).


Uwe 




^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06  9:28           ` SOLVED Yuri Khan
  2016-05-06 10:29             ` SOLVED Uwe Brauer
@ 2016-05-06 12:10             ` Clément Pit--Claudel
  2016-05-06 12:24               ` SOLVED Yuri Khan
  1 sibling, 1 reply; 22+ messages in thread
From: Clément Pit--Claudel @ 2016-05-06 12:10 UTC (permalink / raw
  To: emacs-devel


[-- Attachment #1.1: Type: text/plain, Size: 633 bytes --]

On 2016-05-06 05:28, Yuri Khan wrote:
>> > I see. I just tried out my google account. The reason for this behavior
>> > is that you use, google rich-text-format (which is not really html it
>> > seems).
> I looked at Kaushal’s message and I do see the <blockquote> element
> around quoted text. What else would you ask of a MUA?

I thing the issue is mostly that GMail includes two copy of each message; one with <blockquote>s, and one that claims to be text-only. The text-only one is a mess. Unless you configure your client to ignore the text-only one and regenerate it from the html one, you see what Uwe was seeing.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06 12:10             ` SOLVED Clément Pit--Claudel
@ 2016-05-06 12:24               ` Yuri Khan
  2016-05-06 12:32                 ` SOLVED Clément Pit--Claudel
  0 siblings, 1 reply; 22+ messages in thread
From: Yuri Khan @ 2016-05-06 12:24 UTC (permalink / raw
  To: Clément Pit--Claudel; +Cc: Emacs developers

On Fri, May 6, 2016 at 6:10 PM, Clément Pit--Claudel
<clement.pit@gmail.com> wrote:
> On 2016-05-06 05:28, Yuri Khan wrote:
>>> > I see. I just tried out my google account. The reason for this behavior
>>> > is that you use, google rich-text-format (which is not really html it
>>> > seems).
>> I looked at Kaushal’s message and I do see the <blockquote> element
>> around quoted text. What else would you ask of a MUA?
>
> I thing the issue is mostly that GMail includes two copy of each message; one with <blockquote>s, and one that claims to be text-only. The text-only one is a mess. Unless you configure your client to ignore the text-only one and regenerate it from the html one, you see what Uwe was seeing.

No, Gmail sends normal “Content-Type: multipart/alternative” messages,
where the first alternative is text/plain and uses conventional “>”
quoting, and the second alternative is text/html, optionally encoded
as quoted-printable, with <blockquote> quoting. The messages are valid
w.r.t. RFC 2822 and RFC 2045, and the text/html payload is loosely
well-formed HTML5.

I should really look at how Gnus renders (and quotes) HTML mail sometime.



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06 12:24               ` SOLVED Yuri Khan
@ 2016-05-06 12:32                 ` Clément Pit--Claudel
  2016-05-06 13:00                   ` SOLVED Eli Zaretskii
  0 siblings, 1 reply; 22+ messages in thread
From: Clément Pit--Claudel @ 2016-05-06 12:32 UTC (permalink / raw
  To: Yuri Khan; +Cc: Emacs developers


[-- Attachment #1.1: Type: text/plain, Size: 1445 bytes --]

On 2016-05-06 08:24, Yuri Khan wrote:
> No, Gmail sends normal “Content-Type: multipart/alternative”
> messages, where the first alternative is text/plain and uses
> conventional “>” quoting, and the second alternative is text/html,
> optionally encoded as quoted-printable, with <blockquote> quoting.
> The messages are valid w.r.t. RFC 2822 and RFC 2045, and the
> text/html payload is loosely well-formed HTML5.

I don't think so. When I look at the source of Kaushal's messages, the '>' character is missing on the first line of each quoted section (see for example his message <CAFyQvY0-gMVfOTbCvCm7JUZEf2NaWKkfn-EDk2MSM_WTvJVKQw@mail.gmail.com>). Thus what should be rendered as the following is actually as shown below in the message body:

(Intended rendering, as suggested by the blockquotes in the HTML version:)

    > I suggest to change/add the docstring accordingly, because the new
    > behavior is a radical change.

    > I could provide a 'patch' for that[1]

    That's great!

    > , but not sure about the structure of
    > that patch

(Actual rendering:)

    >
    > I suggest to change/add the docstring accordingly, because the new

    behavior is a radical change.
    >
    > I could provide a 'patch' for that[1]


    That's great!

    , but not sure about the structure of
    > that patch

Or is there an issue with Thunderbird's source rendering?

Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: SOLVED
  2016-05-06 12:32                 ` SOLVED Clément Pit--Claudel
@ 2016-05-06 13:00                   ` Eli Zaretskii
  0 siblings, 0 replies; 22+ messages in thread
From: Eli Zaretskii @ 2016-05-06 13:00 UTC (permalink / raw
  To: Clément Pit--Claudel; +Cc: emacs-devel, yuri.v.khan

> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Fri, 6 May 2016 08:32:20 -0400
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> On 2016-05-06 08:24, Yuri Khan wrote:
> > No, Gmail sends normal “Content-Type: multipart/alternative”
> > messages, where the first alternative is text/plain and uses
> > conventional “>” quoting, and the second alternative is text/html,
> > optionally encoded as quoted-printable, with <blockquote> quoting.
> > The messages are valid w.r.t. RFC 2822 and RFC 2045, and the
> > text/html payload is loosely well-formed HTML5.
> 
> I don't think so. When I look at the source of Kaushal's messages, the '>' character is missing on the first line of each quoted section (see for example his message <CAFyQvY0-gMVfOTbCvCm7JUZEf2NaWKkfn-EDk2MSM_WTvJVKQw@mail.gmail.com>). Thus what should be rendered as the following is actually as shown below in the message body:
> 
> (Intended rendering, as suggested by the blockquotes in the HTML version:)
> 
>     > I suggest to change/add the docstring accordingly, because the new
>     > behavior is a radical change.
> 
>     > I could provide a 'patch' for that[1]
> 
>     That's great!
> 
>     > , but not sure about the structure of
>     > that patch
> 
> (Actual rendering:)
> 
>     >
>     > I suggest to change/add the docstring accordingly, because the new
> 
>     behavior is a radical change.
>     >
>     > I could provide a 'patch' for that[1]
> 
> 
>     That's great!
> 
>     , but not sure about the structure of
>     > that patch
> 
> Or is there an issue with Thunderbird's source rendering?

Is this really relevant to Emacs?  If not, could you take this
discussion elsewhere?

Thanks.



^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2016-05-06 13:00 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-28 20:20 Xemacs: org-preview-latex-fragment, png not readable Uwe Brauer
2012-01-28 20:59 ` Solved (was: Xemacs: org-preview-latex-fragment, png not readable.) Uwe Brauer
2012-01-28 22:33   ` Solved Bastien
2012-01-29  0:13     ` Solved Nick Dokos
2012-01-29 14:57       ` change call-process also for GNU emacs? (was: Solved) Uwe Brauer
2012-01-29 17:42         ` Nick Dokos
2012-01-31 18:09     ` patch " Uwe Brauer
2012-03-16 17:57       ` patch Bastien
  -- strict thread matches above, loose matches on Subject: below --
2016-05-02 20:01 vc-hg modeline changed Uwe Brauer
2016-05-05  9:15 ` SOLVED (was: vc-hg modeline changed.) Uwe Brauer
2016-05-05 11:26   ` Kaushal Modi
2016-05-05 16:10     ` SOLVED Uwe Brauer
2016-05-05 16:18       ` SOLVED Kaushal Modi
2016-05-05 16:41         ` SOLVED Andreas Schwab
2016-05-05 20:12     ` SOLVED Uwe Brauer
2016-05-06  6:27       ` SOLVED Eli Zaretskii
2016-05-05 20:50     ` SOLVED Uwe Brauer
2016-05-05 21:33       ` SOLVED Kaushal Modi
2016-05-06  7:53         ` SOLVED Uwe Brauer
2016-05-06  9:28           ` SOLVED Yuri Khan
2016-05-06 10:29             ` SOLVED Uwe Brauer
2016-05-06 12:10             ` SOLVED Clément Pit--Claudel
2016-05-06 12:24               ` SOLVED Yuri Khan
2016-05-06 12:32                 ` SOLVED Clément Pit--Claudel
2016-05-06 13:00                   ` SOLVED Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.