From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Mon, 30 Jan 2023 16:47:01 +0200 Message-ID: <373a575f-c683-1581-c3e6-502e9897fb04@yandex.ru> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <04729838-b7d4-8a08-2b71-12536a28aebb@yandex.ru> <83wn5ag4nc.fsf@gnu.org> <01b5d074-fb12-6b1f-cbfb-5e759833b854@yandex.ru> <838rhpg57n.fsf@gnu.org> <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> <83pmb1emxi.fsf@gnu.org> <6f318afc-ca71-8b7e-c822-52e6635b5718@yandex.ru> <83sffxcfxw.fsf@gnu.org> <83pmb1cbg5.fsf@gnu.org> <2da844d3-ea31-289e-2821-aa174e365ffd@yandex.ru> <6784f9e7-844b-374d-2a1e-8a61cebe0d7e@yandex.ru> <83zga03yne.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: casouri@gmail.com, 60953@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 15:49:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMVSx-0000rN-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 15:49:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMVSG-0004I6-AX; Mon, 30 Jan 2023 09:48:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMVRz-0004DP-Fh for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:48:17 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMVRy-0007XP-2h for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMVRx-0005Jy-VN for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60953 X-GNU-PR-Package: emacs Original-Received: via spool by 60953-submit@debbugs.gnu.org id=B60953.167509003620284 (code B ref 60953); Mon, 30 Jan 2023 14:48:01 +0000 Original-Received: (at 60953) by debbugs.gnu.org; 30 Jan 2023 14:47:16 +0000 Original-Received: from localhost ([127.0.0.1]:46816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVRD-0005H5-Tt for submit@debbugs.gnu.org; Mon, 30 Jan 2023 09:47:16 -0500 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:39479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVR8-0005Gh-2r for 60953@debbugs.gnu.org; Mon, 30 Jan 2023 09:47:10 -0500 Original-Received: by mail-ed1-f42.google.com with SMTP id y11so11170616edd.6 for <60953@debbugs.gnu.org>; Mon, 30 Jan 2023 06:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ZWqCmWvC7lDdWhhtUYU2g7FLAYhzBg0Wokh3Ji1e0bI=; b=XVEeEClz4tTorrRt6ebjRWjv1K9X7evRUbjiJOuLe9rYj0UhcRXL0AIvfa1ZfMkqW2 mdi1yZnzG2WBO5LhJJ6qpVQujZaTYVBQbyRNBoL4lqr2MBiiKuKgzW34iLiH9VusCOJB PX3u9hD9YbcgbGIkgDDf+rl+CQGls0pskR5cZQc6VAu2Qa15FPzPZJiLYehegkGG1sSq LFoVGvSZoW7yKTRmzwOdnI56ioIlkKR5E4Cn6I+5j4hwdlOYXPBuuM6FwO/6HRfbge7d WQ3RvPCAlC3qWcuXqbQjcQIauD3DTseZMnDq00yBcTi1vJSj1B6hH/ebe9GIsTSr4nkD bBxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZWqCmWvC7lDdWhhtUYU2g7FLAYhzBg0Wokh3Ji1e0bI=; b=pzrnsp0mBEmFg2A/ijflJMVxldmndRCjd1vyVsUhkszADAWfYFmr5AF6V501V3PwWy XoaVxCEmlgoBmsGRT9gKrZ9pD1I7C1vQt4VKQv3RakCvJA1r1SOzwdoWtuIC6JRjXUHg 11T2Zkp08SlFxZ+9BSnulVk5C+p2qjmDy4j3bZyWTgMCtCtTZQ8Vv1bRmXjIxW0qQkxl sCQNgad7d5RppWcf6Z/UuO48F0tnJFQXfJCw/B52j34nX1lYzH+bcRTttKccBoJxo41M PAYVPUGE8DXS7ABGFz7pKrHrM0lCyt5Wtcy35hIAjkGeW1NXwGhWQYayCkHp8Ot4Q+zj L6LA== X-Gm-Message-State: AFqh2koyajSNyR5EDHlmPzGhGDqmihcCZF4BMnb6+lNHc8MwImqZeKiW uhj57gequgb0R0K3soOYe2U= X-Google-Smtp-Source: AMrXdXtxp5uCylt5XuqJFCkJGFVjEeFOpLgo68hM7QNIbUb+yh1qvZzup5LN8f1NAtkwvqtWEF47uA== X-Received: by 2002:a50:c005:0:b0:49e:f062:99e6 with SMTP id r5-20020a50c005000000b0049ef06299e6mr37718932edb.28.1675090024105; Mon, 30 Jan 2023 06:47:04 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z7-20020a05640240c700b0046c4553010fsm6941353edb.1.2023.01.30.06.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 06:47:03 -0800 (PST) Content-Language: en-US In-Reply-To: <83zga03yne.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254435 Archived-At: On 30/01/2023 16:06, Eli Zaretskii wrote: > Our style is to leave a blank between ASET and the left parenthesis. Sure, thanks. > Mmm... no. You should use Fnarrow_to_region, I think. Last time I tried that (from Lisp, with save-restriction), I think the result was measurably slower. I can try it again from C, though. > But why do you need to narrow there? fast_looking_at will not go > beyond end_pos/end_byte anyway, there's no need to restrict it. The reason for that is to be able to support the \` and \' markers in REGEXP. I haven't found any alternative approach that doesn't call 'substring'. > And here I suggest an additional optimization, since you already know > the byte positions: No real objection from me if you're sure, but I tried that, and the benchmarks showed no difference. So I submitted the shorter version. (I suppose we also could save the previous values of BEGV_BYTE and ZV_BYTE to use when restoring.) Either way, we would use this *instead of* Fnarrow_to_region, right? Because it only accepts two arguments.