From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Davis Herring" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Mon, 7 Jun 2010 15:28:05 -0700 (PDT) Message-ID: <37180.130.55.118.19.1275949685.squirrel@webmail.lanl.gov> References: <1275757657-15244-1-git-send-email-julien@danjou.info> <87ljar3uug.fsf@gmx.de> Reply-To: herring@lanl.gov NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1275949724 25533 80.91.229.12 (7 Jun 2010 22:28:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Jun 2010 22:28:44 +0000 (UTC) Cc: Michael Albinus , emacs-devel@gnu.org To: "Julien Danjou" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 08 00:28:42 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OLkoB-0002R2-Ee for ged-emacs-devel@m.gmane.org; Tue, 08 Jun 2010 00:28:39 +0200 Original-Received: from localhost ([127.0.0.1]:60638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLkoA-0004rj-N8 for ged-emacs-devel@m.gmane.org; Mon, 07 Jun 2010 18:28:38 -0400 Original-Received: from [140.186.70.92] (port=53894 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLkny-0004m1-OO for emacs-devel@gnu.org; Mon, 07 Jun 2010 18:28:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLknx-0002af-Ob for emacs-devel@gnu.org; Mon, 07 Jun 2010 18:28:26 -0400 Original-Received: from proofpoint2.lanl.gov ([204.121.3.26]:51208) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLknx-0002aS-FR for emacs-devel@gnu.org; Mon, 07 Jun 2010 18:28:25 -0400 Original-Received: from mailrelay2.lanl.gov (mailrelay2.lanl.gov [128.165.4.103]) by proofpoint2.lanl.gov (8.14.3/8.14.3) with ESMTP id o57MZsXe015894; Mon, 7 Jun 2010 16:35:54 -0600 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mailrelay2.lanl.gov (Postfix) with ESMTP id 5890F17B9BC4; Mon, 7 Jun 2010 16:28:05 -0600 (MDT) X-NIE-2-Virus-Scanner: amavisd-new at mailrelay2.lanl.gov Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay2.lanl.gov (Postfix) with ESMTP id 45C1017B9BC3; Mon, 7 Jun 2010 16:28:05 -0600 (MDT) Original-Received: by webmail1.lanl.gov (Postfix, from userid 48) id 43D431CA8368; Mon, 7 Jun 2010 16:28:05 -0600 (MDT) Original-Received: from 130.55.118.19 (SquirrelMail authenticated user 196434) by webmail.lanl.gov with HTTP; Mon, 7 Jun 2010 15:28:05 -0700 (PDT) In-Reply-To: User-Agent: SquirrelMail/1.4.8-5.el5_4.10.lanl1 X-Priority: 3 (Normal) Importance: Normal X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2010-06-07_04:2010-02-06, 2010-06-07, 2010-06-07 signatures=0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125616 Archived-At: >>> + :app-icon The notification icon. >> >> If not given, you could apply a default value. A good value might be >> >> (expand-file-name "images/icons/hicolor/scalable/apps/emacs.svg" >> data-directory) > > Good idea, thanks. Added. You should be careful to allow the caller to specifically request no icon; I see from the code that :app-icon nil won't do that; perhaps :app-icon "" would? Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.