From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#42966: 28.0.50; vc-dir: wrong backend Date: Fri, 16 Oct 2020 15:44:34 +0300 Message-ID: <3708c3db-df78-1a50-857a-595f2412e284@yandex.ru> References: <87d01imtwl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 42966@debbugs.gnu.org To: Lars Ingebrigtsen , Sam Steingold Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 16 14:45:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTP6r-00021k-7m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Oct 2020 14:45:25 +0200 Original-Received: from localhost ([::1]:57906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTP6q-0002IF-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Oct 2020 08:45:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTP6U-0002Hj-59 for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 08:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTP6T-0002BW-Rd for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 08:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTP6T-0008Ax-O5 for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 08:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42966 X-GNU-PR-Package: emacs Original-Received: via spool by 42966-submit@debbugs.gnu.org id=B42966.160285228431385 (code B ref 42966); Fri, 16 Oct 2020 12:45:01 +0000 Original-Received: (at 42966) by debbugs.gnu.org; 16 Oct 2020 12:44:44 +0000 Original-Received: from localhost ([127.0.0.1]:58046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTP6B-0008A9-W6 for submit@debbugs.gnu.org; Fri, 16 Oct 2020 08:44:44 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:35707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTP6A-00089x-Bi for 42966@debbugs.gnu.org; Fri, 16 Oct 2020 08:44:42 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id cq12so2200079edb.2 for <42966@debbugs.gnu.org>; Fri, 16 Oct 2020 05:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tYsxHp0dvcnQ0fmPOL2DyRMPKAgrHg2pfu/uSWBJlVc=; b=SpQXPxOvD0koJgmt5D1baSIsSNIdUwC9oW+A9fJuwnq5vc7tXhbB96CjDYoVg4GN/M WO8eyJGlSB+fmL8tNDD+bboTWTDRepXaS9b2ZscQkCqAr240C4mnDKD87/Pi3RYVu49Y NtsCWtg5ohEVp+Qa4qxw8KU/gkqmZCrAGHXn/3MYZMhS7dYPGiacSGC8EVu07DEKXuff Qc9AH/Xx6C2iygYl/tPfN68hMiZqWI1Kgc4owyrmEH2yKkWMpRFlR5nf8JhLtMFOHLCT dzAzoRS8QadRh22uiD36+PXA0LjClNTlD89KMKNVfuT/tW9j0WUKUNwxlZ3iApJXrTS8 Lc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tYsxHp0dvcnQ0fmPOL2DyRMPKAgrHg2pfu/uSWBJlVc=; b=b2S/eV9gXLTN0nL7gA7+W2axX8zOR3jMmttYU26Cq4Xwc2FEh+ScjfsFfjO7C15iQL 41kYetYltgf/XrUlIWSnXllT782G95Bu+3kHLmmu9up3J1f+9c03BuGIfv1hT6czoUy+ W0qhKMk6T4UibrBgB8ZWd7xolu+q4rHs8ASbK/3mGm4G5DHBJv3jIUtsrNL0uZLcfFzy 5kt26k48JuhppdnHo/eCsKyKmq0Vxe7RAD9jMu5htaDeV21k7+muEikjYLKsyOjB6foh pO/E/CAm0tyBbkJtGpfRMHsECpzU9HzScEzLneLWhXMvqMqz2ki6A3PBmmyhMPvl9lfa 41Yw== X-Gm-Message-State: AOAM532uMHb0fV2oWVFOF6q5xwIHmwAzj6xSOf0vETWpSNBkVJIQgvH1 t/3Bm5P2azd3gsB/7NLz28oIj223chpw8Q== X-Google-Smtp-Source: ABdhPJybNffOVeAx4CTFCo7/upJQMWKf/DyHrglbZSH39QRXd1J21BnFkYFaYXtYCaDrKS0MCY+zEg== X-Received: by 2002:a05:6402:943:: with SMTP id h3mr3697548edz.88.1602852276267; Fri, 16 Oct 2020 05:44:36 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id n20sm1450194eje.85.2020.10.16.05.44.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Oct 2020 05:44:35 -0700 (PDT) In-Reply-To: <87d01imtwl.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190690 Archived-At: On 16.10.2020 11:55, Lars Ingebrigtsen wrote: > But: > > (catch 'found > ;; First try: find a responsible backend. If this is for registration, > ;; it must be a backend under which FILE is not yet registered. > (dolist (backend vc-handled-backends) > (and (vc-call-backend backend 'responsible-p file) > (throw 'found backend)))) > > This just goes through the backends and the first one that happens to be > able to say "yes" wins. Shouldn't this instead go through all the > backends, and if more than one says "yes", then choose the one with the > most specific path? > > Looking at the code, that shouldn't be too hard to implement, because it > seems like responsible-p returns the root path? The code should be straightforward, but I'd like to see some performance measurements: both for the local case, and for the remote one (Tramp). The difference can be small, though, given that we already try a number of other backends first (Git is near the end of vc-handled-backends; we might want to change that, BTW).