From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Saulius Menkevicius Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Tue, 25 Jan 2022 14:25:23 +0200 Message-ID: <36bbd45c-0a87-13b7-1589-afe943329e20@fastmail.com> References: <7CFD5E28-8266-4004-BF66-255146D72722@gnu.org> <83r18whunp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35278"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: p.stephani2@gmail.com, alan@idiocy.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 25 13:34:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCL1u-0008sC-6s for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 13:34:35 +0100 Original-Received: from localhost ([::1]:45630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCL1s-0004E4-Ve for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 07:34:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCKt7-0002ZM-PF for emacs-devel@gnu.org; Tue, 25 Jan 2022 07:25:30 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCKt5-0004Lw-QX; Tue, 25 Jan 2022 07:25:29 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 400405C00CE; Tue, 25 Jan 2022 07:25:25 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Jan 2022 07:25:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=8SlEPubXIod8Wx t+O+IPm/xicTG+xeOm8Mgt6nEjYpk=; b=iSSizJ6feUjitwr2gt9Po1P+gMVXRF GBLgnh1jb/JrjC5tZ+X+qth4/tZg1ob23Ge1JtN73srpdlLhPigsX4v2WLNes7d2 Jw1MjJIdhPL6bhMjd4nZMNYlFoPU6fl1xbgw2E6H+VKdDJspeb3bWfcI0vnnSwM/ 8vLoyAZbNbs5sgMIO/kGYLl6b5OdSHZ3vhVfJ1NXsonpaG1sX7zz/3LKBJP2R4RU ZXyy6K9WLC0c/mDwy07us5nKYynnM36Iz2cWUKjhPw8BMQvlD6ivQm4SE0EaRseS 9pEpb/ue9WgTEgx04ZN8t1OFnN6nKF+jflhPNqYRR/4ONCeoxstRPFcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8SlEPubXIod8Wxt+O+IPm/xicTG+xeOm8Mgt6nEjY pk=; b=eIzPC3W+RczbxncMgw/4OxR5Jy3iQdmS0ilARMTR8wE6dWkGVg2w57eDw uHjBw+qbo87cQub2qSOibbx0h8jbo5DilH7sjEPqZyMhnjBV5ZgYaEQ/TiGUMofJ XO3kJrk4/iZieV4IVvwkxd5C2AUZViFtLlMYdFqa0jJN+yBcr3DW/qKmu2n5UPow 91odbQAbi36bGoCUjD7C+QowEACmAXeSdSttTKfGXRgSucloWP+HG2cqM3iVe/UI OHnqhyCr5koXIuFf2xVEdTU7O8W9tsmHUTeuyN7DoREJm+kFEgZ73OjSSsPMr+em 0Smatr9M5icSm7ZRL7YUmYQo7tGiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvdelgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghulhhi uhhsucfovghnkhgvvhhitghiuhhsuceoshgruhhlihhushhmvghnkhgvvhhitghiuhhsse hfrghsthhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepfffhtddukeegtefhgeek gfejjefgteejhfevkedvfffgfffhffegffeludetkedunecuffhomhgrihhnpehgihhthh husgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehsrghulhhiuhhsmhgvnhhkvghvihgtihhushesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jan 2022 07:25:24 -0500 (EST) Content-Language: en-US In-Reply-To: <83r18whunp.fsf@gnu.org> Received-SPF: pass client-ip=66.111.4.25; envelope-from=sauliusmenkevicius@fastmail.com; helo=out1-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285361 Archived-At: I certainly cannot answer that, it probably does some kind of sniffing on FDs and changes behaviour. To actually figure that out I would need to build a minimal test fixture for this bug/issue and submit to dotnet/runtime repo on github for them to check and/or fix it. -Saulius Am 25.01.22 um 14:22 schrieb Eli Zaretskii: >> Date: Tue, 25 Jan 2022 10:58:51 +0200 >> Cc: p.stephani2@gmail.com, alan@idiocy.org, mituharu@math.s.chiba-u.ac.jp >> From: Saulius Menkevicius >> >> Sorry I did not mention the platform, this happens on Linux/x64 and has >> been reported by multiple persons: >> >> - https://github.com/razzmatazz/csharp-language-server/issues/12 >> >> >> The issue has been noticed when dotnet-based LSP servers are used with >> emacs/lsp-mode, -- in particular lsp-mode starts the server using >> `make-process` and then communicates over stdio. Link to the code that >> launches the server: >> >> - https://github.com/emacs-lsp/lsp-mode/blob/master/lsp-mode.el#L6925 >> >> >> We have csharp-ls and fsac servers launched with the same mechanism as >> are for other languages -- which are working ok with posix_spawn >> enabled. It only breaks for those before-mentioned LSP servers that are >> implemented on top of dotnet and use dotnet runtime (same thing as JVM, >> but for C#/F#/CLR languages). >> >> Now it appears, that switch to posix_spawn broke communication over >> stdio to those dotnet-based LSP servers for some technical reason, -- I >> didn't investigate yet why, because it is a bit over my head. I *think* >> there is an interplay between posix_spawn-based process launch >> implementation in emacs and dotnet runtime stdio abstractions/platform >> layer -- because otherwise other language servers work with that commit >> that enables posix_spawn, like those based on JVM too. > What is special about dotnet's runtime stdio usage?