From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Stuart D. Herring" Newsgroups: gmane.emacs.devel Subject: Re: should search ring contain duplicates? Date: Thu, 4 May 2006 09:05:57 -0700 (PDT) Message-ID: <36938.128.165.123.132.1146758757.squirrel@webmail.lanl.gov> References: <200605030727.k437R2Wx009975@amrm2.ics.uci.edu> <87bqufwbls.fsf@jurta.org> <85iromw09n.fsf@lola.goethe.zz> Reply-To: herring@lanl.gov NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1146758929 14679 80.91.229.2 (4 May 2006 16:08:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 May 2006 16:08:49 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 04 18:08:42 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FbgNW-00064P-OJ for ged-emacs-devel@m.gmane.org; Thu, 04 May 2006 18:08:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbgNW-00052K-85 for ged-emacs-devel@m.gmane.org; Thu, 04 May 2006 12:08:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FbgLB-0003NA-4t for emacs-devel@gnu.org; Thu, 04 May 2006 12:06:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FbgL8-0003LI-Hl for emacs-devel@gnu.org; Thu, 04 May 2006 12:06:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbgL8-0003LC-BG for emacs-devel@gnu.org; Thu, 04 May 2006 12:06:06 -0400 Original-Received: from [192.65.95.54] (helo=mailwasher-b.lanl.gov) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FbgLg-0000po-P1; Thu, 04 May 2006 12:06:41 -0400 Original-Received: from mailrelay1.lanl.gov (mailrelay1.lanl.gov [128.165.4.101]) by mailwasher-b.lanl.gov (8.12.11.20060308/8.12.11/(ccn-5)) with ESMTP id k44G5w0K001279; Thu, 4 May 2006 10:05:58 -0600 Original-Received: from webmail1.lanl.gov (webmail1.lanl.gov [128.165.4.106]) by mailrelay1.lanl.gov (8.12.11.20060308/8.12.11/(ccn-5)) with ESMTP id k44G5vqm002183; Thu, 4 May 2006 10:05:57 -0600 Original-Received: from webmail1.lanl.gov (localhost.localdomain [127.0.0.1]) by webmail1.lanl.gov (8.12.11.20060308/8.12.11) with ESMTP id k44G5vnd006391; Thu, 4 May 2006 10:05:57 -0600 Original-Received: (from apache@localhost) by webmail1.lanl.gov (8.12.11.20060308/8.12.11/Submit) id k44G5vS5006389; Thu, 4 May 2006 09:05:57 -0700 X-Authentication-Warning: webmail1.lanl.gov: apache set sender to herring@lanl.gov using -f Original-Received: from 128.165.123.132 (SquirrelMail authenticated user 196434); by webmail.lanl.gov with HTTP; Thu, 4 May 2006 09:05:57 -0700 (PDT) In-Reply-To: <85iromw09n.fsf@lola.goethe.zz> Original-To: "David Kastrup" User-Agent: SquirrelMail/1.4.3a-11.EL3 X-Mailer: SquirrelMail/1.4.3a-11.EL3 X-Priority: 3 (Normal) Importance: Normal X-PMX-Version: 4.7.1.128075 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53912 Archived-At: > (defun history-push (newelt history &optional maxelt) > "Add NEWELT to the history list stored in the symbol HISTORY. > If symbol MAXELT is specified, the maximum length of the history is > specified by the value of that symbol. Otherwise, the maximum history > length is to the value of the `history-length' property on symbol > HISTORY, if set, or to the value of the `history-length' variable. > Remove duplicates of NEWELT unless `history-delete-duplicates' is nil." > (unless maxelt > (setq maxelt (or (get history 'history-length) > history-length))) > (if history-delete-duplicates > (set history (delete newelt (symbol-value history)))) > (set history (cons newelt (symbol-value history))) > (when (integerp maxelt) > (if (= 0 maxelt) > (set history nil) > (if (> (length (symbol-value history)) maxelt) > (setcdr (nthcdr (1- maxelt) (symbol-value history)) nil))))) > > Sure, you need to quote history in the call then, but it seems like > the trouble for a macro is not really warranted. Evaluating the history argument is a feature, not a bug. It lets you do something like this: (defun isearch-update-ring (string &optional regexp) "Add STRING to the beginning of the search ring. REGEXP says which ring to use." (history-push string (if regexp 'regexp-search-ring 'search-ring) (if regexp regexp-search-ring-max search-ring-max))) (With, of course, modifications if Kim's `add-to-history' is used instead.) Davis -- This product is sold by volume, not by mass. If it appears too dense or too sparse, it is because mass-energy conversion has occurred during shipping.