From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files Date: Sat, 25 May 2024 17:51:11 +0300 Message-ID: <368566f1-142e-48d2-a54f-44e81ecf8d0a@gutov.dev> References: <86jzji1jpe.fsf@gnu.org> <864jamyrzy.fsf@gnu.org> <861q5qyoz4.fsf@gnu.org> <86zfsex9mq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 71179@debbugs.gnu.org To: Eli Zaretskii , Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 16:52:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAskg-0008BA-M9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 16:52:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAskW-0006Jg-N8; Sat, 25 May 2024 10:51:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAskU-0006Ei-Ik for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 10:51:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAskU-0002bD-8r for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 10:51:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAskb-0002O2-Pr for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 10:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 14:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71179-submit@debbugs.gnu.org id=B71179.17166486899100 (code B ref 71179); Sat, 25 May 2024 14:52:01 +0000 Original-Received: (at 71179) by debbugs.gnu.org; 25 May 2024 14:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:43864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAsk5-0002Mg-5y for submit@debbugs.gnu.org; Sat, 25 May 2024 10:51:29 -0400 Original-Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]:44219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAsk3-0002MM-Ek for 71179@debbugs.gnu.org; Sat, 25 May 2024 10:51:27 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 2E16C1C000BF; Sat, 25 May 2024 10:51:14 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 25 May 2024 10:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1716648673; x=1716735073; bh=b8vz4CPzjJbdOhec+CHH6uiabuNwrIZWSUkwpOLFf4w=; b= Dy0Hyk/EgtYCzVH4QhlIQQ++JAJ4Yk5d6QK0KjrS/U6AzX0LaPSFUCODLwWHrIOI TrDZ/lK2zclTA4IcG1Uc0t5fIkk+aTHOoobuVhrdtR5b/aAKtSmsIuy40n5UbLG5 Uz6N3aXKDX5d47OejNj9aJfu9yL4WSw9wznb+L83mwJIxeGAvW63uihE6njcvv3R bUS436QJo0HCe0hvRNtg8bB7WWAp68A5DETbt8g7hcOKP17Ccfeg4QR1dDhL4NoV w18HBcPrQEr1LEHGoQvAuHr++bKz2mlcCZcIifNQNBnCwGh78I96gn6u9Im2Meeo wEy5poJ9XGLW3XiJ/3bi6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716648673; x= 1716735073; bh=b8vz4CPzjJbdOhec+CHH6uiabuNwrIZWSUkwpOLFf4w=; b=U AiVOjXwlLD/V0cW2KljVC20MRVOKrQxt9Gh0XZ/V/Avk0bRC7fnVw8g/ECovMEIW 1nVsmt9KqFBGm74bft2VBQLzuz+ttRr/KvIm8yKDkzfwqJsHivx/+MOTchAFJ21j 91RrT+90yQqPYE2MmQ0V6UfYs/EsI05SilchZhe5tMPdW93PWQ1bsLjUB8Ui9QQ0 z2FNAKa5KOQ04RQGmy1YTnD+YooFVvMow01TVQG7mHVlpD+JDbWMaTTRJen6fGhg X2PI+04kywRPz2+SjphKgScX5K21tJhNzyXfYoQGl5ziwKjQiwUremtoD1SwdYWJ uiIYJbskstoiiaxrFeW9A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejtddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 May 2024 10:51:12 -0400 (EDT) Content-Language: en-US In-Reply-To: <86zfsex9mq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285883 Archived-At: On 25/05/2024 17:13, Eli Zaretskii wrote: >> For example, you never >> considered the cases where the files which match the pattern to search >> also match the ignored-extensions, and many other possibilities. >> >> In that case the file will not be searched, same as before this change. No behavior change. > We are talking about performance here. FWIW I don't see which performance problem you have in mind. If you mean the possible regression in the case "user picked file extension that's already in ignores", then I don't think it's going to be any noticeably slower in vast majority of cases. And it's not a scenario to optimize for anyway.