all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: Checking in files with trailing white space
Date: Mon, 12 Dec 2016 23:31:42 -0800	[thread overview]
Message-ID: <366009d8-72f4-2f85-103c-214a5e111e77@cs.ucla.edu> (raw)
In-Reply-To: <83wpf4bj26.fsf@gnu.org>

Eli Zaretskii wrote:
>> I'd rather avoid committing binary data. It's easier to read
>> and review text files, given the tools we have. Any tests that require
>> binary data can generate the data when the test is run.

> How would you generate the likes of test/manual/etags/ETAGS.good_1?

That one is not a problem. By "binary data" I meant files that are not valid 
UTF-8 text, and that file consists entirely of UTF-8 text.

An example of trouble is test/manual/etags/f-src/entry.strange.gz. Instead of 
committing the gzipped file, I'd commit the original text file 'entry.strange', 
and compress a copy as part of the test.

To see an example problem when binary data is committed, visit this URL:

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6db72771cc08e719a08f56db8abd7cefef9c8c99

Because that commit installed some Latin-1 text, the body of that web page 
contains a mixture of UTF-8 and Latin-1. The web page is labeled as UTF-8, so 
the result works poorly with browsers (Firefox displays mojibake lines like 
"+2�4�bb*�abbbc�"). I fixed this particular problem just now in master by 
changing that file to use UTF-8, which works just as well for the Emacs test in 
question.



  reply	other threads:[~2016-12-13  7:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-20 12:55 Checking in files with trailing white space Lars Magne Ingebrigtsen
2016-03-20 13:08 ` Lars Magne Ingebrigtsen
2016-12-11 13:31   ` Alan Mackenzie
2016-12-11 18:50     ` Lars Ingebrigtsen
2016-12-12 22:16       ` Alan Mackenzie
2016-12-12 22:57         ` Paul Eggert
2016-12-13  3:32           ` Eli Zaretskii
2016-12-13  7:31             ` Paul Eggert [this message]
2016-12-13 16:01               ` Eli Zaretskii
2016-12-13 18:33                 ` Paul Eggert
2016-12-13 19:00                   ` Eli Zaretskii
2016-12-13 22:39                     ` Paul Eggert
2016-12-14  3:31                       ` Eli Zaretskii
2016-12-14  7:47                         ` Paul Eggert
2016-12-14 15:32                           ` Eli Zaretskii
2016-12-14 18:15                             ` Paul Eggert
2016-12-14 19:26                               ` Eli Zaretskii
2016-12-13 18:28           ` Alan Mackenzie
2016-12-13 18:39             ` Paul Eggert
2016-03-21 13:10 ` Stefan Monnier
2016-03-21 13:59   ` Lars Magne Ingebrigtsen
2016-03-21 18:09     ` Paul Eggert
2016-04-04 20:05       ` Lars Magne Ingebrigtsen
2016-04-04 21:55         ` Paul Eggert
2016-04-24 13:13           ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=366009d8-72f4-2f85-103c-214a5e111e77@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.