From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#35708: [27.0.50]: thingatpt.el, thing-at-point-looking-at redundant Date: Tue, 14 May 2019 12:02:15 +0200 Message-ID: <364b372e-7896-d92c-f848-0e7abc152a20@easy-emacs.de> References: <8a73a0c9-5b38-4089-2780-28e62a1e162b@easy-emacs.de> <87ftpih6hs.fsf@gmail.com> <1bbebe25-9c4e-2563-701b-9bed85fcabb0@easy-emacs.de> <8536lixikt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="91888"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35708@debbugs.gnu.org To: npostavs@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 12:02:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQUGS-000Nh5-Og for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 12:02:28 +0200 Original-Received: from localhost ([127.0.0.1]:44562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUGR-0007xm-5B for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 06:02:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQUGD-0007wA-UY for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:02:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQUG7-0006V6-3Z for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:02:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQUG2-0006Lf-7i for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:02:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQUG1-00073M-Vi for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 06:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35708 X-GNU-PR-Package: emacs Original-Received: via spool by 35708-submit@debbugs.gnu.org id=B35708.155782809925971 (code B ref 35708); Tue, 14 May 2019 10:02:01 +0000 Original-Received: (at 35708) by debbugs.gnu.org; 14 May 2019 10:01:39 +0000 Original-Received: from localhost ([127.0.0.1]:47433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUFe-0006kb-M1 for submit@debbugs.gnu.org; Tue, 14 May 2019 06:01:39 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.135]:39951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQUFa-0006ci-M7 for 35708@debbugs.gnu.org; Tue, 14 May 2019 06:01:37 -0400 Original-Received: from [192.168.178.39] ([87.123.193.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MD9jV-1hZav30GWX-00980M; Tue, 14 May 2019 12:01:28 +0200 In-Reply-To: <8536lixikt.fsf@gmail.com> Content-Language: en-US X-Provags-ID: V03:K1:9bJFgtzvuROGWBltEER06PITy5cwbx4A/wno1LattUR6GrmYmMV GuYPRVLjkYWCWSjD488ozd5OxFu7eqgcIT1JPxMywAdgFuiYT2j8GLbEIN1wPELF2OaSDkO tbvvxLKF06FsZRFDlpFCVX1syYdVIFCDhaKuYwLdhglpg6tTNzEUK3u0fu0DpEvnST9kPCF 5MaXFIov/X8EtvFmtwhaA== X-UI-Out-Filterresults: notjunk:1;V03:K0:OPIY+dwUX20=:eL0qaN81HNutQp0/A3M+KJ Ak18iH/PKitLEebAM8sexBuzydvm12hBXxdYxrAER5AFaYRFI5CrAuZ0JLX5BizPB6QR9+yJ7 MZstjstayqYnb5WevDy4TWksm96qkirH9WrKVLomtg8WcGIl2A/9c4t2aMKyJeuZO+q+/0Ayu NC9pvN98fTvEfUV8L7lK7tHCwVAmx3CUps6f33fBO7xVZJYOmhkRv8nQsLML97yNJxVUM5Pmf R2fYpKreiuUAMEYYAGiv/WlBJm8i2FOb2sAu82vxEXu7gTAMWuSgNPmKUmco/Jzr/fYJGYk9f O/Iuok8WR9mGJF8/XeVEo/xFflOl/YH6QP9JvlQvwutcCNXa++SlMROTTW3N0emSs2GLTfqnq DqABvealMj7d4b3QZ4XYBVKzfZo1Rhu31YQZ5rBJZjpLkiTF+RSyKCJXMkoFyw3p+HtWQwAPi 7Q2tnHmggHD/9p8IKzFh5unju8BzUgRCgYKwJy+FHjj8fHWgzJKwf84+zVKQl3nCRt3qiZPUZ 0IvLjzUhbjgjNhXihp2MyBEDrdEcVCSfoh5GfXAFuTwLGi4jSzSWEb+EAFvNPp9I4aS9r/ec0 6bnkt4FA40YJ8G3gx07P5hEj78dhXAx3fuwgolcyKSbi2GhMGw+QjYfWMENYw4QcwiUaXSEih 5GtPQwFsk2QfZImCHAtQJ63ENjl4IURlLqbFn1BSspyHW5TBj1odsl4dIcUItpkEZXgBQNwR2 dr2Cp4j1XWiA08PqQ/cmZF2Dluy6ccn6Dxt/PfSpPzfwbV7IHPxecFjP9f9tExJh3rSOhswN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159266 Archived-At: On 13.05.19 21:25, npostavs@gmail.com wrote: > Andreas Röhler writes: > >> Thought at something like below, which should pass the test: >> >> (defun ar-thing-at-point-looking-at (regexp) >>   "Return t if regexp matches at or before point, nil otherwise." >>   (save-excursion >>       (while (not (or (looking-at regexp)(bolp))) >>       (forward-char -1)) >>       (looking-at regexp))) > I think it's an optimization to use re-search-backward instead of moving > on character at a time and calling looking-at in lisp. > > Hmm, current thing-at-point-looking-at might be slow with large buffers. The slightly modified test should reveal it: (ert-deftest thing-at-point-looking-at-2 ()   (with-temp-buffer     (insert "1abcd 222abcd")     (dotimes (_ 99999) (insert " asdf "))     (goto-char (point-min))     (let ((m2 (progn (search-forward "2abcd")                      (match-data))))       (goto-char (point-min))       (search-forward "2ab")       (should (thing-at-point-looking-at "2abcd"))       (should (equal (match-data) m2))))) But let me correct the alternative delivered, as it didn't match before point: (defun ar-regexp-atpt (regexp) "Return t if REGEXP matches at or before point, nil otherwise. Changes match-data"   (save-excursion     (if (looking-at regexp)     (while         (save-excursion           (and (not (bobp))            (progn (backward-char) (looking-at regexp)))))       (while (not (or (bobp) (backward-char) (looking-at regexp))))       (ar-regexp-atpt regexp))     (looking-at regexp)))