* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
@ 2009-03-06 15:17 Adrian Robert
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Robert @ 2009-03-06 15:17 UTC (permalink / raw
To: 2478
> If someone could try and compile the Emacs.app port
> with -DUSE_LISP_UNION_TYPE, this bug (and probably several others)
> would
> get caught during compilation.
I just tried this and found errors in core files relating to
specification of Lisp_Object arguments as "register" variables. I'm
not sure the compiler complaint is specific to the version of gcc on
OS X (4.0.1)?
gcc -c -Demacs -DHAVE_CONFIG_H -I. -I/Users/arobert/src/EmacsApp/
emacs/src -I/usr/X11R6/include -Dtemacs -g -O2 -Wno-pointer-sign -
DUSE_LISP_UNION_TYPE frame.c
frame.c: In function 'delete_frame':
frame.c:1505: error: address of register variable 'force' requested
make: *** [frame.o] Error 1
make: *** Waiting for unfinished jobs....
Then I got an error in nsterm that I can't make sense of:
nsterm.m: In function 'ns_term_init':
nsterm.m:3897: error: incompatible types in assignment
This line is a simple call to a DEFUN taking one arg:
Lisp_Object color_file, color_map, color;
...
color_map = Fx_load_color_file (color_file);
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
@ 2009-03-04 21:23 Adrian Robert
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Robert @ 2009-03-04 21:23 UTC (permalink / raw
To: 2478; +Cc: Nikolaj Schumacher
Thanks, I've applied the patch, leaving bug report open as a reminder
to try this UNION_TYPE as suggested.
-Adrian
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
@ 2009-02-26 8:29 Nikolaj Schumacher
2009-02-26 15:26 ` Stefan Monnier
2009-03-05 3:48 ` Glenn Morris
0 siblings, 2 replies; 5+ messages in thread
From: Nikolaj Schumacher @ 2009-02-26 8:29 UTC (permalink / raw
To: emacs-pretest-bug
Hello,
switching font antialiasing in nextstep doesn't work. A fix is included.
regards,
Nikolaj Schumacher
In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
of 2009-02-26 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure '--with-ns' '--without-x' 'CC=gcc-4.2' 'CFLAGS=-arch i386 -O2''
diff --git a/src/nsfont.m b/src/nsfont.m
index 386637d..e2e537f 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
CGContextSetFont (gcontext, font->cgfont);
CGContextSetFontSize (gcontext, font->size);
- if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
+ if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
CGContextSetShouldAntialias (gcontext, 0);
else
CGContextSetShouldAntialias (gcontext, 1);
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
2009-02-26 8:29 Nikolaj Schumacher
@ 2009-02-26 15:26 ` Stefan Monnier
2009-03-05 3:48 ` Glenn Morris
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2009-02-26 15:26 UTC (permalink / raw
To: Nikolaj Schumacher; +Cc: emacs-pretest-bug, 2478
> --- a/src/nsfont.m
> +++ b/src/nsfont.m
> @@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
> CGContextSetFont (gcontext, font->cgfont);
> CGContextSetFontSize (gcontext, font->size);
> - if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
> + if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
> CGContextSetShouldAntialias (gcontext, 0);
> else
> CGContextSetShouldAntialias (gcontext, 1);
If someone could try and compile the Emacs.app port
with -DUSE_LISP_UNION_TYPE, this bug (and probably several others) would
get caught during compilation.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
2009-02-26 8:29 Nikolaj Schumacher
2009-02-26 15:26 ` Stefan Monnier
@ 2009-03-05 3:48 ` Glenn Morris
1 sibling, 0 replies; 5+ messages in thread
From: Glenn Morris @ 2009-03-05 3:48 UTC (permalink / raw
To: Nikolaj Schumacher; +Cc: 2478
Nikolaj Schumacher wrote:
> A fix is included.
With this, you have seven "tiny changes". You should complete a
copyright assignment before contributing more.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-06 15:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-06 15:17 bug#2478: 23.0.91; font antialiasing switch in nextstep broken Adrian Robert
-- strict thread matches above, loose matches on Subject: below --
2009-03-04 21:23 Adrian Robert
2009-02-26 8:29 Nikolaj Schumacher
2009-02-26 15:26 ` Stefan Monnier
2009-03-05 3:48 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.