all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: Vibhav Pant <vibhavp@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH]: Add new bytecode op `switch' for implementing branch tables.
Date: Thu, 9 Feb 2017 12:32:45 -0500	[thread overview]
Message-ID: <363b8622-feb0-ae73-eb68-77037a2dd77c@gmail.com> (raw)
In-Reply-To: <CA+T2Sh1Vg+WAyUp3sTq=NYZVd6Bo_m09cNHHwEQMn4LKwi8R5A@mail.gmail.com>

On 2017-02-08 08:38, Vibhav Pant wrote:
> On Tue, Feb 7, 2017 at 9:26 PM, Clément Pit-Claudel wrote:
>> The timings fluctuate quite a bit, but the byte-switch branch seems
>> to be about 5-7% slower.  Hopefully linear-scan hash tables will
>> make things much faster :)
>
> The following patch makes hash_lookup use linear search when the
> number of keys in the hash table is <= 5 (chosen arbitrarily). switch
> bytecode run with this patch takes 15.96 seconds to run the
> benchmark, while the goto-if-nil code takes 17.15 seconds.

Thanks! Indeed, here are new timings:

$ rm -f *.elc; emacs-byte-switch -Q --batch --eval '(byte-compile-file "eval-expr.el")'; time emacs-byte-switch -Q --batch -L . -l benchmark-expr.el

real	0m3.703s
user	0m3.664s
sys	0m0.012s

$ rm -f *.elc; emacs -Q --batch --eval '(byte-compile-file "eval-expr.el")'; time emacs -Q --batch -L . -l benchmark-expr.el

real	0m3.878s
user	0m3.860s
sys	0m0.016s

Things still fluctuate, but the byte-switch branch is now consistently faster, by roughly 5% :)

Clément.



  parent reply	other threads:[~2017-02-09 17:32 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 17:50 [PATCH]: Add new bytecode op `switch' for implementing branch tables Vibhav Pant
2017-02-06 18:30 ` Stefan Monnier
2017-02-07  8:45   ` Vibhav Pant
2017-02-07 14:41     ` Stefan Monnier
     [not found]       ` <CA+T2Sh3N09WGoHtNL3BbptsKA1ZdwWedTNDd0vmeBe0fTO5a1g@mail.gmail.com>
     [not found]         ` <CA+T2Sh2sa6=WOvyePzL_ACR0Nw=jTnZze_xXFcvL=22OURP=ZA@mail.gmail.com>
2017-02-07 15:21           ` Vibhav Pant
2017-02-07 13:50   ` Vibhav Pant
2017-02-07 15:56     ` Clément Pit-Claudel
2017-02-08 13:38       ` Vibhav Pant
2017-02-08 16:21         ` Vibhav Pant
2017-02-08 17:46           ` Vibhav Pant
2017-02-09 13:21           ` Stefan Monnier
2017-02-08 17:56         ` Eli Zaretskii
2017-02-23  4:35           ` Compiled code in Emacs-26 will fail in Emacs-25 if use pcase [was: Add new bytecode op `switch' for implementing branch tables.] Tino Calancha
2017-02-23  8:36             ` Richard Copley
2017-02-23 10:12               ` Tino Calancha
2022-07-04 12:24               ` Vibhav Pant
2017-02-23 13:39             ` Stefan Monnier
2017-02-23 14:33               ` Kaushal Modi
2017-02-23 15:10                 ` Stefan Monnier
2022-07-02 20:31                   ` Robert Weiner
2022-07-02 21:28                     ` Stefan Monnier
     [not found]               ` <CA+T2Sh29UhuNrhRZG=PPQbYYHtONXwyb8dX4rBVLmwdORLELhg@mail.gmail.com>
2017-02-23 17:50                 ` Vibhav Pant
2017-04-11 17:40               ` Compiled code in Emacs-26 will fail in Emacs-25 if use pcase Lars Brinkhoff
2017-02-23 16:15             ` Compiled code in Emacs-26 will fail in Emacs-25 if use pcase [was: Add new bytecode op `switch' for implementing branch tables.] raman
2017-02-23 17:24               ` Drew Adams
2017-02-23 17:50                 ` T.V Raman
2017-02-23 18:02                   ` Drew Adams
2017-02-23 18:24                     ` T.V Raman
2017-02-23 19:00                       ` Drew Adams
2017-02-24  2:06                       ` defsubst VS defun or defmacro [was RE: Compiled code in Emacs-26 will fail in Emacs-25 if use pcase] Tino Calancha
2017-02-24  3:14                         ` Eric Abrahamsen
2017-02-24  3:56                           ` raman
2017-02-24  4:20                             ` Eric Abrahamsen
2017-02-24  3:51                         ` raman
2017-02-09 17:32         ` Clément Pit-Claudel [this message]
2017-02-09 19:15         ` [PATCH]: Add new bytecode op `switch' for implementing branch tables Clément Pit-Claudel
2017-02-10  4:12           ` Vibhav Pant
2017-02-10  4:17             ` Clément Pit-Claudel
2017-02-10  5:03               ` Vibhav Pant
2017-02-10  6:07                 ` Stefan Monnier
2017-02-10 13:51                   ` Vibhav Pant
2017-02-10 15:12                     ` Stefan Monnier
2017-02-10 17:59                       ` Vibhav Pant
2017-02-10 18:25                         ` Vibhav Pant
2017-02-10 20:47                           ` Paul Eggert
2017-02-10 20:58                             ` Stefan Monnier
2017-02-11 15:07                             ` Vibhav Pant
2017-02-12  3:10                               ` Vibhav Pant
2017-02-13  7:18                                 ` Vibhav Pant
2017-02-09 16:37       ` Vibhav Pant
2017-02-06 19:32 ` Eli Zaretskii
2017-02-07 14:26   ` Vibhav Pant
2017-02-07 16:14     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=363b8622-feb0-ae73-eb68-77037a2dd77c@gmail.com \
    --to=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.