From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Date: Wed, 19 Apr 2023 18:28:32 +0300 Message-ID: <360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev> References: <97545727-7123-ca74-3d2e-4ac5c6d8f25a@gutov.dev> <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Daniel Mendler , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 62776@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 17:29:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pp9kO-0001RM-AH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 17:29:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp9k5-0006OE-QV; Wed, 19 Apr 2023 11:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp9jy-0006MV-HJ for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pp9jy-0007r4-6u for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pp9jy-0007ev-30 for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62776 X-GNU-PR-Package: emacs Original-Received: via spool by 62776-submit@debbugs.gnu.org id=B62776.168191812429412 (code B ref 62776); Wed, 19 Apr 2023 15:29:02 +0000 Original-Received: (at 62776) by debbugs.gnu.org; 19 Apr 2023 15:28:44 +0000 Original-Received: from localhost ([127.0.0.1]:35568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp9jf-0007eI-GN for submit@debbugs.gnu.org; Wed, 19 Apr 2023 11:28:43 -0400 Original-Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:55089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pp9jd-0007e5-IF for 62776@debbugs.gnu.org; Wed, 19 Apr 2023 11:28:42 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 255732B06704; Wed, 19 Apr 2023 11:28:35 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 19 Apr 2023 11:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1681918114; x=1681921714; bh=w1LFA/enkbs/Zb7OxNFlvZ/R8b6e82QX0K9 i/s8lfJE=; b=dYSjbRW4/aWbR+D1fadVYommA6BZFZxQu30eRpNsayP4Q5sW9ZK xoRBG4iWhJwDp3FDRpdnjWuMvfLrBZxMNNT1+6NJP9/geVb2BbyOXANNdSbruhC1 g7R7ncaqs+A2XP3bFT06ykoa5pL9NU9LgjJ9Se8X7ps5++0eqTfBX+z6HmSY5+xc R6pdPTiez4MV86T0IrSRJ+0JrZ4y7/iRJCDn3Kz20m/Phbqilu0jmkFDrPcs0Lxn Pf0GwZ6yKkhr5vdVX5oJ3H34QjjAdDOsoOCe3pLCnjgNpBSOBBXZvs8Pd6LF2lTE TphmGLBDO4BuRKEsAhQznNGWNP3RMPdHEGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681918114; x= 1681921714; bh=w1LFA/enkbs/Zb7OxNFlvZ/R8b6e82QX0K9i/s8lfJE=; b=I Dimqt2ijQOXZ74g5Mv2hxb5+6A+dceCp1cGYQ1HwZMiOBbSWlo02QYZ+iJAXlrcM OC+awmoPMyAVUXE9csL5brtBZch2pYx8BWupojwKOwzFzLd2CPOoxWq1hSqm6M3Q FLJM/xudVy+u0dbcFeduF+S6gUnbtoUrEb7DJBwihVpGMaGCS5qjQgKDB2ZD4rgH H4/4lKw0tjmU3jsCEW5mIgUzraC9jFeiRR2Se3BVhqdhaHSHpXYfIw2NdUqiVI/d tcK8CO+AUr99l7S9cwoUtYET0Oq2OtJuzFeLS2YyCus9I6j98MbNKLmtzRd2LpWX 4/VKfdcghW4s2meDJhVFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepgeehtdehudejieetuedttdejkeehje etueekheffuddtjeeuvdefveeuveeiuddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 11:28:33 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260273 Archived-At: On 19/04/2023 15:05, Daniel Mendler wrote: > All in all this makes `project-find-file` a special case which we could > handle specially in `vertico--history-hash`, but I try really hard to > avoid accumulating special cases in Vertico. Another alternative would > be to control the sorting directly in `project-find-file` by setting the > `display-sort-function` and `cycle-sort-function`, maybe via a > configuration variable. It is not really obvious where sorting is > handled best. For example in my Consult package, which offers "highly > tuned" completion commands, the commands usually try to control many > aspects of completion (including sorting), while for other simpler > commands it is better to let the completion UI do more of the work. From my outside perspective, it seems appropriate to handle inside this function, if it's at all possible to do without mentioning the exact command name, etc. IIUC the issue is that is has (added) special handling for file name completion, and predicates that on the name of the history variable. It can/should be combined with an extra check which makes sure that the completion table uses '/' as field separators. Maybe using the `completion-boundaries` thingy. Or just straight calling `completion-boundaries` on the history elements to extract the first segment instead of hardcoding '/'.