From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Cambell Barton Newsgroups: gmane.emacs.bugs Subject: bug#36526: 26.2; Open diff at current location (feature request with suggested code) Date: Sat, 14 Sep 2019 05:29:20 +1000 Message-ID: <35d4b535-1e93-ef31-ca63-044721c1314f@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="164016"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 Cc: 36526@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 13 21:30:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8rH2-000gNq-3a for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 21:30:28 +0200 Original-Received: from localhost ([::1]:46994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8rH0-0006WI-Qd for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 15:30:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60505) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8rGi-0006UE-8Y for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 15:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8rGh-000753-2t for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 15:30:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8rGg-00074y-WD for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 15:30:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i8rGg-0003Qy-Rl for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 15:30:06 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Cambell Barton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2019 19:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36526 X-GNU-PR-Package: emacs Original-Received: via spool by 36526-submit@debbugs.gnu.org id=B36526.156840297313089 (code B ref 36526); Fri, 13 Sep 2019 19:30:04 +0000 Original-Received: (at 36526) by debbugs.gnu.org; 13 Sep 2019 19:29:33 +0000 Original-Received: from localhost ([127.0.0.1]:45619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8rG8-0003P3-Dn for submit@debbugs.gnu.org; Fri, 13 Sep 2019 15:29:32 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:37717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8rG6-0003Ok-6B for 36526@debbugs.gnu.org; Fri, 13 Sep 2019 15:29:31 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id c17so7990057pgg.4 for <36526@debbugs.gnu.org>; Fri, 13 Sep 2019 12:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xc6zzzKEv1bxRapOpzLqdxDx5N5PSMb5fuu43lYA0q0=; b=SN5FvzYVzLiLUotJ6HO4kShdy2S8GT/2JXVH2wpuT7QcOJo0vjmefUrzchndotpe7w lYedxm2TPTW+l5D4/rrr/5hnTYiflhJdPRzL//YtA+jQTaHlumngU/QOt32Ulvv/iVSh RsO5+Ugd04EYghcq8dND9+EVVcaBa4Tn+Lo6AreJuZY1DhMM+/1iOmqjVpKxq7J3FOiF cDlBVeKL+2/+4oXCT/CUbynQTWPGkyubgQG/xA4bwMhqkG3Ky0ljc/Qfn3u4+XIxjK3X hHTAj7kxK3rgSdfBWUsPvlSSvuUJiAQ9MK2zFybePSHkXynmQVPOzfGTmUkMBXBop5tB WWsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xc6zzzKEv1bxRapOpzLqdxDx5N5PSMb5fuu43lYA0q0=; b=RQH78d3hd2ARWbAYA7VoIyyuroQRJtC/c+OseJiYv+8TRGCDr3xHJJRuGbb+vhB0uH l0HdzIfhcv0X00dV0zrfidqKBhICm/ZWVauuMIcnMhJPGfR2grfFVJoe8XmlfG6MQDk6 IS+l+w0djiydPpMfImKcRy69S0FUUgQFieBpuip0w2UgPCYvYTCEbugskjBy2fJ4E9A9 bJKwsvu4sX99GdGnPrVjRsuUtZIOyyLubUkfqFi5DY/Xsoi6ugNlc7DJDyUSpaSt31Ku AYNRuEo3yx9BFFpoPxNLiDFq/3CCokxeV8dO1AiKCemdUBa69cqxx/wUX2/EKghTE3lM EKRg== X-Gm-Message-State: APjAAAW0FuHBhvv5ei884Zjj0bjparZml1hEdW0elLbl5GsfBgzNAV2m YR6MheY/ZR5Llv9oRxaJE87KSGVu9TY= X-Google-Smtp-Source: APXvYqwVRZA8TonR7Ueq63Au9eRfi2inpjYMW5FJO6EFg+cIoYNqqR1O13UBogAIcXaDd3TcFTY0fg== X-Received: by 2002:a63:465c:: with SMTP id v28mr1363387pgk.310.1568402964057; Fri, 13 Sep 2019 12:29:24 -0700 (PDT) Original-Received: from [10.1.1.180] (ppp118-209-104-247.bras1.mel11.internode.on.net. [118.209.104.247]) by smtp.gmail.com with ESMTPSA id w6sm57603822pfj.17.2019.09.13.12.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Sep 2019 12:29:23 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166413 Archived-At: Hi Stefan, I don't mind doing the copyright assignment. Would someone be able to check the code and see if it's going in the right direction? I'm still not that experienced with elisp, so I'd rather not spend time to make a patch if the general approach isn't right. On 2019-09-13 21:59, Stefan Kangas wrote: > Campbell Barton writes: > >> This is a feature suggestion which I've written example code for >> >> `vc-root-diff` (or a new function), could jump to the closest line. >> >> This is useful since you move to the context of the current line. >> >> I've written code that does this, >> it would be useful if it was built into emacs. >> >> See: https://emacs.stackexchange.com/a/51439/2418 > > Thanks for the feature suggestion. > > I haven't looked at your code, but if we decided to use it, it seems > like a non-trivial change and would require you to sign copyright > papers. You can find more information about copyright assignment > here: > > https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html > > Would you be willing to do that? > > If the answer to that is yes, could you please also submit your code > as a patch? You can find more information on how to do that in the > CONTRIBUTE file in the emacs repository. That would make it easier to > review and test your suggested changes. > > Best regards, > Stefan Kangas >