From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: alexanderm@web.de, 27427@debbugs.gnu.org
Subject: bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup
Date: Mon, 26 Jun 2017 01:56:28 +0300 [thread overview]
Message-ID: <35924ed4-65fc-6180-8a02-8158a192b4c2@yandex.ru> (raw)
In-Reply-To: <8337aot0fk.fsf@gnu.org>
On 6/25/17 8:57 PM, Eli Zaretskii wrote:
> Should be fixed now.
Thanks, both cases are working well now. See below for the third one
(though it's relatively rare). ;-(
> the fix only works for empty overlays at EOB,
> but that should be enough, right? Or do you see some other way of
> specifying this property at EOB?
No, it seems plenty enough for me. I doubt we'd ever going to try using
text properties for the popup without an overlay.
The third case which disrupts popup positioning: horizontal scrolling,
which we discussed earlier. With native numbers, it breaks our function
which calculates the "usable" window body width. It looks like this:
(defun company--window-width ()
(let ((ww (window-body-width)))
;; Account for the line continuation column.
(when (zerop (cadr (window-fringes)))
(cl-decf ww))
(unless (or (display-graphic-p)
(version< "24.3.1" emacs-version))
;; Emacs 24.3 and earlier included margins
;; in window-width when in TTY.
(cl-decf ww
(let ((margins (window-margins)))
(+ (or (car margins) 0)
(or (cdr margins) 0)))))
(when (and word-wrap
(version< emacs-version "24.4.51.5"))
;; http://debbugs.gnu.org/19300
(cl-decf ww))
;; whitespace-mode with newline-mark
(when (and buffer-display-table
(aref buffer-display-table ?\n))
(cl-decf ww (1- (length (aref buffer-display-table ?\n)))))
ww))
Without going into details, how do I figure out the width which line
number glyphs are taking up? Any way to do that without calling
posn-at-point at the beginning-of-visual-line?
next prev parent reply other threads:[~2017-06-25 22:56 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 16:50 bug#27427: 26.0.50; Native line numbers lead to display error in company-mode popup Alexander Miller
2017-06-19 17:08 ` Eli Zaretskii
[not found] ` <6b307502-53db-e92d-1050-3cf0132537cb@web.de>
2017-06-19 19:23 ` Eli Zaretskii
2017-06-19 19:53 ` Alexander Miller
2017-06-19 21:03 ` Dmitry Gutov
2017-06-20 15:04 ` Eli Zaretskii
2017-06-21 2:18 ` Dmitry Gutov
2017-06-21 2:40 ` Eli Zaretskii
2017-06-21 13:04 ` Dmitry Gutov
2017-06-21 15:51 ` Alexander Miller
2017-06-21 18:15 ` Eli Zaretskii
2017-06-21 22:41 ` Dmitry Gutov
2017-06-22 14:55 ` Eli Zaretskii
2017-06-22 23:17 ` Dmitry Gutov
2017-06-23 9:10 ` Eli Zaretskii
2017-06-23 23:26 ` Dmitry Gutov
2017-06-24 7:47 ` Eli Zaretskii
2017-06-24 17:28 ` Eli Zaretskii
2017-06-24 20:43 ` Dmitry Gutov
2017-06-25 13:51 ` Dmitry Gutov
2017-06-25 14:32 ` Eli Zaretskii
2017-06-25 14:36 ` Dmitry Gutov
2017-06-25 14:13 ` Eli Zaretskii
2017-06-25 14:46 ` Dmitry Gutov
2017-06-25 15:05 ` Eli Zaretskii
2017-06-25 16:35 ` Eli Zaretskii
2017-06-25 17:57 ` Eli Zaretskii
2017-06-25 22:56 ` Dmitry Gutov [this message]
2017-06-26 8:23 ` martin rudalics
2017-06-26 15:07 ` Eli Zaretskii
2017-06-27 7:06 ` martin rudalics
2017-06-27 14:48 ` Eli Zaretskii
2017-06-26 15:22 ` Eli Zaretskii
2017-06-26 15:28 ` Dmitry Gutov
2017-06-26 15:50 ` Eli Zaretskii
2017-06-26 17:12 ` Dmitry Gutov
2017-06-26 21:30 ` Johan Bockgård
2017-06-27 16:47 ` Eli Zaretskii
2017-07-13 23:04 ` Dmitry Gutov
2017-07-14 6:11 ` Eli Zaretskii
2017-07-14 6:24 ` Dmitry Gutov
2017-07-14 7:04 ` Eli Zaretskii
2017-07-15 17:38 ` Dmitry Gutov
2017-07-15 17:49 ` Eli Zaretskii
2017-06-25 14:31 ` Dmitry Gutov
2017-06-25 14:54 ` Eli Zaretskii
2017-06-25 15:25 ` Dmitry Gutov
2017-06-25 16:12 ` martin rudalics
2017-06-25 18:21 ` Eli Zaretskii
2017-06-25 15:59 ` martin rudalics
2017-06-25 16:24 ` Dmitry Gutov
2017-06-25 17:10 ` martin rudalics
2017-06-25 18:36 ` Eli Zaretskii
2017-06-25 18:51 ` Eli Zaretskii
2017-06-26 8:21 ` martin rudalics
2017-06-26 8:18 ` martin rudalics
2017-06-25 18:24 ` Eli Zaretskii
2017-06-26 7:15 ` martin rudalics
2017-06-26 8:18 ` martin rudalics
2017-06-26 12:07 ` Dmitry Gutov
2017-06-26 15:05 ` Eli Zaretskii
2017-06-27 7:06 ` martin rudalics
2017-06-27 14:48 ` Eli Zaretskii
2017-06-27 15:27 ` martin rudalics
2017-06-27 16:27 ` Eli Zaretskii
2017-06-28 8:45 ` martin rudalics
2017-06-28 16:48 ` Eli Zaretskii
2017-06-28 18:35 ` martin rudalics
2017-06-28 18:56 ` Eli Zaretskii
2017-06-29 7:17 ` martin rudalics
2017-06-29 16:29 ` Eli Zaretskii
2017-06-30 8:27 ` martin rudalics
2017-06-30 9:33 ` Eli Zaretskii
2017-07-01 10:31 ` martin rudalics
2017-07-01 11:59 ` Eli Zaretskii
2017-07-01 13:22 ` martin rudalics
2017-07-01 13:33 ` Eli Zaretskii
2017-07-01 15:20 ` martin rudalics
2017-07-01 15:41 ` Eli Zaretskii
2017-07-02 7:54 ` martin rudalics
2017-07-02 14:10 ` Eli Zaretskii
2017-07-02 14:45 ` Dmitry Gutov
2017-07-02 15:18 ` Eli Zaretskii
2017-07-03 0:22 ` Dmitry Gutov
2017-07-03 2:29 ` Eli Zaretskii
2017-07-06 7:08 ` martin rudalics
2017-07-06 13:06 ` Dmitry Gutov
2017-07-07 6:52 ` martin rudalics
2017-07-06 7:08 ` martin rudalics
2017-07-06 15:21 ` Eli Zaretskii
2017-07-07 6:52 ` martin rudalics
2017-06-29 1:34 ` Dmitry Gutov
2017-06-29 16:20 ` Eli Zaretskii
2017-06-29 17:55 ` Dmitry Gutov
2017-06-25 19:00 ` Eli Zaretskii
2017-06-26 8:21 ` martin rudalics
2017-06-26 15:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35924ed4-65fc-6180-8a02-8158a192b4c2@yandex.ru \
--to=dgutov@yandex.ru \
--cc=27427@debbugs.gnu.org \
--cc=alexanderm@web.de \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.