Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile

[Jackson Ray Hamilton <takua95@gmail.com>]

Hi Stefan,

I was hoping we could revisit this issue, and use .elpaignore to exclude
files from byte compilation.

Apparently, tar uses gnulib's excluded_file_name function, which appears
to delegate to fnmatch, which looks pretty complex to me.  I'm not aware
of a "standalone" command providing an interface for this pattern
matcher, but if one exists, maybe we could utilize that.

Another option might be to generate an archive with tar and then use the
list of included files to determine what to compile.  This command:

$ tar -ch packages/context-coloring/ --exclude-vcs -X \
  packages/context-coloring/.elpaignore | tar --list

Produces this output:

packages/context-coloring/
packages/context-coloring/LICENSE
packages/context-coloring/context-coloring-emacs-lisp.el
packages/context-coloring/README.md
packages/context-coloring/context-coloring-javascript.el
packages/context-coloring/context-coloring.el

We could filter down the ".el" files from there.

Jackson

On 08/06/2016 11:29 AM, Stefan Monnier wrote:
>> The contents of these test fixtures are significant.  Changing them caused
>> the project's tests to fail.
> 
> Hmm... indeed I see that now.
> 
>> Can byte compilation be disabled for these
>> files without modifying their source? (For instance, by disabling
>> byte-compilation for the whole fixtures/ directory?  Maybe through
>> .dir-locals.el?  Or maybe by respecting .elpaignore?)
> 
> Respecting .elpaignore would be perfect, indeed.  But that file is using
> a format defined by tar, whereas I'd need to tweak the GNUmakefile rules
> to understand it, which is rather tricky.
> 
> I'll see what I can come up with.
> 
> 
>         Stefan
> 
> 
>> On Thu, Aug 4, 2016 at 6:37 PM, Stefan Monnier <monnier@iro.umontreal.ca>
>> wrote:
> 
>>> branch: master
>>> commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46
>>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>>> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>>>
>>> * fixtures/test/: Don't byte-compile
>>> ---
>>> packages/context-coloring/fixtures/test/cond.el                   |    1
>>> +
>>> packages/context-coloring/fixtures/test/condition-case.el         |    1
>>> +
>>> packages/context-coloring/fixtures/test/defun.el                  |    1
>>> +
>>> packages/context-coloring/fixtures/test/ignored.el                |    1
>>> +
>>> packages/context-coloring/fixtures/test/let.el                    |    1
>>> +
>>> packages/context-coloring/fixtures/test/macroexp-let2.el          |    1
>>> +
>>> packages/context-coloring/fixtures/test/unbalanced-parenthesis.el |    1
>>> +
>>> packages/context-coloring/fixtures/test/varlist-spacing.el        |    1
>>> +
>>> 8 files changed, 8 insertions(+)
>>>
>>> diff --git a/packages/context-coloring/fixtures/test/cond.el
>>> b/packages/context-coloring/fixtures/test/cond.el
>>> index d5aae5b..5ed1ec2 100644
>>> --- a/packages/context-coloring/fixtures/test/cond.el
>>> +++ b/packages/context-coloring/fixtures/test/cond.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (let (a)
>>> (cond
>>> (a t)
>>> diff --git a/packages/context-coloring/fixtures/test/condition-case.el
>>> b/packages/context-coloring/fixtures/test/condition-case.el
>>> index 151f591..56a5f44 100644
>>> --- a/packages/context-coloring/fixtures/test/condition-case.el
>>> +++ b/packages/context-coloring/fixtures/test/condition-case.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (condition-case err
>>> (progn err free)
>>> (error err free)
>>> diff --git a/packages/context-coloring/fixtures/test/defun.el
>>> b/packages/context-coloring/fixtures/test/defun.el
>>> index 10a52f6..173ba0b 100644
>>> --- a/packages/context-coloring/fixtures/test/defun.el
>>> +++ b/packages/context-coloring/fixtures/test/defun.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (defun abc (def ghi &optional jkl)
>>> (+ def ghi jkl free))
>>>
>>> diff --git a/packages/context-coloring/fixtures/test/ignored.el
>>> b/packages/context-coloring/fixtures/test/ignored.el
>>> index 1f5fd42..0c540ff 100644
>>> --- a/packages/context-coloring/fixtures/test/ignored.el
>>> +++ b/packages/context-coloring/fixtures/test/ignored.el
>>> @@ -1,2 +1,3 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (defun a ()
>>> (+ a 1 +1 -1 1.0 #x0 ,a   :a t nil (0 . 0)))
>>> diff --git a/packages/context-coloring/fixtures/test/let.el
>>> b/packages/context-coloring/fixtures/test/let.el
>>> index 49edb50..761a265 100644
>>> --- a/packages/context-coloring/fixtures/test/let.el
>>> +++ b/packages/context-coloring/fixtures/test/let.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (let (a
>>> (b a)
>>> (c free)
>>> diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el
>>> b/packages/context-coloring/fixtures/test/macroexp-let2.el
>>> index 1b61df2..97fbb23 100644
>>> --- a/packages/context-coloring/fixtures/test/macroexp-let2.el
>>> +++ b/packages/context-coloring/fixtures/test/macroexp-let2.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (let (exp)
>>> (macroexp-let2 macroexp-copyable-p v exp
>>> v exp))
>>> diff --git a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>>> b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>>> index caaf7e2..e028aef 100644
>>> --- a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>>> +++ b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
>>> @@ -1,2 +1,3 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (let ())
>>> (let ()
>>> diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.el
>>> b/packages/context-coloring/fixtures/test/varlist-spacing.el
>>> index 97ec208..399cd18 100644
>>> --- a/packages/context-coloring/fixtures/test/varlist-spacing.el
>>> +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el
>>> @@ -1,3 +1,4 @@
>>> +;; -*- no-byte-compile:t' -*-
>>> (let (
>>> (a (lambda ()))))
>>>
>>>