From: "Mattias Engdegård" <mattiase@acm.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 50136@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#50136: 28.0.50; A problem with rx-let expansion
Date: Sat, 21 Aug 2021 15:02:47 +0200 [thread overview]
Message-ID: <3541B092-BD63-4610-BDA8-A43ABD4FAF6D@acm.org> (raw)
In-Reply-To: <878s0vc97a.fsf@web.de>
21 aug. 2021 kl. 13.45 skrev Michael Heerdegen <michael_heerdegen@web.de>:
> (let ((args (list rest))) ...)
>
> inside rx `eval' and use that as argument list variable.
Or just put all the actual code in a plain function:
(eval-when-compile
(defun expand-my-rx-thing (x y &optional z &rest r) ...))
(rx-define my-rx-thing (x y &rest more) (eval (expand-my-rx-thing x y more)))
and use &optional and &rest arguments as you are used to, without any risks of substitution accidents like "string" in the example you showed earlier. The function would effectively work exactly like a macro of the sort you requested.
> Maybe it would be good to improve the docstring to say the things that I
> missed clearer? - Say explicitly that this mechanism is different from
> macros, instead it's just a simple substitution mechanism, and add a
> simple example to the docstring as a reference, even if we already have
> examples in the manual.
I'll see what can be done. It's not really Emacs tradition to have examples in doc strings but maybe they can be improved a bit as you say.
> Maybe also tell that using `eval' you can still have a macro-like
> behavior in the end.
Not a bad idea!
next prev parent reply other threads:[~2021-08-21 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 13:59 bug#50136: 28.0.50; A problem with rx-let expansion Michael Heerdegen
2021-08-20 14:50 ` Michael Heerdegen
2021-08-20 15:23 ` Mattias Engdegård
2021-08-20 17:21 ` Michael Heerdegen
2021-08-20 18:45 ` Mattias Engdegård
2021-08-21 11:45 ` Michael Heerdegen
2021-08-21 13:02 ` Mattias Engdegård [this message]
2021-08-23 10:45 ` Michael Heerdegen
2021-08-23 12:38 ` Mattias Engdegård
2021-08-23 15:20 ` Mattias Engdegård
2021-08-23 16:59 ` Michael Heerdegen
2021-08-23 18:05 ` Mattias Engdegård
2021-08-21 3:21 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3541B092-BD63-4610-BDA8-A43ABD4FAF6D@acm.org \
--to=mattiase@acm.org \
--cc=50136@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.