From: Daniel Colascione <dancol@dancol.org>
To: emacs-devel@gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: Re: master 3d609375f99: Track nil colors in term
Date: Fri, 04 Oct 2024 18:52:13 -0400 [thread overview]
Message-ID: <3517966B-FB69-4C33-9ACE-06C948FE8358@dancol.org> (raw)
In-Reply-To: <609293D2-CAD6-4085-B231-921C3F449773@dancol.org>
On October 3, 2024 11:22:51 PM EDT, Daniel Colascione <dancol@dancol.org> wrote:
>
>
>On October 3, 2024 12:30:02 AM PDT, Michael Albinus <michael.albinus@gmx.de> wrote:
>>Daniel Colascione <dancol@dancol.org> writes:
>>
>>Hi Daniel,
>>
>>> branch: master
>>> commit 3d609375f99cd0d4b7a441802d4616bad385e31d
>>> Author: Daniel Colascione <dancol@dancol.org>
>>> Commit: Daniel Colascione <dancol@dancol.org>
>>>
>>> Track nil colors in term
>>
>>This breaks term-tests.el
>>
>>--8<---------------cut here---------------start------------->8---
>># make -C test term-tests
>>Test term-colors backtrace:
>> signal(ert-test-failed (((should (equal (text-properties-at 0 result
>> ert-fail(((should (equal (text-properties-at 0 result) (text-propert
>> (if (unwind-protect (setq value-52 (apply fn-50 args-51)) (setq form
>> (let (form-description-54) (if (unwind-protect (setq value-52 (apply
>> (let ((value-52 'ert-form-evaluation-aborted-53)) (let (form-descrip
>> (let* ((fn-50 #'equal) (args-51 (condition-case err (list (text-prop
>> (let ((result (term-test-screen-from-input 40 12 str))) (let* ((fn-4
>> (let ((str x41) (expected x43)) (let ((result (term-test-screen-from
>> (progn (ignore (null x44)) (let ((str x41) (expected x43)) (let ((re
>> (let* ((x43 (car-safe x42)) (x44 (cdr-safe x42))) (progn (ignore (nu
>> (progn (ignore (consp x42)) (let* ((x43 (car-safe x42)) (x44 (cdr-sa
>> (let* ((x41 (car-safe x40)) (x42 (cdr-safe x40))) (progn (ignore (co
>> (progn (ignore (consp x40)) (let* ((x41 (car-safe x40)) (x42 (cdr-sa
>> (let ((x40 (car tail))) (progn (ignore (consp x40)) (let* ((x41 (car
>> (while tail (let ((x40 (car tail))) (progn (ignore (consp x40)) (let
>> (let ((tail ansi-test-strings)) (while tail (let ((x40 (car tail)))
>> #f(lambda () [term-width term-height t] (let* ((fn-35 #'memq) (args-
>> #f(compiled-function () #<bytecode 0xbbf98e0752cafb4>)()
>> handler-bind-1(#f(compiled-function () #<bytecode 0xbbf98e0752cafb4>
>> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>> ert-run-test(#s(ert-test :name term-colors :documentation nil :body
>> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
>> ert-run-tests-batch((not (tag :unstable)))
>> ert-run-tests-batch-and-exit((not (tag :unstable)))
>> eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
>> command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
>> command-line()
>> normal-top-level()
>>Test term-colors condition:
>> (ert-test-failed
>> ((should
>> (equal (text-properties-at 0 result)
>> (text-properties-at 0 expected)))
>> :form (equal (font-lock-face (...)) (font-lock-face (...))) :value
>> nil :explanation
>> (list-elt 1
>> (list-elt 0
>> (proper-lists-of-different-length 4 6
>> ... ... first-mismatch-at
>> 2)))))
>> FAILED 2/12 term-colors (0.000633 sec) at lisp/term-tests.el:139
>>Test term-colors-bold-is-bright backtrace:
>> signal(ert-test-failed (((should (equal (text-properties-at 0 result
>> ert-fail(((should (equal (text-properties-at 0 result) (text-propert
>> (if (unwind-protect (setq value-74 (apply fn-72 args-73)) (setq form
>> (let (form-description-76) (if (unwind-protect (setq value-74 (apply
>> (let ((value-74 'ert-form-evaluation-aborted-75)) (let (form-descrip
>> (let* ((fn-72 #'equal) (args-73 (condition-case err (list (text-prop
>> (let ((expected (or bright-expected expected)) (result (term-test-sc
>> (let ((str x61) (expected x63) (bright-expected x65)) (let ((expecte
>> (progn (ignore (null x66)) (let ((str x61) (expected x63) (bright-ex
>> (let* ((x65 (car-safe x64)) (x66 (cdr-safe x64))) (progn (ignore (nu
>> (progn (ignore (consp x64)) (let* ((x65 (car-safe x64)) (x66 (cdr-sa
>> (let* ((x63 (car-safe x62)) (x64 (cdr-safe x62))) (progn (ignore (co
>> (progn (ignore (consp x62)) (let* ((x63 (car-safe x62)) (x64 (cdr-sa
>> (let* ((x61 (car-safe x60)) (x62 (cdr-safe x60))) (progn (ignore (co
>> (progn (ignore (consp x60)) (let* ((x61 (car-safe x60)) (x62 (cdr-sa
>> (let ((x60 (car tail))) (progn (ignore (consp x60)) (let* ((x61 (car
>> (while tail (let ((x60 (car tail))) (progn (ignore (consp x60)) (let
>> (let ((tail ansi-test-strings)) (while tail (let ((x60 (car tail)))
>> (let ((ansi-color-bold-is-bright t)) (let ((tail ansi-test-strings))
>> #f(lambda () [term-width term-height t] (let* ((fn-55 #'memq) (args-
>> #f(compiled-function () #<bytecode 0xbbf98e0752cafb4>)()
>> handler-bind-1(#f(compiled-function () #<bytecode 0xbbf98e0752cafb4>
>> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>> ert-run-test(#s(ert-test :name term-colors-bold-is-bright :documenta
>> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>> ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
>> ert-run-tests-batch((not (tag :unstable)))
>> ert-run-tests-batch-and-exit((not (tag :unstable)))
>> eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
>> command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
>> command-line()
>> normal-top-level()
>>Test term-colors-bold-is-bright condition:
>> (ert-test-failed
>> ((should
>> (equal (text-properties-at 0 result)
>> (text-properties-at 0 expected)))
>> :form (equal (font-lock-face (...)) (font-lock-face (...))) :value
>> nil :explanation
>> (list-elt 1
>> (list-elt 0
>> (proper-lists-of-different-length 4 6
>> ... ... first-mismatch-at
>> 2)))))
>> FAILED 3/12 term-colors-bold-is-bright (0.002501 sec) at lisp/term-tests.el:147
>>--8<---------------cut here---------------end--------------->8---
>
>
>
>Thanks. Looking at the traces in your message, ISTM the test should change.
>
Fixed. Thanks for the heads up.
prev parent reply other threads:[~2024-10-04 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172793041800.756080.13048066383280198150@vcs3.savannah.gnu.org>
[not found] ` <20241003044018.B2B201687C1@vcs3.savannah.gnu.org>
2024-10-03 7:30 ` master 3d609375f99: Track nil colors in term Michael Albinus
2024-10-04 3:22 ` Daniel Colascione
2024-10-04 22:52 ` Daniel Colascione [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3517966B-FB69-4C33-9ACE-06C948FE8358@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.