From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30813: 26.0.91; flyspell does not recheck after transpose-chars Date: Wed, 14 Mar 2018 07:28:43 +0200 Message-ID: <3515DB7F-4590-497B-B576-AA63E66A00BA@gnu.org> References: <83k1ufqq6v.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521005229 11475 195.159.176.226 (14 Mar 2018 05:27:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Mar 2018 05:27:09 +0000 (UTC) User-Agent: K-9 Mail for Android Cc: 30813@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 14 06:27:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evywK-0002sK-WC for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Mar 2018 06:27:05 +0100 Original-Received: from localhost ([::1]:44511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evyyN-000209-Us for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Mar 2018 01:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evyyH-0001zi-DB for bug-gnu-emacs@gnu.org; Wed, 14 Mar 2018 01:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evyyE-00010e-9D for bug-gnu-emacs@gnu.org; Wed, 14 Mar 2018 01:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evyyE-00010K-5J for bug-gnu-emacs@gnu.org; Wed, 14 Mar 2018 01:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evyyD-0003XK-MN for bug-gnu-emacs@gnu.org; Wed, 14 Mar 2018 01:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Mar 2018 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30813 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30813-submit@debbugs.gnu.org id=B30813.152100533913585 (code B ref 30813); Wed, 14 Mar 2018 05:29:01 +0000 Original-Received: (at 30813) by debbugs.gnu.org; 14 Mar 2018 05:28:59 +0000 Original-Received: from localhost ([127.0.0.1]:60320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evyyA-0003X3-OD for submit@debbugs.gnu.org; Wed, 14 Mar 2018 01:28:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1evyy9-0003Wq-V3 for 30813@debbugs.gnu.org; Wed, 14 Mar 2018 01:28:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evyy3-0000qI-Ty for 30813@debbugs.gnu.org; Wed, 14 Mar 2018 01:28:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evyy0-0000mF-5u; Wed, 14 Mar 2018 01:28:48 -0400 Original-Received: from [176.13.14.231] (port=53124 helo=[10.131.77.100]) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1evyxz-0001eZ-7f; Wed, 14 Mar 2018 01:28:48 -0400 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144242 Archived-At: On March 14, 2018 7:17:14 AM GMT+02:00, Aaron Jensen wrote: > On Tue, Mar 13, 2018 at 9:56 PM, Aaron Jensen > wrote: > > Upon some inspection, it seems flyspell is meant to be set up to do > > this already=2E See `flyspell-check-pre-word-p', which returns nil in > > this scenario=2E Perhaps it can be expanded to handle this scenario=2E >=20 > For posterity, this works: >=20 > (defun aj/flyspell-transpose-check () > (with-local-quit > (when (and (eq this-command 'transpose-chars) > flyspell-pre-point) > (save-excursion > (goto-char (- flyspell-pre-point 1)) > (flyspell-word))))) >=20 > (advice-add 'flyspell-post-command-hook :before > #'aj/flyspell-transpose-check) >=20 > I'd be happy to include offer a patch for something like this, but I'm > not sure if there's a better way and/or if it's nasty to hard-code a > command like this=2E What does that do when C-t is invoked with a numeric argument? More generally, I think if we want to support transpose commands in flyspe= ll, we need special code for that, because those commands change two words, which both need to be checked, something that flyspell-check-pre-word-p i= s not designed to handle=2E