From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Compilation warnings in mouse.el Date: Tue, 12 Jul 2016 14:04:50 +0000 (UTC) Message-ID: <3513ab5e-4a5e-4abe-abee-81c0a4a3cb0e@default> References: <<8360scdzik.fsf@gnu.org>> <<87zipnzvo4.fsf@gmx.net>> <<8337nfcupy.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468332404 7596 80.91.229.3 (12 Jul 2016 14:06:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 14:06:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 12 16:06:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMyKT-0003iS-PE for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 16:06:29 +0200 Original-Received: from localhost ([::1]:40728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMyKP-00084R-Ry for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 10:06:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMyJA-0006J2-Fo for emacs-devel@gnu.org; Tue, 12 Jul 2016 10:05:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMyJ5-0004GS-G6 for emacs-devel@gnu.org; Tue, 12 Jul 2016 10:05:07 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:35257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMyJ0-0004FN-9d; Tue, 12 Jul 2016 10:04:58 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CE4rAa025291 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2016 14:04:54 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u6CE4qdw015307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 14:04:53 GMT Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u6CE4oSu012410; Tue, 12 Jul 2016 14:04:51 GMT In-Reply-To: <<8337nfcupy.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205580 Archived-At: > Unlike Stefan, I think we should add :group to every defcustom. > Having them mysteriously missing from some of them is a time bomb: > remove or add enough defcustoms in the same file, and you have a bug. 100% agreement. I don't even think we should have introduced this "shortcut" or "timesaver" feature. It serves no purpose and can lead to problems. > Are there any downsides to having :group in all defcustoms? Not that I can see. I'd like to see it be required, but if it's too late for that then I'd like to see a compiler warning at least.