all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 9d626df: Add 'nofollow' flag to set-file-modes etc.
Date: Tue, 25 Feb 2020 15:02:06 -0800	[thread overview]
Message-ID: <34bee2b9-0a34-2a85-15cf-f846888ed144@cs.ucla.edu> (raw)
In-Reply-To: <87k14bni2b.fsf@detlef.i-did-not-set--mail-host-address--so-tickle-me>

On 2/25/20 1:15 AM, Michael Albinus wrote:
> Shouldn't Tramp behave similar, and raise an error if "chmod -h" or
> something similar does not work?

Yes and no. If FOO is a symlink and "chmod -h FOO" fails, set-file-modes 
should signal an error. But if FOO is a non-symlink file and "chmod -h 
FOO" fails on a platform like GNU/Linux where chmod does not have an -h 
option, set-file-modes should not signal an error; it should use plain 
"chmod FOO" instead.

(Andreas's recent comment was right as usual, by the way.)

PS. I followed up the set-file-modes change with a similar proposal for 
set-file-times (Bug#39773).



  reply	other threads:[~2020-02-25 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200224004617.19362.5846@vcs0.savannah.gnu.org>
     [not found] ` <20200224004619.58020206ED@vcs0.savannah.gnu.org>
2020-02-24 13:52   ` master 9d626df: Add 'nofollow' flag to set-file-modes etc Michael Albinus
2020-02-25  0:25     ` Paul Eggert
2020-02-25  9:15       ` Michael Albinus
2020-02-25 23:02         ` Paul Eggert [this message]
2020-02-26  0:29           ` Michael Albinus
2020-02-25  9:23       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34bee2b9-0a34-2a85-15cf-f846888ed144@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.