all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 61532@debbugs.gnu.org
Subject: bug#61532: 30.0.50; [PATCH]: Make completions without sortText fall to back of the list
Date: Sun, 19 Feb 2023 17:08:19 +0100	[thread overview]
Message-ID: <348D7924-284D-4D14-882E-02C8CAD7A925@thornhill.no> (raw)
In-Reply-To: <CALDnm51U+b25Q=zjhq-M0PS_y=GvzceVXBO8CiVQEPvVNcwy9Q@mail.gmail.com>



On 19 February 2023 12:13:46 CET, "João Távora" <joaotavora@gmail.com> wrote:
>On Sat, Feb 18, 2023 at 10:18 PM Theodor Thornhill <theo@thornhill.no>
>wrote:
>
>>
>> Ping :-)
>
>
>[Thanks for the ping. Without it, i would probably not be aware of the
>message
>which was primarily intented for me, since I'm not (at the present)
>following the
>bug tracker list.  Next time, you can add me to the special X-Debbugs-CC:
>header]

Pretty sure I did that, but it doesn't matter :)


>
>To your patch, I think it is quite acceptable.  I've pushed it to emacs-29.
>

Great news!

>I'll keep the bug open, since there is also the second problem which I
>still don't
>quite understand, but it looks like a bug, too.  But I think I have enough
>information
>to investigate on my own for now.
>
>João

I don't think it's a bug, really. Isn't it just the flex style greediness? It feels like it tries to match the longest string possible alphabetically? It's just unintuitive because the json results doesn't match the output, and debugstepping over was very unhelpful. We could maybe just add some docs explaining that eglot default, which for many really is an eglot hard-coding.

But not sure, and the workaround in the report works anyways :)

Theo





  reply	other threads:[~2023-02-19 16:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 14:52 bug#61532: 30.0.50; [PATCH]: Make completions without sortText fall to back of the list Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 22:18 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 11:13   ` João Távora
2023-02-19 16:08     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-19 18:19       ` João Távora
2023-02-19 18:43         ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 18:48           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 22:47             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 23:39               ` João Távora
2023-02-19 23:53                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 18:52         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 22:56         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21  8:24           ` Augusto Stoffel
2023-02-21  8:24         ` Augusto Stoffel
2023-02-21 12:47           ` João Távora
2023-02-21 14:08             ` Augusto Stoffel
2023-02-21 14:28               ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348D7924-284D-4D14-882E-02C8CAD7A925@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61532@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.