From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#23864: 25.1.50; Poor network responsivenes using open-network-stream Date: Wed, 29 Jun 2016 21:50:47 -0400 Message-ID: <347fd7savc.fsf@fencepost.gnu.org> References: <22386.52993.297791.550073@ender.chrekh.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467251483 27579 80.91.229.3 (30 Jun 2016 01:51:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Jun 2016 01:51:23 +0000 (UTC) Cc: 23864@debbugs.gnu.org, Christer Ekholm To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 30 03:51:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bIR8I-0000bA-OJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jun 2016 03:51:10 +0200 Original-Received: from localhost ([::1]:46477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIR8I-00079w-57 for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Jun 2016 21:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIR8C-00079r-7u for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2016 21:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIR8A-0006Zb-8w for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2016 21:51:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIR8A-0006ZX-5H for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2016 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bIR89-0005Lo-Vz for bug-gnu-emacs@gnu.org; Wed, 29 Jun 2016 21:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2016 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23864 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23864-submit@debbugs.gnu.org id=B23864.146725146120561 (code B ref 23864); Thu, 30 Jun 2016 01:51:01 +0000 Original-Received: (at 23864) by debbugs.gnu.org; 30 Jun 2016 01:51:01 +0000 Original-Received: from localhost ([127.0.0.1]:60448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIR88-0005LZ-Q8 for submit@debbugs.gnu.org; Wed, 29 Jun 2016 21:51:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIR86-0005LL-Mn for 23864@debbugs.gnu.org; Wed, 29 Jun 2016 21:50:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIR80-0006ZA-Ni for 23864@debbugs.gnu.org; Wed, 29 Jun 2016 21:50:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIR7y-0006Yl-67; Wed, 29 Jun 2016 21:50:50 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bIR7v-0003rt-T4; Wed, 29 Jun 2016 21:50:48 -0400 X-Spook: mindwar Marijuana Subway Help Nuevo Leon 2600 Magazine X-Ran: GoSccfRKZAH]$@)B]b,O)g@OvH)INTid?i|c'.Y@yznu@/02#7kE12-Pmu(])GR,!0f[Jl X-Hue: cyan X-Attribution: GM In-Reply-To: <22386.52993.297791.550073@ender.chrekh.se> (Christer Ekholm's message of "Tue, 28 Jun 2016 21:24:49 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120222 Archived-At: Christer Ekholm wrote: > I decided to test the next release, and observed that a elisp package > i'm using got very poor networ responsivenes. > > I have bisected to commit > ad236260 Avoid duplicate calls to current_timespec I see this is in emacs-25, so perhaps should be fixed there. > And, The attached patch fixes it for me > >>>From ce0d739141770f885527a9f1a2db8ff79599ae11 Mon Sep 17 00:00:00 2001 > From: Christer Ekholm > Date: Sun, 26 Jun 2016 01:53:42 +0200 > Subject: [PATCH] Fix condition for return from waiting for process output. > > * src/process.c (wait_reading_process_output): Move the test for > process output to outside setting of cmp_time, so that we don't miss > to exit if we have output, but got_output_end_time is not valid. > --- > src/process.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/process.c b/src/process.c > index ed0c529..23e2c52 100644 > --- a/src/process.c > +++ b/src/process.c > @@ -5271,12 +5271,13 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd, > timers. */ > if (wait < TIMEOUT) > break; > + if (!process_skipped && got_some_output > 0 > + && (!timespec_valid_p (got_output_end_time) > + || (timeout.tv_sec > 0 || timeout.tv_nsec > 0))) > + break; > struct timespec cmp_time > = (wait == TIMEOUT > ? end_time > - : (!process_skipped && got_some_output > 0 > - && (timeout.tv_sec > 0 || timeout.tv_nsec > 0)) > - ? got_output_end_time > : invalid_timespec ()); > if (timespec_valid_p (cmp_time)) > { > -- > 2.9.0 > > In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) > of 2016-06-28 built on jane > Repository revision: 2adc4ccd03d24660bcf7f8ff056c7f32b92b584d > Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 > System Description: Gentoo Base System release 2.2