From: Robert Spillner <trent2@web.de>
To: Glenn Morris <rgm@gnu.org>
Cc: 33344@debbugs.gnu.org
Subject: bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces
Date: Fri, 23 Nov 2018 00:47:53 +0100 [thread overview]
Message-ID: <3410970.m2UEhoW63l@calvin> (raw)
In-Reply-To: <9ein120yhb.fsf@fencepost.gnu.org>
Hi,
sorry for the late answer -- these mails didn't go through my spam-filter.
The patch does work.
As I'm neither an active emacs programmer, lisp developer, or security expert
I don't have a sound opinion whether this should be the way to do this. But as
there might be security implications with unchecked strings which are
introduced in a shell call it is probably better not to do it. But if this
change is part of a larger code review which is going to be introduced a long
time frm now it might be a better idea to do the quotation-hack first and
replace it later by a better solution so the bug get fixed for now.
Just my two cents.
> Glenn Morris wrote:
>
> Thanks for the report.
> I don't see a need for the shell to be involved at all here.
> The following seems to work for me - how about for you?
>
next prev parent reply other threads:[~2018-11-22 23:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 11:36 bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces Robert Spillner
2018-11-12 21:36 ` Glenn Morris
2018-11-13 17:08 ` Eli Zaretskii
2018-11-13 18:12 ` Glenn Morris
2018-11-13 19:24 ` Eli Zaretskii
2018-11-14 18:14 ` Glenn Morris
2018-11-14 19:29 ` Eli Zaretskii
2018-11-22 23:47 ` Robert Spillner [this message]
2020-08-26 12:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3410970.m2UEhoW63l@calvin \
--to=trent2@web.de \
--cc=33344@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.