From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.emacs.bugs Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Date: Sat, 18 Feb 2023 11:48:26 +0100 Message-ID: <33K7WG12CN39M.2BL8XP3YCDT9O@venera> References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mblaze/1.2 Cc: 61577-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 11:49:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTKmM-00009e-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 11:49:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTKm8-0007Xi-F9; Sat, 18 Feb 2023 05:49:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTKm6-0007Qb-JC for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 05:49:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTKm6-00014n-8x for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 05:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTKm5-0007zN-Oe for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 05:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61577 X-GNU-PR-Package: emacs Original-Received: via spool by 61577-done@debbugs.gnu.org id=D61577.167671731830669 (code D ref 61577); Sat, 18 Feb 2023 10:49:01 +0000 Original-Received: (at 61577-done) by debbugs.gnu.org; 18 Feb 2023 10:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTKlh-0007yb-I4 for submit@debbugs.gnu.org; Sat, 18 Feb 2023 05:48:37 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]:65436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTKlf-0007y0-8m for 61577-done@debbugs.gnu.org; Sat, 18 Feb 2023 05:48:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676717308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tO3ITojurrX5eMUIrP43rzW+ELoc4jnoZX/kf/SOPTg=; b=Gz0HtDU9ZD3YjCKvDMJam5zD7Zwkhop+w2eD7pAy1yseRHxp/JO4XL7pmedoVehkLOBk8w 7vQfhgXf9AP9iI2x3Yo7Vky3SJp0XZcd0t166feo0oFQG3GSzYBo96pSCPrEUbCQygVPrf x3dCKLmWEuszS2ABggNg46G94XgSxcA= Original-Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id f2434e7e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Feb 2023 11:48:28 +0100 (CET) Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b2c4a4e9; Sat, 18 Feb 2023 11:48:26 +0100 (CET) In-Reply-To: <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255951 Archived-At: On 2023/02/18 01:11:10 +0200, Dmitry Gutov wrote: > Version: 29.1 >=20 > Hi! >=20 > On 17/02/2023 18:56, Omar Polo wrote: >=20 > > project-try-vc (IIRC) used to loop over all the vc-backends to find the= > > root of a project. Now, it=E2=80=99s just an hardcoded list in a local= > > variable. This breaks the project-* functions on Got checkouts. > >=20 > > I can imagine the reason of the change (avoid loading all the vc-*.el > > files I guess) but it would be nice for this variable to be at least > > user-configurable, otherwise we will always end up with missing entries= =2E >=20 > The reasons were actually related to performance during the search. I thought so, thanks for confirming :) > > (Yeah, one could add their own hooks in project-find-functions for > > that, but seems replicating stuff that project.el tries to do anyway.) > >=20 > > Attaching a diff that temporarly works around the problem by adding the= > > Got -> .got mapping. >=20 > Thanks for the report, I've pushed your addition and also moved the list=20= > to a defvar. Not defcustom, though, to avoid encouraging people from=20 > changing it unnecessarily (instead of project-vc-extra-root-markers). >=20 > Originally, I figured all major backends should be covered, but it won't=20= > hurt to add one more, especially since vc-got is in ELPA. I guess that now the (require 'vc-svn) could go away too. Thanks! P.S.: thanks also for the explanation about CVS/RCS/SCCS/SRC. To be fair I never used the project-* functions in a CVS checkout before yesterday, and it makes sense not to include them by default. Well, maaaybe a vc-cvs-root that walks up until the root of the checkout could be provided, but I'm not too knowledgable about CVS and my usage of it is scarce enough that I didn't feel the reason to have it. Hardly used anything other than C-x v =3D in CVS checkouts. diff /home/op/build/emacs commit - 0be5f7ab6368175953c0a5bcbbd485fd9edda2b0 path + /home/op/build/emacs blob - 1228c73fee86bbae3727fddd8a9687496849b040 file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -512,8 +512,6 @@ See `project-vc-extra-root-markers' for the marker val See `project-vc-extra-root-markers' for the marker value format.") =20 (defun project-try-vc (dir) - (defvar vc-svn-admin-directory) - (require 'vc-svn) ;; FIXME: Learn to invalidate when the value of ;; `project-vc-merge-submodules' or `project-vc-extra-root-markers' ;; changes.