all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chris Newton <redshodan@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Subject: bug#4680: 23.1.50; minor url-http.el fix
Date: Thu, 15 Oct 2009 07:57:06 -0600	[thread overview]
Message-ID: <339668590910150657y516d0c7bk794cdc8dc8cc7ccd@mail.gmail.com> (raw)
In-Reply-To: <abpr8pyw8o.fsf@fencepost.gnu.org>

Whoops. I don't know what I was thinking about url-display-percentage.
Ignore that. :)

I came across this because of twit.el. It can do http operations every
so often in the background. It binds (with let, so local bind, what
ever the terminology is) url-show-status to nil when doing an async
get. Since its async, it sets up a process buffer to do the get. But
in the context of the process buffer, the local binding of
url-show-status is long gone and the primary value takes over. By
default its t, which would make sense for the vast majority of cases.
So url-http displays progress on a background process when the user of
url-http does not what that to happen.

On Thu, Oct 15, 2009 at 1:03 AM, Glenn Morris <rgm@gnu.org> wrote:
> Chris Newton wrote:
>
>> Here is a small fix for the url-http function. When binding the
>> url-show-status and/or url-display-percentage variables they would not
>> get copied to the async buffer. So calls to url-lazy-message would not
>> do the correct thing. The patch just adds those two functions to the
>> list of variables to be copied. Thanks.
>
> I'm sorry, can you explain why this is necessary? Can you give an
> example of what the behaviour is with and without this change?
>
> On the face of it, this change makes no sense to me. url-show-status
> is a user option, and url-display-percentage is a function, not a
> variable.
>
>
> @@ -1142,6 +1144,8 @@
>                       url-http-chunked-start
>                       url-callback-function
>                       url-callback-arguments
> +                      url-show-status
> +                      url-display-percentage
>                       url-http-process
>                       url-http-method
>                       url-http-extra-headers
>





  reply	other threads:[~2009-10-15 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 22:51 bug#4680: 23.1.50; minor url-http.el fix Chris Newton
2009-10-15  7:03 ` Glenn Morris
2009-10-15 13:57   ` Chris Newton [this message]
2011-07-13 14:12     ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=339668590910150657y516d0c7bk794cdc8dc8cc7ccd@mail.gmail.com \
    --to=redshodan@gmail.com \
    --cc=4680@emacsbugs.donarmstrong.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.