all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#38416: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message
@ 2019-11-28 13:25 LinSun
  2020-01-12  8:06 ` bug#39094: " lin.sun
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: LinSun @ 2019-11-28 13:25 UTC (permalink / raw)
  To: 38416, ericludlam

[-- Attachment #1: Type: text/html, Size: 3070 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#39094: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message
  2019-11-28 13:25 bug#38416: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message LinSun
@ 2020-01-12  8:06 ` lin.sun
       [not found]   ` <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu>
  2020-01-19  2:32 ` bug#38416: Acknowledgement (27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
  2020-01-19  2:35 ` bug#38416: Recall: " lin.sun
  2 siblings, 1 reply; 5+ messages in thread
From: lin.sun @ 2020-01-12  8:06 UTC (permalink / raw)
  To: 39094, eliz

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi Eli,

The attachment is a patch to fix the complaint message from `makefile-move-to-macro' for the param for re-search-forward isn't escaped.
To reproduce the issue, just run follow commands in your shell,
$ echo 'AM_LIBTMP_LIBS:=$(shell X \--libs)' > /tmp/Makefile.am
$ emacs -Q --eval '(progn (global-ede-mode t)(semantic-mode t)(find-file "/tmp/Makefile.am"))'

Could you please review and apply the patch? 
Thank you.

B.R.
Lin Sun

[-- Attachment #2: 0001-Fix-the-error-message-from-makefile-move-to-macro.patch --]
[-- Type: application/octet-stream, Size: 1360 bytes --]

From 9dfa710fd57095cceb025f665e71772f93e6bbe4 Mon Sep 17 00:00:00 2001
From: "lin.sun" <lin.sun@zoom.us>
Date: Fri, 1 Nov 2019 10:25:17 +0800
Subject: [PATCH] Fix the error message from `makefile-move-to-macro'

* makefile-edit.el: regexp-quote the param in makefile-move-to-macro.
With `(global-ede-mode t)' and `(semantic-mode t)' enabled, error
happened when open a Makefile.am which has '$' or '\\' in its macro
list. Simply create a Makefile.am include the line
'AM_LIBTMP_LIBS:=$(shell X \--libs)', open the file with ede and
semantic mode enabled will trigger this issue. Escape the param for
re-search-forward in `makefile-move-to-macro' can fix this.
---
 lisp/cedet/ede/makefile-edit.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/cedet/ede/makefile-edit.el b/lisp/cedet/ede/makefile-edit.el
index 7d8a44b..add1675 100644
--- a/lisp/cedet/ede/makefile-edit.el
+++ b/lisp/cedet/ede/makefile-edit.el
@@ -78,7 +78,7 @@ makefile-move-to-macro
 If NEXT is non-nil, move to the next occurrence of MACRO."
   (let ((oldpt (point)))
     (when (not next) (goto-char (point-min)))
-    (if (re-search-forward (concat "^\\s-*" macro "\\s-*[+:?]?=") nil t)
+    (if (re-search-forward (concat "^\\s-*" (regexp-quote macro) "\\s-*[+:?]?=") nil t)
 	t
       (goto-char oldpt)
       nil)))
-- 
2.2.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#39094: regexp-quote the param in makefile-move-to-macro to avoid error message
       [not found]   ` <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu>
@ 2020-01-17  8:17     ` Eli Zaretskii
  0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2020-01-17  8:17 UTC (permalink / raw)
  To: Paul Eggert; +Cc: 39094, lin.sun

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 16 Jan 2020 16:12:01 -0800
> Cc: 39094-done@debbugs.gnu.org
> 
> Thanks for reporting that bug. I installed your patch into the master 
> branch.

Thanks, but such safe bugfixes should go to the release branch.  I've
cherry-picked it now.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#38416: Acknowledgement (27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message)
  2019-11-28 13:25 bug#38416: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message LinSun
  2020-01-12  8:06 ` bug#39094: " lin.sun
@ 2020-01-19  2:32 ` lin.sun
  2020-01-19  2:35 ` bug#38416: Recall: " lin.sun
  2 siblings, 0 replies; 5+ messages in thread
From: lin.sun @ 2020-01-19  2:32 UTC (permalink / raw)
  To: 38416

Close this ticket please. 
The original issue is fixed in #39094, both emacs 27.50 and emacs master.






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#38416: Recall: bug#38416: Acknowledgement (27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message)
  2019-11-28 13:25 bug#38416: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message LinSun
  2020-01-12  8:06 ` bug#39094: " lin.sun
  2020-01-19  2:32 ` bug#38416: Acknowledgement (27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
@ 2020-01-19  2:35 ` lin.sun
  2 siblings, 0 replies; 5+ messages in thread
From: lin.sun @ 2020-01-19  2:35 UTC (permalink / raw)
  To: 38416

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

lin.sun@zoom.us would like to recall the message, "bug#38416:
Acknowledgement (27.0.50;; [PATCH] * makefile-edit.el: regexp-quote the
param in makefile-move-to-macro to avoid error message)".

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 1813 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-01-19  2:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-28 13:25 bug#38416: 27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message LinSun
2020-01-12  8:06 ` bug#39094: " lin.sun
     [not found]   ` <25c4e204-0465-5e7a-4183-8e5a23989b85@cs.ucla.edu>
2020-01-17  8:17     ` bug#39094: " Eli Zaretskii
2020-01-19  2:32 ` bug#38416: Acknowledgement (27.0.50; ; [PATCH] * makefile-edit.el: regexp-quote the param in makefile-move-to-macro to avoid error message) lin.sun
2020-01-19  2:35 ` bug#38416: Recall: " lin.sun

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.