From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: casouri@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca,
theo@thornhill.no
Subject: Re: Tree-sitter and major mode inheritance
Date: Sun, 20 Nov 2022 14:45:59 +0200 [thread overview]
Message-ID: <32f83435-f655-f0db-891c-8244df084299@yandex.ru> (raw)
In-Reply-To: <83cz9i6rvl.fsf@gnu.org>
On 20.11.2022 08:51, Eli Zaretskii wrote:
>> But js2-mode inherits from js-mode (meaning, it will run the same setup
>> code, and then some of its own), yet it has its own parser. Which will
>> cause all sorts of conflicts with tree-sitter.
> js2-mode is not in Emacs, so I cannot control what it does. Ideally, it
> will need only minor adjustments (like making sure it doesn't turn on
> tree-sitter if it doesn't want to) or none at all.
That was my question: how would those "minor adjustments" look if not
the way Yuan proposed things.
> If our changes somehow break js2-mode, we should discuss the details and try
> to fix the breakage as much as is reasonable from our side. The details
> aren't important from where I stand; what is important is that users of
> js-mode can still use the mode even if they don't have tree-sitter installed
> or don't want to use it even if it is installed.
I agree with that goal, of course.
next prev parent reply other threads:[~2022-11-20 12:45 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 20:45 Tree-sitter and major mode inheritance Yuan Fu
2022-11-18 21:54 ` Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Jostein Kjønigsen
2022-11-18 22:34 ` Philip Kaludercic
2022-11-18 22:58 ` Yuan Fu
2022-11-18 23:36 ` Stefan Monnier
2022-11-19 7:09 ` Philip Kaludercic
2022-11-19 14:07 ` Standardized access to a REPL (was: Suggesting that feature/tree-sitter be merged) Stefan Monnier
2022-11-19 15:03 ` Standardized access to a REPL Philip Kaludercic
2022-11-19 16:07 ` Stefan Monnier
2022-11-19 16:10 ` Philip Kaludercic
2022-11-19 16:18 ` Eli Zaretskii
2022-11-19 22:31 ` Stefan Monnier
2022-11-20 9:25 ` Philip Kaludercic
2022-11-19 8:29 ` Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Eli Zaretskii
2022-11-19 10:46 ` Philip Kaludercic
2022-11-19 11:36 ` Eli Zaretskii
2022-11-19 12:15 ` Philip Kaludercic
2022-11-19 13:05 ` Eli Zaretskii
2022-11-19 21:34 ` Dmitry Gutov
2022-11-18 22:52 ` Yuan Fu
2022-11-19 5:21 ` Theodor Thornhill
2022-11-19 18:35 ` Eli Zaretskii
2022-11-19 18:46 ` Theodor Thornhill
2022-11-19 18:51 ` Eli Zaretskii
2022-11-19 18:59 ` Theodor Thornhill
2022-11-19 7:36 ` Stefan Kangas
2022-11-19 8:09 ` Eli Zaretskii
2022-11-19 11:25 ` Stefan Kangas
2022-11-19 11:49 ` Theodor Thornhill
2022-11-19 12:03 ` Eli Zaretskii
2022-11-19 8:16 ` Eli Zaretskii
2022-11-19 9:41 ` Tree-sitter and major mode inheritance Yuan Fu
2022-11-19 10:26 ` Eli Zaretskii
2022-11-19 10:29 ` Po Lu
2022-11-19 15:19 ` Stefan Monnier
2022-11-19 17:17 ` Yuan Fu
2022-11-19 17:52 ` Eli Zaretskii
2022-11-19 21:45 ` Yuan Fu
2022-11-20 7:05 ` Eli Zaretskii
2022-11-20 0:38 ` Po Lu
2022-11-19 21:39 ` Dmitry Gutov
2022-11-19 21:49 ` Yuan Fu
2022-11-19 22:03 ` Dmitry Gutov
2022-11-19 22:36 ` Dmitry Gutov
2022-11-19 23:36 ` Yuan Fu
2022-11-19 23:42 ` Dmitry Gutov
2022-11-20 7:28 ` Eli Zaretskii
2022-11-20 13:22 ` Dmitry Gutov
2022-11-20 14:49 ` Eli Zaretskii
2022-11-20 15:24 ` Dmitry Gutov
2022-11-20 7:11 ` Eli Zaretskii
2022-11-20 9:19 ` Yuan Fu
2022-11-20 10:02 ` Eli Zaretskii
2022-11-20 22:57 ` Yuan Fu
2022-11-20 7:05 ` Eli Zaretskii
2022-11-20 17:12 ` Dmitry Gutov
2022-11-20 17:34 ` Eli Zaretskii
2022-11-20 6:51 ` Eli Zaretskii
2022-11-20 12:45 ` Dmitry Gutov [this message]
2022-11-20 14:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f83435-f655-f0db-891c-8244df084299@yandex.ru \
--to=dgutov@yandex.ru \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.