From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Fri, 21 Feb 2020 02:22:32 +0200 Message-ID: <32b1f22f-1ac9-7fd2-0377-4c2d7ae43afd@yandex.ru> References: <877e5dzgnb.fsf@gnus.org> <932cfe15-5e8b-1bf4-5b81-9d0f2a513dea@yandex.ru> <87a77hqp6m.fsf@mail.linkov.net> <87zhdghjca.fsf@mail.linkov.net> <5d2163b9-4bf4-e072-ef9e-0fc1550a2108@yandex.ru> <87imk35uy6.fsf@mail.linkov.net> <87v9o0kg1f.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="26292"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 01:23:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4w63-0006jJ-FI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 01:23:11 +0100 Original-Received: from localhost ([::1]:50774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4w62-0003pp-HM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Feb 2020 19:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33893) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4w5u-0003pU-TI for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:23:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4w5t-0005ih-Sn for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4w5t-0005ic-PS for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4w5t-0005VA-Kg for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 19:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.158224456221125 (code B ref 34949); Fri, 21 Feb 2020 00:23:01 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 21 Feb 2020 00:22:42 +0000 Original-Received: from localhost ([127.0.0.1]:46146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4w5a-0005Uf-JW for submit@debbugs.gnu.org; Thu, 20 Feb 2020 19:22:42 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:39461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4w5Y-0005US-Ob for 34949@debbugs.gnu.org; Thu, 20 Feb 2020 19:22:41 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id y11so65343wrt.6 for <34949@debbugs.gnu.org>; Thu, 20 Feb 2020 16:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MUgSZWI1Dhf3HtLgCqhlS0Tyg3l7ci+ihpKaZSETOYs=; b=Eh8gvfpCN6ndBp75C1Cy5iozS2GDb6ewFUZYOUUafvQD9Mr4h9dS8wjH87cagMLQSi T/+V75BD6AgfXfh/Pe5CTcwAy+yro+I2nwnqlcMELQF/cdFuuiZeFl3iTBqmiskBJf0v xeZnjQ4YOEID5pz85ZqVTGP/+63tnzrNA8fot3LlvxC9eQKTAEe6yf0cUpJHlQaTcng8 +zAwh810udIuGIWgQv0O14srZrzvW3gBu3JKcy5bBtGH4CfFU77og4vfUl2VlXDQb/uI i5e9vJFzNGv5U5ngcIacny9P4IxG3kF0WAHcPm6xLp2FNMw6mfnknH7JhtCJtcPgjoKi 0tmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MUgSZWI1Dhf3HtLgCqhlS0Tyg3l7ci+ihpKaZSETOYs=; b=oWma9fpZLbIEgBZHdd4gO6B/C8MoxfQABYOpC+LbRbcQV4TRIN6BL8Pdp/XQrlX+WO vN84d4lcheqYLVSoQUQZzODh/ZPrbqgztlO4JqSSAG+HMZFg/k0zSr7v/2C5TDKMzvbw SZtub2ie3g3i9BZtXViNzsZSJzoPLKx7xYMN0V+b1ipMTkokVEPNWp+5GSod+ho1gnks eS45bVWNhXqMKNUpYsExtbM7VYbUJ50b6lCeYmmzbZmlFEEOvmaaDhxr2jXmFvAzOnTG Wb8HM6Ql6yMVRJrTCxsQ9ARPIoOb/cBonnJtywGwacEcAO+6DB0Nsw/ACIM+FNnu+GS4 k7eA== X-Gm-Message-State: APjAAAWwlB2EbKDKecsKq05Xr6wtCkOqJprI5uYldmts2CzcuC++Eaz3 2Mh/hvRV47lw4S2t1r7fVYZGx8LN X-Google-Smtp-Source: APXvYqwHj+DFh3AOzeHjxCxRArDbsWz+otKWYJJNJpyxCXmF+h3KVWx5eDroIWTEO5nCQffcPmA+NA== X-Received: by 2002:a5d:6a88:: with SMTP id s8mr44612856wru.173.1582244554545; Thu, 20 Feb 2020 16:22:34 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id y7sm1492694wrr.56.2020.02.20.16.22.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Feb 2020 16:22:33 -0800 (PST) In-Reply-To: <87v9o0kg1f.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176333 Archived-At: On 21.02.2020 1:14, Juri Linkov wrote: > Also some parts of the previous patch should be reverted > because I discovered that state changing VC operations in Dired > even on marked files (as opposed to directories) is unreliable: > when a file is modified, using vc-state doesn't return its real state > when updated outside of Emacs. Right. More so than in VC-Dir buffers, which use dir-status-files already. > +(defun vc-directory-deduce-fileset (dir callback) > + ;; TODO: use vc-dir-status-files > + ) I should note that if could be, by any chance, satisfied with only using vc-next-action-on-root in VC-Dir buffers, there would be no need to call dir-status-files here. > +(defun vc-dir-status-files (backend dir files update-function) > + (funcall update-function > + (mapcar (lambda (file) (list file 'up-to-date)) files))) This is a... test function?