From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom. Date: Mon, 26 Feb 2018 04:33:01 +0200 Message-ID: <32a4ebb4-5977-9805-c226-ec4666bc31aa@yandex.ru> References: <20180221213025.27066.69339@vcs0.savannah.gnu.org> <20180221213027.372932052F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519612309 30131 195.159.176.226 (26 Feb 2018 02:31:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 02:31:49 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 Cc: Juri Linkov To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 26 03:31:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eq8Zr-0007Hr-Bh for ged-emacs-devel@m.gmane.org; Mon, 26 Feb 2018 03:31:43 +0100 Original-Received: from localhost ([::1]:56818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq8bt-0002hB-Km for ged-emacs-devel@m.gmane.org; Sun, 25 Feb 2018 21:33:49 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq8bG-0002gx-8a for emacs-devel@gnu.org; Sun, 25 Feb 2018 21:33:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq8bB-0000n9-C4 for emacs-devel@gnu.org; Sun, 25 Feb 2018 21:33:10 -0500 Original-Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:36910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eq8bB-0000mk-4w for emacs-devel@gnu.org; Sun, 25 Feb 2018 21:33:05 -0500 Original-Received: by mail-wr0-x22c.google.com with SMTP id z12so19625254wrg.4 for ; Sun, 25 Feb 2018 18:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YcngzNUg37QJiUXKnb00eM36bdFU84WTvgJe/OhbowQ=; b=aDkAciXWIeVD7aTTn/GmUYPQei7R7aY1lCQceGYWWCp7gdUdeSd0rO9c8l2Wjx6ZJ0 L1wHYyVCuDMF8wRoCks/VDHZEuLHnIc2HXqVGKzssK3L+9+auSt2y26p0V3CZi5uDbiw 4IFsLZOer7i3MWLVI+ism97KretEH7lZ6P1ainfg2Q/L1sIQHWJE/DV+CIzQnUIKv3pq nnQOODI/AZU6F9QYmbUVVvz9hgAi+K5CE6lcrCBQEAUImXoXyoxvKMwXYqHQFClyy/On OqaKENP5infAygbm8Z6GoJIzeV0lTL/n8Ydo08z+pM3z8Y+wCFcSbZLC0GDI3AOTfCre Vd1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YcngzNUg37QJiUXKnb00eM36bdFU84WTvgJe/OhbowQ=; b=GDzHq2wwX8BaAHN8axJuBTLuoa50XSSdCbC7Qs3D/EqGSz4BFQ1LH0uECuIWNLg9yU 7xpmNp9uJehLqy6UAKIXaFpyy2WQx/XodCkt6yM9Uzj/OzCmOv80m6lKubezmCPuFK4x 9IWN3yGeEj+bihfq5l7TJZfkdX6X23aKgDRldJdibtyj4L2NoI8vgfY/Tw6K4DTk4nPe rSGVyJmjbkJvLUDGYPv64bPbHBwUUCYq7Z9QADIIxCOfuFERfFmEhpbebg0yXzeF2bRV avbjDGlQhthzOJyLylRyhsuDWk91efbGipont+KqOgSOskUHUtG+s6luhgEaI36q4c+s 8JCA== X-Gm-Message-State: APf1xPDj370OJjaKmXMasmWga4iQuxK6CvMmAdbyTeQanrx5DbWFiVD4 KT+OQIP72gINE4yGJR77TfCtQgbJ X-Google-Smtp-Source: AH8x226QpZhovyOCyeqFIDg/Q0KM+5UiIpJjCoNRCrsU/Jk3Tbp1YGhFZv+uHaq6JULHkRVsMr5zrQ== X-Received: by 10.223.132.38 with SMTP id 35mr8282121wrf.2.1519612383918; Sun, 25 Feb 2018 18:33:03 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id g52sm18081334wra.20.2018.02.25.18.33.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Feb 2018 18:33:02 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223033 Archived-At: On 2/22/18 12:04 AM, Stefan Monnier wrote: >> +(defcustom next-error-find-buffer-function nil > > Why make it a defcustom rather than a defvar? I think we'll want to provide a set of predefined functions in the future, for the user to choose one from. >> + (when next-error-find-buffer-function >> + (funcall next-error-find-buffer-function avoid-current >> + extra-test-inclusive >> + extra-test-exclusive)) > > Could you arrange for the default value of this new *-function var not > to be nil so we can modify it with add-function? Personally, I don't really expect this variable to be modified programmatically. And if it is, most likely not in a "function combination" fashion. But, of course, I might be wrong.