all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Cc: Juri Linkov <juri@linkov.net>
Subject: Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
Date: Mon, 26 Feb 2018 04:33:01 +0200	[thread overview]
Message-ID: <32a4ebb4-5977-9805-c226-ec4666bc31aa@yandex.ru> (raw)
In-Reply-To: <jwvvaeqxasr.fsf-monnier+emacsdiffs@gnu.org>

On 2/22/18 12:04 AM, Stefan Monnier wrote:
>> +(defcustom next-error-find-buffer-function nil
> 
> Why make it a defcustom rather than a defvar?

I think we'll want to provide a set of predefined functions in the 
future, for the user to choose one from.

>> +   (when next-error-find-buffer-function
>> +     (funcall next-error-find-buffer-function avoid-current
>> +                                              extra-test-inclusive
>> +                                              extra-test-exclusive))
> 
> Could you arrange for the default value of this new *-function var not
> to be nil so we can modify it with add-function?

Personally, I don't really expect this variable to be modified 
programmatically. And if it is, most likely not in a "function 
combination" fashion.

But, of course, I might be wrong.



  parent reply	other threads:[~2018-02-26  2:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180221213025.27066.69339@vcs0.savannah.gnu.org>
     [not found] ` <20180221213027.372932052F@vcs0.savannah.gnu.org>
2018-02-21 22:04   ` [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom Stefan Monnier
2018-02-22 21:38     ` bug#20489: " Juri Linkov
2018-02-23 14:36       ` Stefan Monnier
2018-02-24 21:34         ` Juri Linkov
2018-02-25 13:19           ` Stefan Monnier
2018-02-25 20:40             ` Juri Linkov
2018-02-26  2:33     ` Dmitry Gutov [this message]
2018-02-26  3:24       ` Stefan Monnier
2018-02-27 21:39         ` Juri Linkov
2018-02-27 22:13           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32a4ebb4-5977-9805-c226-ec4666bc31aa@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.